On Mon, Mar 02, 2015 at 05:38:29AM +0100, Mateusz Guzik wrote:
> On Sun, Mar 01, 2015 at 08:31:26AM +1100, Dave Chinner wrote:
> > On Sat, Feb 28, 2015 at 05:25:57PM +0300, Alexey Dobriyan wrote:
> > > Freezing and thawing are separate system calls, task which is supposed
> > > to thaw filesystem/s
Returning &ip->i_inode when ip is NULL is safe as i_inode is the first
member in struct gfs2_inode, but that's not immediately obvious.
Reorganize gfs2_alloc_inode to avoid any doubt.
Signed-off-by: Andrew Price
---
Re-sending with a more appropriate commit log based on Andreas' comments.
fs/g
On 03/02/2015 05:30 PM, Andrew Price wrote:
> On 02/03/15 16:17, Steven Whitehouse wrote:
>> Hi,
>>
>> On 02/03/15 16:15, Andrew Price wrote:
> Ah, so it is. Self-NACK then.
The patch itself is still worth it though, it's not self-evident ip and
&ip->i_inode are the same.
Andreas
On 02/03/15 16:17, Steven Whitehouse wrote:
Hi,
On 02/03/15 16:15, Andrew Price wrote:
Return NULL when ip is NULL instead of dereferencing it.
Signed-off-by: Andrew Price
---
fs/gfs2/super.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/fs/gfs2/super.c
Hi,
On 02/03/15 16:15, Andrew Price wrote:
Return NULL when ip is NULL instead of dereferencing it.
Signed-off-by: Andrew Price
---
fs/gfs2/super.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/fs/gfs2/super.c b/fs/gfs2/super.c
index 1666382..37c59ee 1006
Return NULL when ip is NULL instead of dereferencing it.
Signed-off-by: Andrew Price
---
fs/gfs2/super.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/fs/gfs2/super.c b/fs/gfs2/super.c
index 1666382..37c59ee 100644
--- a/fs/gfs2/super.c
+++ b/fs/gfs2/super.c
@
Free sbd.secontext after is_pathname_mounted allocates it. As the RHEL6
metafs code has no construct/destruct model similar to upstream, the
secontext string has to be freed in a few places additional to
cleanup_metafs.
Resolves: #1121693
Signed-off-by: Andrew Price
---
gfs2/fsck/initialize.c |
On Mon, Mar 02, 2015 at 05:38:29AM +0100, Mateusz Guzik wrote:
> On Sun, Mar 01, 2015 at 08:31:26AM +1100, Dave Chinner wrote:
> > On Sat, Feb 28, 2015 at 05:25:57PM +0300, Alexey Dobriyan wrote:
> > > Freezing and thawing are separate system calls, task which is supposed
> > > to thaw filesystem/s
On Sun, Mar 01, 2015 at 08:31:26AM +1100, Dave Chinner wrote:
> On Sat, Feb 28, 2015 at 05:25:57PM +0300, Alexey Dobriyan wrote:
> > Freezing and thawing are separate system calls, task which is supposed
> > to thaw filesystem/superblock can disappear due to crash or not thaw
> > due to a bug. At l