Re: [Cluster-devel] [PATCH 13/17] dlm: fix _can_be_granted() for lock at the head of covert queue.

2017-08-17 Thread tsutomu.owa
Hi, >> After looking more closely, this is a subtle form of conversion deadlock, >> and this exact case is described in the comment here: thanks, we withdraw this patch for now since we need to look into more. -- owa -Original Message- From: David Teigland [mailto:teigl...@redhat.com]

Re: [Cluster-devel] [PATCH 1/2] gfs2_edit savemeta: Fix up saving of dinodes/symlinks

2017-08-17 Thread Andrew Price
On Thu, Aug 17, 2017 at 06:10:26PM +0100, Andrew Price wrote: > Factor out the code that decides whether to save the dinode contents, > improve its error reporting (and don't exit) and make sure contents of > symlink dinodes are saved. > > Signed-off-by: Andrew Price > --- >

Re: [Cluster-devel] [PATCH 1/2] gfs2_edit savemeta: Fix up saving of dinodes/symlinks

2017-08-17 Thread Bob Peterson
- Original Message - | Factor out the code that decides whether to save the dinode contents, | improve its error reporting (and don't exit) and make sure contents of | symlink dinodes are saved. | | Signed-off-by: Andrew Price | --- | gfs2/edit/savemeta.c | 52 |

[Cluster-devel] [PATCH 1/2] gfs2_edit savemeta: Fix up saving of dinodes/symlinks

2017-08-17 Thread Andrew Price
Factor out the code that decides whether to save the dinode contents, improve its error reporting (and don't exit) and make sure contents of symlink dinodes are saved. Signed-off-by: Andrew Price --- gfs2/edit/savemeta.c | 52

[Cluster-devel] [PATCH 2/2] gfs2_edit savemeta: Use size_t for saved structure lengths

2017-08-17 Thread Andrew Price
Although the value range can fit in an int it's better to use an unsigned type consistent with sizeof and memcpy. Signed-off-by: Andrew Price --- gfs2/edit/savemeta.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/gfs2/edit/savemeta.c