Hi,
>> After looking more closely, this is a subtle form of conversion deadlock,
>> and this exact case is described in the comment here:
thanks, we withdraw this patch for now since we need to look into more.
-- owa
-Original Message-
From: David Teigland [mailto:teigl...@redhat.com]
On Thu, Aug 17, 2017 at 06:10:26PM +0100, Andrew Price wrote:
> Factor out the code that decides whether to save the dinode contents,
> improve its error reporting (and don't exit) and make sure contents of
> symlink dinodes are saved.
>
> Signed-off-by: Andrew Price
> ---
>
- Original Message -
| Factor out the code that decides whether to save the dinode contents,
| improve its error reporting (and don't exit) and make sure contents of
| symlink dinodes are saved.
|
| Signed-off-by: Andrew Price
| ---
| gfs2/edit/savemeta.c | 52
|
Factor out the code that decides whether to save the dinode contents,
improve its error reporting (and don't exit) and make sure contents of
symlink dinodes are saved.
Signed-off-by: Andrew Price
---
gfs2/edit/savemeta.c | 52
Although the value range can fit in an int it's better to use an
unsigned type consistent with sizeof and memcpy.
Signed-off-by: Andrew Price
---
gfs2/edit/savemeta.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/gfs2/edit/savemeta.c