Re: [Cluster-devel] [PATCH] gfs2: Fsync parent directories

2018-02-20 Thread Dave Chinner
On Tue, Feb 20, 2018 at 09:53:59PM +0100, Andreas Gruenbacher wrote: > On 20 February 2018 at 20:46, Christoph Hellwig wrote: > > On Tue, Feb 20, 2018 at 12:22:01AM +0100, Andreas Gruenbacher wrote: > >> When fsyncing a new file, also fsync the directory the files is in, > >>

Re: [Cluster-devel] [PATCH] gfs2: Fsync parent directories

2018-02-20 Thread Andreas Gruenbacher
On 20 February 2018 at 20:46, Christoph Hellwig wrote: > On Tue, Feb 20, 2018 at 12:22:01AM +0100, Andreas Gruenbacher wrote: >> When fsyncing a new file, also fsync the directory the files is in, >> recursively. This is how Linux filesystems should behave nowadays, >> even

Re: [Cluster-devel] [PATCH] gfs2: Fsync parent directories

2018-02-20 Thread Christoph Hellwig
On Tue, Feb 20, 2018 at 12:22:01AM +0100, Andreas Gruenbacher wrote: > When fsyncing a new file, also fsync the directory the files is in, > recursively. This is how Linux filesystems should behave nowadays, > even if not mandated by POSIX. I think that is bullshit. Maybe it is what google

Re: [Cluster-devel] [PATCH] gfs2: Fix fallocate chunk size

2018-02-20 Thread Bob Peterson
- Original Message - | The chunk size of allocations in __gfs2_fallocate is calculated | incorrectly. The size can collapse, causing __gfs2_fallocate to | allocate one block at a time, which is very inefficient. This needs | fixing in two places: | | In gfs2_quota_lock_check, always set

Re: [Cluster-devel] [PATCH] gfs2: Fsync parent directories

2018-02-20 Thread Bob Peterson
Hi Andreas, - Original Message - | When fsyncing a new file, also fsync the directory the files is in, | recursively. This is how Linux filesystems should behave nowadays, | even if not mandated by POSIX. | | Based on ext4 commits 14ece1028, d59729f4e, and 9f713878f. | | Fixes xfstests