[Cluster-devel] gfs2-utils: mkfs segfault with 4.16 kernel

2018-05-04 Thread Valentin Vidic
Hello, We are starting to see mkfs segfaults after updating linux-libc-dev from 4.15.17-1 to 4.16.5-1 due to a change in gfs2_ondisk.h. Hope there is enough info below for a fix? :) Reading symbols from ./gfs2-utils-3.1.10/gfs2/mkfs/mkfs.gfs2...done. (gdb) run -p lock_nolock test Starting progr

Re: [Cluster-devel] gfs2-utils: mkfs segfault with 4.16 kernel

2018-05-04 Thread Valentin Vidic
On Fri, May 04, 2018 at 11:42:31AM +0200, Valentin Vidic wrote: > We are starting to see mkfs segfaults after updating > linux-libc-dev from 4.15.17-1 to 4.16.5-1 due to a > change in gfs2_ondisk.h. Hope there is enough info > below for a fix? :) Here goes another trace: (gdb) run -p lock_nolock

Re: [Cluster-devel] gfs2-utils: mkfs segfault with 4.16 kernel

2018-05-04 Thread Andrew Price
Hi Valentin, On 04/05/18 10:50, Valentin Vidic wrote: On Fri, May 04, 2018 at 11:42:31AM +0200, Valentin Vidic wrote: We are starting to see mkfs segfaults after updating linux-libc-dev from 4.15.17-1 to 4.16.5-1 due to a change in gfs2_ondisk.h. Hope there is enough info below for a fix? :)

[Cluster-devel] [PATCH] mkfs.gfs2: fix tests call to gfs_max_blocks

2018-05-04 Thread Valentin Vidic
Replace call to nonexisting util_max_blocks. Signed-off-by: Valentin Vidic --- tests/mkfs.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/mkfs.at b/tests/mkfs.at index 7ae6fcc2..ee444f50 100644 --- a/tests/mkfs.at +++ b/tests/mkfs.at @@ -52,7 +52,7 @@ AT_CLEANUP A

Re: [Cluster-devel] [PATCH] mkfs.gfs2: fix tests call to gfs_max_blocks

2018-05-04 Thread Andrew Price
On 04/05/18 11:00, Valentin Vidic wrote: Replace call to nonexisting util_max_blocks. Signed-off-by: Valentin Vidic --- tests/mkfs.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Applied - thanks! Andy diff --git a/tests/mkfs.at b/tests/mkfs.at index 7ae6fcc2..ee444f50 100644

Re: [Cluster-devel] gfs2-utils: mkfs segfault with 4.16 kernel

2018-05-04 Thread Andrew Price
On 04/05/18 11:21, Valentin Vidic wrote: On Fri, May 04, 2018 at 11:06:59AM +0100, Andrew Price wrote: Can you reproduce it with the master branch? Also, what is the size of your test file? And what architecture is this on? Master branch seems to fail too. Test file was 200 MB on amd64. Also

Re: [Cluster-devel] gfs2-utils: mkfs segfault with 4.16 kernel

2018-05-04 Thread Valentin Vidic
On Fri, May 04, 2018 at 11:27:35AM +0100, Andrew Price wrote: > One other thing to check is whether ./configure was re-run after > gfs2_ondisk.h was upgraded. Yes, just restoring the previous version (4.15) of /usr/include/linux/gfs2_ondisk.h fixes the tests. -- Valentin

Re: [Cluster-devel] gfs2-utils: mkfs segfault with 4.16 kernel

2018-05-04 Thread Andrew Price
On 04/05/18 11:42, Valentin Vidic wrote: On Fri, May 04, 2018 at 11:27:35AM +0100, Andrew Price wrote: One other thing to check is whether ./configure was re-run after gfs2_ondisk.h was upgraded. Yes, just restoring the previous version (4.15) of /usr/include/linux/gfs2_ondisk.h fixes the

Re: [Cluster-devel] gfs2-utils: mkfs segfault with 4.16 kernel

2018-05-04 Thread Valentin Vidic
On Fri, May 04, 2018 at 11:46:08AM +0100, Andrew Price wrote: > Ok, so just to be clear, after installing the 4.16 gfs2_ondisk.h and then > doing "./configure && make clean && make" the bug still occurs? That is correct, attaching 4.16 gfs2_ondisk.h so you can test. -- Valentin /* SPDX-License-I

Re: [Cluster-devel] gfs2-utils: mkfs segfault with 4.16 kernel

2018-05-04 Thread Andrew Price
On 04/05/18 11:54, Valentin Vidic wrote: On Fri, May 04, 2018 at 11:46:08AM +0100, Andrew Price wrote: Ok, so just to be clear, after installing the 4.16 gfs2_ondisk.h and then doing "./configure && make clean && make" the bug still occurs? Hm curious. I *can* reproduce the same segfaults but

Re: [Cluster-devel] gfs2-utils: mkfs segfault with 4.16 kernel

2018-05-04 Thread Valentin Vidic
On Fri, May 04, 2018 at 12:07:01PM +0100, Andrew Price wrote: > Hm curious. I *can* reproduce the same segfaults but only if I build with > the 4.15 header and then rebuild with the 4.16 header *without* first > running ./configure. If I run ./configure the problem resolves itself. Thanks, I remov

Re: [Cluster-devel] gfs2-utils: mkfs segfault with 4.16 kernel

2018-05-04 Thread Andrew Price
On 04/05/18 13:01, Valentin Vidic wrote: On Fri, May 04, 2018 at 12:07:01PM +0100, Andrew Price wrote: Hm curious. I *can* reproduce the same segfaults but only if I build with the 4.15 header and then rebuild with the 4.16 header *without* first running ./configure. If I run ./configure the pro

Re: [Cluster-devel] gfs2-utils: mkfs segfault with 4.16 kernel

2018-05-04 Thread Andrew Price
On 04/05/18 14:01, Andrew Price wrote: On 04/05/18 13:01, Valentin Vidic wrote: On Fri, May 04, 2018 at 12:07:01PM +0100, Andrew Price wrote: Hm curious. I *can* reproduce the same segfaults but only if I build with the 4.15 header and then rebuild with the 4.16 header *without* first running

Re: [Cluster-devel] gfs2-utils: mkfs segfault with 4.16 kernel

2018-05-04 Thread Valentin Vidic
On Fri, May 04, 2018 at 02:16:24PM +0100, Andrew Price wrote: > Try this. Thanks, only meta test fails now, probably size check in some other place: ## - ## ## Test results. ## ## - ## ERROR: All 30 tests were run, 1 failed unexpectedly. ## ## ##