Re: [Cluster-devel] [GFS2 PATCH] GFS2: Eliminate bitmap clones

2018-07-02 Thread Andreas Gruenbacher
On 2 July 2018 at 19:58, Bob Peterson wrote: > Hi, > > Do we really still need "clone bitmaps" in gfs2? If so, why? > I think maybe we can get rid of them. Can someone (Steve Whitehouse > perhaps?) think of a scenario in which they're still needed? If so, > please elaborate and give an example. >

[Cluster-devel] [GFS2 PATCH] GFS2: Eliminate bitmap clones

2018-07-02 Thread Bob Peterson
Hi, Do we really still need "clone bitmaps" in gfs2? If so, why? I think maybe we can get rid of them. Can someone (Steve Whitehouse perhaps?) think of a scenario in which they're still needed? If so, please elaborate and give an example. Regards, Bob Peterson --- Before this patch, gfs2 kept

[Cluster-devel] [PATCH] fs: gfs2: Adding new return type vm_fault_t

2018-07-02 Thread Souptick Joarder
Use new return type vm_fault_t for gfs2_page_mkwrite handler. see commit 1c8f422059ae ("mm: change return type to vm_fault_t") for reference. Signed-off-by: Souptick Joarder Reviewed-by: Matthew Wilcox --- fs/gfs2/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Cluster-devel] gfs2: iomap-write patches pushed to for-next

2018-07-02 Thread Andreas Gruenbacher
Hi, the following patches for gfs2 iomap write support have been pushed to the gfs2 for-next branch. The gfs2 for-next branch can be found here: https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/log/?h=for-next This (partially) depends on the iomap-4.19-merge branch in the

[Cluster-devel] [PATCH 2/3] iomap: support direct I/O to inline data

2018-07-02 Thread Christoph Hellwig
From: Andreas Gruenbacher Add support for reading from and writing to inline data to iomap_dio_rw. This saves filesystems from having to implement fallback code for this case. The inline data is actually cached in the inode, so the I/O is only direct in the sense that it doesn't go through the

[Cluster-devel] [PATCH 3/3] iomap: add inline data support to iomap_readpage_actor

2018-07-02 Thread Christoph Hellwig
From: Andreas Gruenbacher Just copy the inline data into the page using the existing helper. Signed-off-by: Andreas Gruenbacher Signed-off-by: Christoph Hellwig --- fs/iomap.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/fs/iomap.c b/fs/iomap.c index 98a1fdd5c091..13cdcf33e6c0

[Cluster-devel] more iomap inline enablement

2018-07-02 Thread Christoph Hellwig
Hi Darrick, below are a few more iomap patches to enable inline data for the iomap-4.19-merge branch.

[Cluster-devel] [PATCH 1/3] iomap: refactor iomap_dio_actor

2018-07-02 Thread Christoph Hellwig
Split the function up into two helpers for the bio based I/O and hole case, and a small helper to call the two. This separates the code a little better in preparation for supporting I/O to inline data. Signed-off-by: Christoph Hellwig Reviewed-by: Andreas Gruenbacher --- fs/iomap.c | 88

Re: [Cluster-devel] [PATCH] iomap: Add inline data support to iomap_readpage_actor

2018-07-02 Thread Andreas Gruenbacher
On 2 July 2018 at 14:52, Christoph Hellwig wrote: > On Sun, Jul 01, 2018 at 11:43:43PM +0200, Andreas Gruenbacher wrote: >> > + WARN_ON_ONCE(plen != PAGE_SIZE); >> >> Inline mappings only extend to the end of the file (iomap->offset == 0 >> && iomap->length == inode->i_size), so

Re: [Cluster-devel] [PATCH] iomap: Add inline data support to iomap_readpage_actor

2018-07-02 Thread Christoph Hellwig
On Sun, Jul 01, 2018 at 11:43:43PM +0200, Andreas Gruenbacher wrote: > > + WARN_ON_ONCE(plen != PAGE_SIZE); > > Inline mappings only extend to the end of the file (iomap->offset == 0 > && iomap->length == inode->i_size), so length and plen will be > inode->i_size here. This