Re: [Cluster-devel] [PATCH 1/2] gfs2: Fix occasional glock use-after-free

2019-04-09 Thread Andreas Gruenbacher
On Tue, 9 Apr 2019 at 17:37, Ross Lagerwall wrote: > On 4/5/19 6:50 PM, Andreas Gruenbacher wrote: > > Hi Ross, > > > > On Tue, 2 Apr 2019 at 00:59, Andreas Gruenbacher > > wrote: > >> thanks for the great analysis. > >> > >> On Tue, 26 Mar 2019 at 20:14, Bob Peterson wrote: > >>> - Origina

Re: [Cluster-devel] [PATCH 1/2] gfs2: Fix occasional glock use-after-free

2019-04-09 Thread Ross Lagerwall
On 4/5/19 6:50 PM, Andreas Gruenbacher wrote: Hi Ross, On Tue, 2 Apr 2019 at 00:59, Andreas Gruenbacher wrote: thanks for the great analysis. On Tue, 26 Mar 2019 at 20:14, Bob Peterson wrote: - Original Message - 6. gfs2_log_flush() continues and calls revoke_lo_after_commit() and

Re: [Cluster-devel] [PATCH 02/19] gfs2: Introduce concept of a pending withdraw

2019-04-09 Thread Andreas Gruenbacher
Hi Bob, On Wed, 27 Mar 2019 at 13:35, Bob Peterson wrote: > File system withdraws can be delayed when inconsistencies are > discovered when we cannot withdraw immediately, for example, when > critical spin_locks are held. But delaying the withdraw can cause > gfs2 to ignore the error and keep run

Re: [Cluster-devel] [PATCH 01/19] gfs2: log error reform

2019-04-09 Thread Andreas Gruenbacher
Bob, On Wed, 27 Mar 2019 at 13:36, Bob Peterson wrote: > Before this patch, gfs2 kept track of journal io errors in two > places (sd_log_error and the SDF_AIL1_IO_ERROR flag in sd_flags. > This patch consolidates the two by eliminating the SDF_AIL1_IO_ERROR > flag in favor of an atomic count of j

Re: [Cluster-devel] [PATCH] libgfs2: Import gfs2_ondisk.h

2019-04-09 Thread Andrew Price
On 09/04/2019 14:03, Steven Whitehouse wrote: On 09/04/2019 13:48, Andrew Price wrote: On 09/04/2019 13:21, Steven Whitehouse wrote: Those conversion functions are not sensible, thats why we got rid of them from the kernel code. Is it the functions that aren't sensible or the use of the gfs

Re: [Cluster-devel] [PATCH] libgfs2: Import gfs2_ondisk.h

2019-04-09 Thread Steven Whitehouse
Hi, On 09/04/2019 13:48, Andrew Price wrote: On 09/04/2019 13:21, Steven Whitehouse wrote: Hi, On 09/04/2019 13:18, Andrew Price wrote: On 09/04/2019 13:03, Christoph Hellwig wrote: On Tue, Apr 09, 2019 at 10:41:53AM +0100, Andrew Price wrote: Give gfs2-utils its own copy of gfs2_ondisk.h

Re: [Cluster-devel] [PATCH] libgfs2: Import gfs2_ondisk.h

2019-04-09 Thread Andrew Price
On 09/04/2019 13:21, Steven Whitehouse wrote: Hi, On 09/04/2019 13:18, Andrew Price wrote: On 09/04/2019 13:03, Christoph Hellwig wrote: On Tue, Apr 09, 2019 at 10:41:53AM +0100, Andrew Price wrote: Give gfs2-utils its own copy of gfs2_ondisk.h which uses userspace types. This allows us to

Re: [Cluster-devel] [PATCH] libgfs2: Import gfs2_ondisk.h

2019-04-09 Thread Christoph Hellwig
On Tue, Apr 09, 2019 at 01:21:23PM +0100, Steven Whitehouse wrote: > Those conversion functions are not sensible, thats why we got rid of them > from the kernel code. It is better to have a set of types that have the > endianess specified so that we can use sparse. Compile time checking is > always

Re: [Cluster-devel] gfs2 iomap dealock, IOMAP_F_UNBALANCED

2019-04-09 Thread Andreas Gruenbacher
On Tue, 9 Apr 2019 at 14:15, Christoph Hellwig wrote: > On Mon, Apr 08, 2019 at 03:44:05PM +0200, Jan Kara wrote: > > > We won't be able to do a log flush while another transaction is > > > active, but that's what's needed to clean dirty pages. iomap doesn't > > > allow us to put the block allocat

Re: [Cluster-devel] [PATCH] libgfs2: Import gfs2_ondisk.h

2019-04-09 Thread Steven Whitehouse
Hi, On 09/04/2019 13:18, Andrew Price wrote: On 09/04/2019 13:03, Christoph Hellwig wrote: On Tue, Apr 09, 2019 at 10:41:53AM +0100, Andrew Price wrote: Give gfs2-utils its own copy of gfs2_ondisk.h which uses userspace types. This allows us to always support the latest ondisk structures and

Re: [Cluster-devel] [PATCH] libgfs2: Import gfs2_ondisk.h

2019-04-09 Thread Andrew Price
On 09/04/2019 13:03, Christoph Hellwig wrote: On Tue, Apr 09, 2019 at 10:41:53AM +0100, Andrew Price wrote: Give gfs2-utils its own copy of gfs2_ondisk.h which uses userspace types. This allows us to always support the latest ondisk structures and obsoletes a lot of #ifdef GFS2_HAS_ blocks and c

Re: [Cluster-devel] gfs2 iomap dealock, IOMAP_F_UNBALANCED

2019-04-09 Thread Christoph Hellwig
On Mon, Apr 08, 2019 at 03:44:05PM +0200, Jan Kara wrote: > > We won't be able to do a log flush while another transaction is > > active, but that's what's needed to clean dirty pages. iomap doesn't > > allow us to put the block allocation into a separate transaction from > > the page writes; for t

Re: [Cluster-devel] [PATCH] libgfs2: Import gfs2_ondisk.h

2019-04-09 Thread Christoph Hellwig
On Tue, Apr 09, 2019 at 10:41:53AM +0100, Andrew Price wrote: > Give gfs2-utils its own copy of gfs2_ondisk.h which uses userspace > types. This allows us to always support the latest ondisk structures and > obsoletes a lot of #ifdef GFS2_HAS_ blocks and configure.ac > checks. > > gfs2_ondisk.h wa

[Cluster-devel] [PATCH] libgfs2: Import gfs2_ondisk.h

2019-04-09 Thread Andrew Price
Give gfs2-utils its own copy of gfs2_ondisk.h which uses userspace types. This allows us to always support the latest ondisk structures and obsoletes a lot of #ifdef GFS2_HAS_ blocks and configure.ac checks. gfs2_ondisk.h was changed simply by search-and-replace of the kernel int types with the ui