Re: [Cluster-devel] [GFS2 PATCH 11/12] gfs2: Fix iomap write page reclaim deadlock

2019-06-11 Thread Ross Lagerwall
On 6/8/19 1:16 PM, Andreas Gruenbacher wrote: Hi Ross, On Fri, 7 Jun 2019 at 18:21, Ross Lagerwall wrote: On 5/7/19 9:32 PM, Andreas Gruenbacher wrote: Since commit 64bc06bb32ee ("gfs2: iomap buffered write support"), gfs2 is doing buffered writes by starting a transaction in iomap_begin, wri

[Cluster-devel] [PATCH] dlm_controld: trigger network interface failover if a communications error is detected

2019-06-11 Thread David Windsor
Support for automatic failover in the face of network interruptions is being added to the DLM kernel component [1]. This patch aids in that effort by adding a mechanism whereby userspace can request the DLM kernel component switch to the next usable network interface. When --failover is set, dlm_

Re: [Cluster-devel] [Jfs-discussion] [PATCH 1/4] vfs: create a generic checking function for FS_IOC_SETFLAGS

2019-06-11 Thread Dave Kleikamp
On 6/10/19 11:45 PM, Darrick J. Wong wrote: > From: Darrick J. Wong > > Create a generic checking function for the incoming FS_IOC_SETFLAGS flag > values so that we can standardize the implementations that follow ext4's > flag values. > > Signed-off-by: Darrick J. Wong -- clip -- > diff --gi

Re: [PATCH] fs: gfs2: Use IS_ERR_OR_NULL

2019-06-11 Thread Andreas Gruenbacher
Kefeng, On Wed, 5 Jun 2019 at 16:17, Kefeng Wang wrote: > Use IS_ERR_OR_NULL where appropriate. It seems there are several more instances in which IS_ERR_OR_NULL should be used (see below). Thanks, Andreas --- fs/gfs2/dir.c| 2 +- fs/gfs2/glock.c | 2 +- fs/gfs2/inode.c | 2

Re: [Jfs-discussion] [PATCH 1/4] vfs: create a generic checking function for FS_IOC_SETFLAGS

2019-06-11 Thread Darrick J. Wong
On Tue, Jun 11, 2019 at 08:41:06AM -0500, Dave Kleikamp wrote: > On 6/10/19 11:45 PM, Darrick J. Wong wrote: > > From: Darrick J. Wong > > > > Create a generic checking function for the incoming FS_IOC_SETFLAGS flag > > values so that we can standardize the implementations that follow ext4's > >

[PATCH v2 1/4] vfs: create a generic checking function for FS_IOC_SETFLAGS

2019-06-11 Thread Darrick J. Wong
From: Darrick J. Wong Create a generic checking function for the incoming FS_IOC_SETFLAGS flag values so that we can standardize the implementations that follow ext4's flag values. Signed-off-by: Darrick J. Wong --- v2: fix jfs locking and remove its opencoded flags check --- fs/btrfs/ioctl.c

Re: [PATCH] fs: gfs2: Use IS_ERR_OR_NULL

2019-06-11 Thread Kefeng Wang
On 2019/6/12 0:23, Andreas Gruenbacher wrote: > Kefeng, > > On Wed, 5 Jun 2019 at 16:17, Kefeng Wang wrote: >> Use IS_ERR_OR_NULL where appropriate. > > It seems there are several more instances in which IS_ERR_OR_NULL should > be used (see below). > Right, will collect the following change

[PATCH v2] fs: gfs2: Use IS_ERR_OR_NULL

2019-06-11 Thread Kefeng Wang
Use IS_ERR_OR_NULL where appropriate. Signed-off-by: Kefeng Wang Signed-off-by: Andreas Gruenbacher --- fs/gfs2/dir.c| 4 ++-- fs/gfs2/glock.c | 2 +- fs/gfs2/inode.c | 2 +- fs/gfs2/ops_fstype.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/fs/gfs2/di