Re: [Cluster-devel] [GFS2 PATCH v2] gfs2: fix gfs2_find_jhead that returns uninitialized jhead with seq 0

2020-02-04 Thread Andreas Gruenbacher
Hi Abhi, On Tue, Feb 4, 2020 at 9:15 PM Abhi Das wrote: > When the first log header in a journal happens to have a sequence > number of 0, a bug in gfs2_find_jhead() causes it to prematurely exit, > and return an uninitialized jhead with seq 0. This can cause failures > in the caller. For instanc

[Cluster-devel] [GFS2 PATCH v2] gfs2: fix gfs2_find_jhead that returns uninitialized jhead with seq 0

2020-02-04 Thread Abhi Das
Hi, This version changes the description as per discussion with Andreas. Cheers! --Abhi When the first log header in a journal happens to have a sequence number of 0, a bug in gfs2_find_jhead() causes it to prematurely exit, and return an uninitialized jhead with seq 0. This can cause failures i

[Cluster-devel] [GFS2 PATCH] gfs2: fix gfs2_find_jhead that returns jhead with seq 0

2020-02-04 Thread Abhi Das
When the first log header in a journal happens to have a sequence number of 0, a bug in gfs2_find_jhead() returns this to be the jhead, instead of seeking forward and looking further into the journal for a jhead with a higher sequence number. Signed-off-by: Abhi Das --- fs/gfs2/lops.c | 2 +- 1

Re: [Cluster-devel] [PATCH v4 00/12] Change readahead API

2020-02-04 Thread Matthew Wilcox
On Tue, Feb 04, 2020 at 04:32:27PM +0100, David Sterba wrote: > On Sat, Feb 01, 2020 at 07:12:28AM -0800, Matthew Wilcox wrote: > > From: "Matthew Wilcox (Oracle)" > > > > I would particularly value feedback on this from the gfs2 and ocfs2 > > maintainers. They have non-trivial changes, and a re

Re: [Cluster-devel] [PATCH v4 00/12] Change readahead API

2020-02-04 Thread David Sterba
On Sat, Feb 01, 2020 at 07:12:28AM -0800, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > > I would particularly value feedback on this from the gfs2 and ocfs2 > maintainers. They have non-trivial changes, and a review on patch 5 > would be greatly appreciated. > > This series adds a