Re: [Cluster-devel] [PATCH 2/2] iomap: fall back to buffered writes for invalidation failures

2020-07-13 Thread Darrick J. Wong
On Mon, Jul 13, 2020 at 09:46:33AM +0200, Christoph Hellwig wrote: > Failing to invalid the page cache means data in incoherent, which is > a very bad state for the system. Always fall back to buffered I/O > through the page cache if we can't invalidate mappings. > > Signed-off-by: Christoph

Re: [Cluster-devel] [PATCH 2/2] iomap: fall back to buffered writes for invalidation failures

2020-07-13 Thread David Sterba
On Mon, Jul 13, 2020 at 07:20:50AM -0500, Goldwyn Rodrigues wrote: > On 9:46 13/07, Christoph Hellwig wrote: > > Failing to invalid the page cache means data in incoherent, which is > > a very bad state for the system. Always fall back to buffered I/O > > through the page cache if we can't

Re: [Cluster-devel] [PATCH 2/2] iomap: fall back to buffered writes for invalidation failures

2020-07-13 Thread Goldwyn Rodrigues
On 9:46 13/07, Christoph Hellwig wrote: > Failing to invalid the page cache means data in incoherent, which is > a very bad state for the system. Always fall back to buffered I/O > through the page cache if we can't invalidate mappings. > > Signed-off-by: Christoph Hellwig Thanks. This will

Re: [Cluster-devel] [PATCH 2/2] iomap: fall back to buffered writes for invalidation failures

2020-07-13 Thread Matthew Wilcox
On Mon, Jul 13, 2020 at 09:46:33AM +0200, Christoph Hellwig wrote: > Failing to invalid the page cache means data in incoherent, which is > a very bad state for the system. Always fall back to buffered I/O > through the page cache if we can't invalidate mappings. Is that the right approach

[Cluster-devel] RFC: iomap write invalidation

2020-07-13 Thread Christoph Hellwig
Hi all, this series has two parts: the first one picks up Dave's patch to avoid invalidation entierly for reads, picked up deep down from the btrfs iomap thread. The second one falls back to buffered writes if invalidation fails instead of leaving a stale cache around. Let me know what you

[Cluster-devel] [PATCH 1/2] iomap: Only invalidate page cache pages on direct IO writes

2020-07-13 Thread Christoph Hellwig
From: Dave Chinner The historic requirement for XFS to invalidate cached pages on direct IO reads has been lost in the twisty pages of history - it was inherited from Irix, which implemented page cache invalidation on read as a method of working around problems synchronising page cache state

[Cluster-devel] [PATCH 2/2] iomap: fall back to buffered writes for invalidation failures

2020-07-13 Thread Christoph Hellwig
Failing to invalid the page cache means data in incoherent, which is a very bad state for the system. Always fall back to buffered I/O through the page cache if we can't invalidate mappings. Signed-off-by: Christoph Hellwig --- fs/ext4/file.c | 2 ++ fs/gfs2/file.c | 3 ++-