On Mon, Apr 19, 2021 at 10:47 PM Andrew Price wrote:
> On 19/04/2021 20:35, Andreas Gruenbacher wrote:
> > Andy,
> >
> > On Mon, Apr 19, 2021 at 9:11 PM Andrew Price wrote:
> >> diff --git a/gfs2/include/gfs2_ondisk.h b/gfs2/include/gfs2_ondisk.h
> >> new file mode 100644
> >> index ..fc9
On 19/04/2021 20:35, Andreas Gruenbacher wrote:
Andy,
On Mon, Apr 19, 2021 at 9:11 PM Andrew Price wrote:
diff --git a/gfs2/include/gfs2_ondisk.h b/gfs2/include/gfs2_ondisk.h
new file mode 100644
index ..fc948f89
--- /dev/null
+++ b/gfs2/include/gfs2_ondisk.h
any reason why this file
Andy,
On Mon, Apr 19, 2021 at 9:11 PM Andrew Price wrote:
> diff --git a/gfs2/include/gfs2_ondisk.h b/gfs2/include/gfs2_ondisk.h
> new file mode 100644
> index ..fc948f89
> --- /dev/null
> +++ b/gfs2/include/gfs2_ondisk.h
any reason why this file shouldn't be at gfs2/include/linux/gfs2_o
Hi Andy,
On Mon, Apr 19, 2021 at 9:11 PM Andrew Price wrote:
> v1: https://listman.redhat.com/archives/cluster-devel/2019-April/msg00021.html
>
> My previous attempt at this did a search+replace to satisfy the field types
> in gfs2_ondisk.h, which was a little OTT. This attempt adds a linux/type
Now that we have gfs2 structs defined in terms of standard userspace
types instead of kernel types we can use these defines from inttypes.h
to print their fields in a consistent way across architectures.
Fixes a number of -Wformat warnings on x86_64.
Signed-off-by: Andrew Price
---
gfs2/edit/ex
Our own gfs2_ondisk.h has de_rahead and de_cookie so there's no need for
these conditionals.
Signed-off-by: Andrew Price
---
configure.ac | 4
gfs2/edit/extended.c | 8 ++--
gfs2/libgfs2/meta.c | 8
gfs2/libgfs2/ondisk.c | 16
4 files changed, 2
Our own gfs2_ondisk.h has v2 log headers so there's no need for these
conditionals. There aren't any users of gfs2_log_header_v1_*() functions
so fold those into gfs2_log_header*().
Signed-off-by: Andrew Price
---
configure.ac | 2 --
gfs2/libgfs2/libgfs2.h| 3 ---
gfs2/libgfs
Our own gfs2_ondisk.h has the new rgrp fields so there's no need for
these conditionals.
Signed-off-by: Andrew Price
---
configure.ac | 2 --
gfs2/libgfs2/meta.c | 2 --
gfs2/libgfs2/ondisk.c | 8
gfs2/libgfs2/rgrp.c | 6 --
4 files changed, 18 deletions(-)
diff --git
Give gfs2-utils its own copy of gfs2_ondisk.h. This allows us to always
support the latest ondisk structures and obsoletes a lot of #ifdef
GFS2_HAS_ blocks and configure.ac checks.
Provide the kernel int typedefs that gfs2_ondisk.h uses with our own
linux/types.h, which uses standard userspace typ
Our own gfs2_ondisk.h has leaf hints so there's no need for these
conditionals.
Signed-off-by: Andrew Price
---
configure.ac | 2 --
gfs2/edit/extended.c | 9 ++---
gfs2/libgfs2/fs_ops.c | 6 --
gfs2/libgfs2/ondisk.c | 10 --
4 files changed, 2 insertions(+), 25 dele
Our own gfs2_ondisk.h has rg_skip so there's no need for these
conditionals.
Signed-off-by: Andrew Price
---
configure.ac | 2 --
gfs2/libgfs2/meta.c | 4
gfs2/libgfs2/ondisk.c | 12
gfs2/libgfs2/rgrp.c | 2 --
4 files changed, 20 deletions(-)
diff --git a/conf
Now that we own our own gfs2_ondisk.h we know that it has sb_uuid so we
can use it unconditionally (and require libuuid unconditionally).
Signed-off-by: Andrew Price
---
configure.ac | 11 +--
gfs2/edit/gfs2hex.c | 12 +++-
gfs2/libgfs2/lang.c | 11 +-
v1: https://listman.redhat.com/archives/cluster-devel/2019-April/msg00021.html
My previous attempt at this did a search+replace to satisfy the field types in
gfs2_ondisk.h, which was a little OTT. This attempt adds a linux/types.h that
gfs2_ondisk.h will pick up instead of the kernel one.
Havin
On 2021-03-30 17:44:27, Lee Jones wrote:
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
>
> There is more to do in filesystems. Another set will follow.
>
> Lee Jones (31):
...
> fs: ec
On Mon, 19 Apr 2021, Tyler Hicks wrote:
> On 2021-03-30 17:44:27, Lee Jones wrote:
> > This set is part of a larger effort attempting to clean-up W=1
> > kernel builds, which are currently overwhelmingly riddled with
> > niggly little warnings.
> >
> > There is more to do in filesystems. Another
15 matches
Mail list logo
