Re: [Cluster-devel] [PATCH -v4] ext4: don't BUG if kernel subsystems dirty pages without asking ext4 first

2022-03-02 Thread Theodore Ts'o
[un]pin_user_pages_remote is dirtying pages without properly warning the file system in advance. A related race was noted by Jan Kara in 2018[1]; however, more recently instead of it being a very hard-to-hit race, it could be reliably triggered by process_vm_writev(2) which was discovered by Syzbo

Re: [Cluster-devel] [PATCH] iomap: fix incomplete async dio reads when using IOMAP_DIO_PARTIAL

2022-03-02 Thread Dave Chinner
On Wed, Mar 02, 2022 at 02:03:28PM +0100, Andreas Gruenbacher wrote: > On Wed, Mar 2, 2022 at 11:17 AM Filipe Manana wrote: > > On Tue, Mar 01, 2022 at 09:38:30AM +1100, Dave Chinner wrote: > > > On Mon, Feb 28, 2022 at 02:32:03PM +, fdman...@kernel.org wrote: > > > > From: Filipe Manana > >

Re: [Cluster-devel] [PATCH] iomap: fix incomplete async dio reads when using IOMAP_DIO_PARTIAL

2022-03-02 Thread Andreas Gruenbacher
On Wed, Mar 2, 2022 at 11:17 AM Filipe Manana wrote: > On Tue, Mar 01, 2022 at 09:38:30AM +1100, Dave Chinner wrote: > > On Mon, Feb 28, 2022 at 02:32:03PM +, fdman...@kernel.org wrote: > > > From: Filipe Manana > > > > > > Some users recently reported that MariaDB was getting a read corrupti

Re: [Cluster-devel] [PATCH] iomap: fix incomplete async dio reads when using IOMAP_DIO_PARTIAL

2022-03-02 Thread Filipe Manana
On Tue, Mar 01, 2022 at 08:42:03AM -0800, Darrick J. Wong wrote: > On Mon, Feb 28, 2022 at 02:32:03PM +, fdman...@kernel.org wrote: > > From: Filipe Manana > > > > Some users recently reported that MariaDB was getting a read corruption > > when using io_uring on top of btrfs. This started to

Re: [Cluster-devel] [PATCH] iomap: fix incomplete async dio reads when using IOMAP_DIO_PARTIAL

2022-03-02 Thread Filipe Manana
On Tue, Mar 01, 2022 at 09:38:30AM +1100, Dave Chinner wrote: > On Mon, Feb 28, 2022 at 02:32:03PM +, fdman...@kernel.org wrote: > > From: Filipe Manana > > > > Some users recently reported that MariaDB was getting a read corruption > > when using io_uring on top of btrfs. This started to hap

[Cluster-devel] [PATCH] iomap: fix incomplete async dio reads when using IOMAP_DIO_PARTIAL

2022-03-02 Thread fdmanana
From: Filipe Manana Some users recently reported that MariaDB was getting a read corruption when using io_uring on top of btrfs. This started to happen in 5.16, after commit 51bd9563b6783d ("btrfs: fix deadlock due to page faults during direct IO reads and writes"). That changed btrfs to use the