Re: [Cluster-devel] [PATCH v2 12/19] btrfs: Convert btrfs_migratepage to migrate_folio

2022-06-09 Thread David Sterba
On Thu, Jun 09, 2022 at 06:40:28PM +0100, Matthew Wilcox wrote: > On Thu, Jun 09, 2022 at 06:33:23PM +0200, David Sterba wrote: > > On Wed, Jun 08, 2022 at 04:02:42PM +0100, Matthew Wilcox (Oracle) wrote: > > > Use filemap_migrate_folio() to do the bulk of the work, and then copy > > > the ordered

Re: [Cluster-devel] [PATCH v2 12/19] btrfs: Convert btrfs_migratepage to migrate_folio

2022-06-09 Thread Matthew Wilcox
On Thu, Jun 09, 2022 at 06:33:23PM +0200, David Sterba wrote: > On Wed, Jun 08, 2022 at 04:02:42PM +0100, Matthew Wilcox (Oracle) wrote: > > Use filemap_migrate_folio() to do the bulk of the work, and then copy > > the ordered flag across if needed. > > > > Signed-off-by: Matthew Wilcox (Oracle)

Re: [Cluster-devel] [PATCH v2 10/19] mm/migrate: Convert migrate_page() to migrate_folio()

2022-06-09 Thread David Sterba
On Wed, Jun 08, 2022 at 04:02:40PM +0100, Matthew Wilcox (Oracle) wrote: > Convert all callers to pass a folio. Most have the folio > already available. Switch all users from aops->migratepage to > aops->migrate_folio. Also turn the documentation into kerneldoc. > > Signed-off-by: Matthew

Re: [Cluster-devel] [PATCH v2 08/19] btrfs: Convert btree_migratepage to migrate_folio

2022-06-09 Thread David Sterba
On Wed, Jun 08, 2022 at 04:02:38PM +0100, Matthew Wilcox (Oracle) wrote: > Use a folio throughout this function. migrate_page() will be converted > later. > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Christoph Hellwig Acked-by: David Sterba

Re: [Cluster-devel] [PATCH v2 12/19] btrfs: Convert btrfs_migratepage to migrate_folio

2022-06-09 Thread David Sterba
On Wed, Jun 08, 2022 at 04:02:42PM +0100, Matthew Wilcox (Oracle) wrote: > Use filemap_migrate_folio() to do the bulk of the work, and then copy > the ordered flag across if needed. > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Christoph Hellwig Acked-by: David Sterba > +static

Re: [Cluster-devel] [PATCH v2 03/19] fs: Add aops->migrate_folio

2022-06-09 Thread Matthew Wilcox
On Thu, Jun 09, 2022 at 02:50:20PM +0200, David Hildenbrand wrote: > On 08.06.22 17:02, Matthew Wilcox (Oracle) wrote: > > diff --git a/Documentation/filesystems/locking.rst > > b/Documentation/filesystems/locking.rst > > index c0fe711f14d3..3d28b23676bd 100644 > > ---

Re: [Cluster-devel] [PATCH v2 03/19] fs: Add aops->migrate_folio

2022-06-09 Thread David Hildenbrand
On 08.06.22 17:02, Matthew Wilcox (Oracle) wrote: > Provide a folio-based replacement for aops->migratepage. Update the > documentation to document migrate_folio instead of migratepage. > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Christoph Hellwig > --- >

Re: [Cluster-devel] [PATCH v2 01/19] secretmem: Remove isolate_page

2022-06-09 Thread David Hildenbrand
On 08.06.22 17:02, Matthew Wilcox (Oracle) wrote: > The isolate_page operation is never called for filesystems, only > for device drivers which call SetPageMovable. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > mm/secretmem.c | 6 -- > 1 file changed, 6 deletions(-) > > diff --git

Re: [Cluster-devel] [PATCH v2 02/19] mm: Convert all PageMovable users to movable_operations

2022-06-09 Thread David Hildenbrand
On 08.06.22 17:02, Matthew Wilcox (Oracle) wrote: > These drivers are rather uncomfortably hammered into the > address_space_operations hole. They aren't filesystems and don't behave > like filesystems. They just need their own movable_operations structure, > which we can point to directly from

Re: [Cluster-devel] [PATCH v2 16/19] hugetlb: Convert to migrate_folio

2022-06-09 Thread Muchun Song
On Wed, Jun 08, 2022 at 04:02:46PM +0100, Matthew Wilcox (Oracle) wrote: > This involves converting migrate_huge_page_move_mapping(). We also need a > folio variant of hugetlb_set_page_subpool(), but that's for a later patch. > > Signed-off-by: Matthew Wilcox (Oracle) Acked-by: Muchun Song