Re: [Cluster-devel] [PATCH v3 04/23] page-writeback: Convert write_cache_pages() to use filemap_get_folios_tag()

2022-10-24 Thread Matthew Wilcox
On Mon, Oct 17, 2022 at 01:24:32PM -0700, Vishal Moola (Oracle) wrote: > Converted function to use folios throughout. This is in preparation for > the removal of find_get_pages_range_tag(). And removes eight calls to compound_head(), saving 296 bytes of kernel text (!) It also adds support for la

Re: [Cluster-devel] [PATCH v3 03/23] filemap: Convert __filemap_fdatawait_range() to use filemap_get_folios_tag()

2022-10-24 Thread Matthew Wilcox
On Mon, Oct 17, 2022 at 01:24:31PM -0700, Vishal Moola (Oracle) wrote: > Converted function to use folios. This is in preparation for the removal > of find_get_pages_range_tag(). Yes, it is, but this patch also has some nice advantages of its own: - Removes a call to wait_on_page_writeback(), wh

Re: [Cluster-devel] [PATCH v3 01/23] pagemap: Add filemap_grab_folio()

2022-10-24 Thread Matthew Wilcox
On Mon, Oct 17, 2022 at 01:24:29PM -0700, Vishal Moola (Oracle) wrote: > Add function filemap_grab_folio() to grab a folio from the page cache. > This function is meant to serve as a folio replacement for > grab_cache_page, and is used to facilitate the removal of > find_get_pages_range_tag(). I'm

Re: [Cluster-devel] [PATCH v3 02/23] filemap: Added filemap_get_folios_tag()

2022-10-24 Thread Matthew Wilcox
On Mon, Oct 17, 2022 at 01:24:30PM -0700, Vishal Moola (Oracle) wrote: > This is the equivalent of find_get_pages_range_tag(), except for folios > instead of pages. > > One noteable difference is filemap_get_folios_tag() does not take in a > maximum pages argument. It instead tries to fill a folio

Re: [Cluster-devel] [PATCH v3 01/23] pagemap: Add filemap_grab_folio()

2022-10-24 Thread Vishal Moola
On Mon, Oct 17, 2022 at 1:24 PM Vishal Moola (Oracle) wrote: > > Add function filemap_grab_folio() to grab a folio from the page cache. > This function is meant to serve as a folio replacement for > grab_cache_page, and is used to facilitate the removal of > find_get_pages_range_tag(). > > Signed-

Re: [Cluster-devel] [PATCH v3 11/23] f2fs: Convert f2fs_fsync_node_pages() to use filemap_get_folios_tag()

2022-10-24 Thread Vishal Moola
On Mon, Oct 17, 2022 at 1:25 PM Vishal Moola (Oracle) wrote: > > Convert function to use a folio_batch instead of pagevec. This is in > preparation for the removal of find_get_pages_range_tag(). > > Signed-off-by: Vishal Moola (Oracle) > --- > fs/f2fs/node.c | 19 ++- > 1 file ch

Re: [Cluster-devel] [PATCH v3 10/23] ext4: Convert mpage_prepare_extent_to_map() to use filemap_get_folios_tag()

2022-10-24 Thread Vishal Moola
On Mon, Oct 17, 2022 at 1:25 PM Vishal Moola (Oracle) wrote: > > Converted the function to use folios throughout. This is in preparation > for the removal of find_get_pages_range_tag(). Now supports large > folios. > > Signed-off-by: Vishal Moola (Oracle) > --- > fs/ext4/inode.c | 55 +++

Re: [Cluster-devel] [PATCH v3 17/23] gfs2: Convert gfs2_write_cache_jdata() to use filemap_get_folios_tag()

2022-10-24 Thread Vishal Moola
On Mon, Oct 17, 2022 at 1:25 PM Vishal Moola (Oracle) wrote: > > Converted function to use folios throughout. This is in preparation for > the removal of find_get_pgaes_range_tag(). > > Also had to modify and rename gfs2_write_jdata_pagevec() to take in > and utilize folio_batch rather than pageve

Re: [Cluster-devel] [syzbot] WARNING in gfs2_ri_update

2022-10-24 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:440b7895c990 Merge tag 'mm-hotfixes-stable-2022-10-20' of .. git tree: upstream console+strace: https://syzkaller.appspot.com/x/log.txt?x=128087a488 kernel config: https://syzkaller.appspot.com/x/.config?x=afc317c

Re: [Cluster-devel] [syzbot] general protection fault in gfs2_parse_param

2022-10-24 Thread Tetsuo Handa
Please wait for response on https://lkml.kernel.org/r/ce198a72-92c9-e09a-ca92-2860326c2...@i-love.sakura.ne.jp . On 2022/10/23 16:29, syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit:4d48f589d294 Add linux-next specific files for 20221021 > git tree: li

[Cluster-devel] [PATCH -next 4/5] gfs2: fix possible null-ptr-deref when parsing param

2022-10-24 Thread Hawkins Jiawei
According to commit "vfs: parse: deal with zero length string value", kernel will set the param->string to null pointer in vfs_parse_fs_string() if fs string has zero length. Yet the problem is that, gfs2_parse_param() will dereferences the param->string, without checking whether it is a null poin

[Cluster-devel] [syzbot] general protection fault in gfs2_parse_param

2022-10-24 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:4d48f589d294 Add linux-next specific files for 20221021 git tree: linux-next console+strace: https://syzkaller.appspot.com/x/log.txt?x=15e511ba88 kernel config: https://syzkaller.appspot.com/x/.config?x=2c4b7d600a5739a6 dashbo

Re: [Cluster-devel] [PATCH -next 4/5] gfs2: fix possible null-ptr-deref when parsing param

2022-10-24 Thread Andreas Grünbacher
Am So., 23. Okt. 2022 um 18:46 Uhr schrieb Hawkins Jiawei : > According to commit "vfs: parse: deal with zero length string value", > kernel will set the param->string to null pointer in vfs_parse_fs_string() > if fs string has zero length. > > Yet the problem is that, gfs2_parse_param() will deref