Re: [Cluster-devel] return an ERR_PTR from __filemap_get_folio v2

2023-03-28 Thread Andrew Morton
On Sat, 21 Jan 2023 07:57:48 +0100 Christoph Hellwig wrote: > __filemap_get_folio and its wrappers can return NULL for three different > conditions, which in some cases requires the caller to reverse engineer > the decision making. This is fixed by returning an ERR_PTR instead of > NULL and thus

Re: [Cluster-devel] return an ERR_PTR from __filemap_get_folio v2

2023-01-23 Thread Andrew Morton
On Sun, 22 Jan 2023 08:20:06 +0100 Christoph Hellwig wrote: > On Sat, Jan 21, 2023 at 05:06:41PM -0800, Andrew Morton wrote: > > This patchset doesn't apply to fs/btrfs/ because linux-next contains > > this 6+ month-old commit: > > Hmm. It was literally written aga

Re: [Cluster-devel] return an ERR_PTR from __filemap_get_folio v2

2023-01-21 Thread Andrew Morton
On Sat, 21 Jan 2023 07:57:48 +0100 Christoph Hellwig wrote: > Hi all, > > __filemap_get_folio and its wrappers can return NULL for three different > conditions, which in some cases requires the caller to reverse engineer > the decision making. This is fixed by returning an ERR_PTR instead of >

Re: [Cluster-devel] [syzbot] WARNING in __set_page_dirty

2021-07-21 Thread Andrew Morton
(cc gfs2 maintainers) On Tue, 20 Jul 2021 19:07:25 -0700 syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit:d936eb238744 Revert "Makefile: Enable -Wimplicit-fallthrou.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=1512

Re: [Cluster-devel] [Ocfs2-devel] [PATCH 1/3] fs/buffer.c: add new api to allow eof writeback

2021-05-09 Thread Andrew Morton
On Mon, 26 Apr 2021 15:05:50 -0700 Junxiao Bi wrote: > When doing truncate/fallocate for some filesytem like ocfs2, it > will zero some pages that are out of inode size and then later > update the inode size, so it needs this api to writeback eof > pages. Seems reasonable. But can we please upd

Re: [Cluster-devel] [PATCH v11 19/25] erofs: Convert compressed files from readpages to readahead

2020-04-20 Thread Andrew Morton
On Tue, 14 Apr 2020 08:02:27 -0700 Matthew Wilcox wrote: > > Use the new readahead operation in erofs. > Well this is exciting. fs/erofs/data.c: In function erofs_raw_access_readahead: fs/erofs/data.c:149:18: warning: last_block may be used uninitialized in this function [-Wmaybe-uninitializ

Re: [Cluster-devel] [PATCH v11 05/25] mm: Add new readahead_control API

2020-04-14 Thread Andrew Morton
On Tue, 14 Apr 2020 19:18:08 -0700 Matthew Wilcox wrote: > On Tue, Apr 14, 2020 at 06:17:05PM -0700, Andrew Morton wrote: > > On Tue, 14 Apr 2020 08:02:13 -0700 Matthew Wilcox > > wrote: > > > From: "Matthew Wilcox (Oracle)" > > > > > >

Re: [Cluster-devel] [PATCH v11 05/25] mm: Add new readahead_control API

2020-04-14 Thread Andrew Morton
On Tue, 14 Apr 2020 08:02:13 -0700 Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > > Filesystems which implement the upcoming ->readahead method will get > their pages by calling readahead_page() or readahead_page_batch(). > These functions support large pages, even though none of the

Re: [Cluster-devel] [PATCH 00/12] Change readahead API

2020-02-12 Thread Andrew Morton
On Fri, 24 Jan 2020 17:35:41 -0800 Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > > This series adds a readahead address_space operation to eventually > replace the readpages operation. The key difference is that > pages are added to the page cache as they are allocated (and > then

Re: [Cluster-devel] [PATCH 01/12] mm: fix a comment in sys_swapon

2020-02-10 Thread Andrew Morton
On Tue, 14 Jan 2020 17:12:14 +0100 Christoph Hellwig wrote: > claim_swapfile now always takes i_rwsem. > > ... > > --- a/mm/swapfile.c > +++ b/mm/swapfile.c > @@ -3157,7 +3157,7 @@ SYSCALL_DEFINE2(swapon, const char __user *, > specialfile, int, swap_flags) > mapping = swap_file->f_mappin

Re: [Cluster-devel] [PATCH 4/7] mm: introduce memalloc_nofs_{save, restore} API

2017-03-06 Thread Andrew Morton
On Mon, 6 Mar 2017 14:14:05 +0100 Michal Hocko wrote: > From: Michal Hocko > > GFP_NOFS context is used for the following 5 reasons currently > - to prevent from deadlocks when the lock held by the allocation > context would be needed during the memory reclaim > - to preven

Re: [Cluster-devel] [PATCH] mm: Avoid returning VM_FAULT_RETRY from ->page_mkwrite handlers

2017-02-03 Thread Andrew Morton
On Fri, 3 Feb 2017 16:07:29 +0100 Jan Kara wrote: > Some ->page_mkwrite handlers may return VM_FAULT_RETRY as its return > code (GFS2 or Lustre can definitely do this). However VM_FAULT_RETRY > from ->page_mkwrite is completely unhandled by the mm code and results > in locking and writeably mapp

Re: [Cluster-devel] simplify configfs attributes V2

2015-10-05 Thread Andrew Morton
On Sat, 3 Oct 2015 15:32:36 +0200 Christoph Hellwig wrote: > This series consolidates the code to implement configfs attributes > by providing the ->show and ->store method in common code and using > container_of in the methods to access the containing structure. > > This reduces source and bin

Re: [Cluster-devel] [PATCH 4/4] fs: remove obsolete simple_strto

2013-01-17 Thread Andrew Morton
On Fri, 7 Dec 2012 17:25:19 +0530 Abhijit Pawar wrote: > This patch replace the obsolete simple_strto with kstrto > The XFS part (or something like it) has been applied. > > ... > > --- a/fs/9p/v9fs.c > +++ b/fs/9p/v9fs.c > @@ -112,7 +112,7 @@ static int v9fs_parse_options(struct v9fs_session

Re: [Cluster-devel] GFS2: Use kmalloc when possible for ->readdir() (try #2)

2010-07-28 Thread Andrew Morton
On Wed, 28 Jul 2010 17:56:23 +0100 Steven Whitehouse wrote: > +static void *gfs2_alloc_sort_buffer(unsigned size) > +{ > + void *ptr = NULL; > + > + if (size < KMALLOC_MAX_SIZE) > + ptr = kmalloc(size, GFP_NOFS | __GFP_NOWARN); > + if (!ptr) > + ptr = __vmallo

[Cluster-devel] Re: [PATCH] misc: use a proper range for minor number dynamic allocation

2009-11-09 Thread Andrew Morton
On Mon, 9 Nov 2009 21:29:25 -0200 Thadeu Lima de Souza Cascardo wrote: > On Mon, Nov 09, 2009 at 08:02:57PM -0200, Thadeu Lima de Souza Cascardo wrote: > > > > > > Is that a bugfix for the existing code? > > > > > > If so, please split that out into a separate patch which we can review > > > an

[Cluster-devel] Re: [PATCH] misc: use a proper range for minor number dynamic allocation

2009-11-09 Thread Andrew Morton
On Fri, 23 Oct 2009 21:28:17 -0200 Thadeu Lima de Souza Cascardo wrote: > The current dynamic allocation of minor number for misc devices has some > drawbacks. > > First of all, the range for dynamic numbers include some statically > allocated numbers. It goes from 63 to 0, and we have numbers i

[Cluster-devel] Re: mmotm 2009-01-14-20-31 uploaded (gfs2)

2009-01-16 Thread Andrew Morton
On Fri, 16 Jan 2009 09:06:23 -0800 Randy Dunlap wrote: > >>> which is not ideal, but I don't see any easy way to avoid the #ifdef, > >>> > >> Take a look in fs.h: > >> > >> #define generic_setlease(a, b, c) ({ -EINVAL; }) > >> > >> If that wasn't a stupid macro, your code would have compiled and

[Cluster-devel] Re: mmotm 2009-01-14-20-31 uploaded (gfs2)

2009-01-16 Thread Andrew Morton
On Fri, 16 Jan 2009 10:20:03 + Steven Whitehouse wrote: > Hi, > > On Thu, 2009-01-15 at 11:13 -0800, Randy Dunlap wrote: > > a...@linux-foundation.org wrote: > > > The mm-of-the-moment snapshot 2009-01-14-20-31 has been uploaded to > > > > > >http://userweb.kernel.org/~akpm/mmotm/ > >

[Cluster-devel] Re: [PATCH 01/24] GFS2: Support for FIEMAP ioctl

2008-12-18 Thread Andrew Morton
On Thu, 18 Dec 2008 10:29:04 + Steven Whitehouse wrote: > Hi, > > On Wed, 2008-12-17 at 17:22 -0800, Andrew Morton wrote: > > On Wed, 17 Dec 2008 11:30:00 + > > swhit...@redhat.com wrote: > > > > > +static int gfs2_fiemap(struct inode *inode, struc

[Cluster-devel] Re: [PATCH 01/24] GFS2: Support for FIEMAP ioctl

2008-12-17 Thread Andrew Morton
On Wed, 17 Dec 2008 11:30:00 + swhit...@redhat.com wrote: > +static int gfs2_fiemap(struct inode *inode, struct fiemap_extent_info > *fieinfo, > +u64 start, u64 len) > +{ > + struct gfs2_inode *ip = GFS2_I(inode); > + struct gfs2_holder gh; > + int ret; > + > +

[Cluster-devel] Re: [PATCH] configfs: Silence lockdep on mkdir(), rmdir() and configfs_depend_item()

2008-12-17 Thread Andrew Morton
On Wed, 17 Dec 2008 14:03:10 -0800 Joel Becker wrote: > > > > > > [etc] > > > > > > > Oh dear, what an unpleasant patch. > > > > Peter, can this be saved? > > I'd love to see it work within lockdep, but it seems rather > hard, so that's why I recommended Louis cook up this version. I se

[Cluster-devel] Re: [PATCH] configfs: Silence lockdep on mkdir(), rmdir() and configfs_depend_item()

2008-12-17 Thread Andrew Morton
On Fri, 12 Dec 2008 16:29:11 +0100 Louis Rilling wrote: > When attaching default groups (subdirs) of a new group (in mkdir() or > in configfs_register()), configfs recursively takes inode's mutexes > along the path from the parent of the new group to the default > subdirs. This is needed to ensur

[Cluster-devel] Re: [PATCH 00/25] move handling of setuid/gid bits from VFS into individual setattr functions (RESEND)

2007-08-08 Thread Andrew Morton
On Wed, 8 Aug 2007 08:54:35 -0400 Jeff Layton <[EMAIL PROTECTED]> wrote: > On Tue, 7 Aug 2007 17:15:01 -0700 > Andrew Morton <[EMAIL PROTECTED]> wrote: > > > On Mon, 6 Aug 2007 09:54:03 -0400 > > Jeff Layton <[EMAIL PROTECTED]> wrote: > > >

[Cluster-devel] Re: [PATCH 00/25] move handling of setuid/gid bits from VFS into individual setattr functions (RESEND)

2007-08-07 Thread Andrew Morton
On Tue, 07 Aug 2007 20:45:34 -0400 Trond Myklebust <[EMAIL PROTECTED]> wrote: > > - rename something so that unconverted filesystems will reliably fail to > > compile? > > > > - leave existing filesystems alone, but add a new > > inode_operations.setattr_jeff, which the networked filesytems c

[Cluster-devel] Re: [PATCH 00/25] move handling of setuid/gid bits from VFS into individual setattr functions (RESEND)

2007-08-07 Thread Andrew Morton
On Mon, 6 Aug 2007 09:54:03 -0400 Jeff Layton <[EMAIL PROTECTED]> wrote: > Apologies for the resend, but the original sending had the date in the > email header and it caused some of these to bounce... > > ( Please consider trimming the Cc list if discussing some aspect of this > that doesn't con