n that case?
> The second option is that we turn off fine-grained finestamps for v6.6
> and you get to explore other options.
You could put it behind an EXPERIMENTAL Kconfig option so that the
code stays in and can be used by the brave or foolish while it is
still being refined.
> It isn't a big deal regressions like this were always to be expected but
> v6.6 needs to stabilize so anything that requires more significant work
> is not an option.
--
Chuck Lever
On Wed, Aug 30, 2023 at 08:32:43AM -0400, Alexander Aring wrote:
> Hi,
>
> On Fri, Aug 25, 2023 at 1:21 PM Chuck Lever wrote:
> >
> > On Wed, Aug 23, 2023 at 05:33:46PM -0400, Alexander Aring wrote:
> > > This patch reverts mostly commit 40595cdc93ed ("nfs:
_SAFE_ASYNC_LOCK) || !f_op->lock;
> +}
> +
I'd like some cosmetic changes to this API, since this seems to be
the first utility function for checking EXPORT_OP flags.
- The function name is unwieldy. How about exportfs_lock_op_is_async() ?
- Break up the long lines. It's OK with me if the return value type
is left on a different line than the function name and parameters.
- This function is globally visible, so a kdoc comment is needed.
- The f_op->lock check is common to all the call sites, but it is
not at all related to the export AFAICT. Can it be removed from
this inline function?
> extern int exportfs_encode_inode_fh(struct inode *inode, struct fid *fid,
> int *max_len, struct inode *parent,
> int flags);
> --
> 2.31.1
>
--
Chuck Lever
nlmsvc_remove_block(block);
> ret = nlm_lck_denied_nolocks;
> goto out;
> }
>
> ret = nlm_lck_blocked;
> -
> - /* Append to list of blocked */
> - nlmsvc_insert_block(block, NLM_NEVER);
> out:
> mutex_unlock(&file->f_mutex);
> nlmsvc_release_block(block);
> --
> 2.31.1
>
--
Chuck Lever
On Thu, Jul 20, 2023 at 08:58:04AM -0400, Alexander Aring wrote:
> This patch fixes races when lockd accessing the global nlm_blocked list.
> It was mostly safe to access the list because everything was accessed
> from the lockd kernel thread context but there exists cases like
> nlmsvc_grant_defer
> @@ -52,6 +52,7 @@
> #include
> #include
> #include
> +#include
> #include
> #include
> #include
> diff --git a/fs/namei.c b/fs/namei.c
> index 578c2110df02..d5121f51f900 100644
> --- a/fs/namei.c
> +++ b/fs/namei.c
> @@ -20,6 +20,7 @@
> #include
> #inc
