Re: [Cluster-devel] [PATCH v6 1/7] fs: pass the request_mask to generic_fillattr

2023-07-26 Thread Joseph Qi
1b337ebce4df..8184499ae7a5 100644 > --- a/fs/ocfs2/file.c > +++ b/fs/ocfs2/file.c > @@ -1319,7 +1319,7 @@ int ocfs2_getattr(struct mnt_idmap *idmap, const struct > path *path, > goto bail; > } > > - generic_fillattr(&nop_mnt_idmap, inode, stat); > +

Re: [Cluster-devel] [PATCH v4 4/5] ocfs2: convert to use i_blockmask()

2023-03-10 Thread Joseph Qi
On 3/10/23 1:48 PM, Yangtao Li wrote: > Use i_blockmask() to simplify code. BTW convert ocfs2_is_io_unaligned > to return bool type and the fact that the value will be the same > (i.e. that ->i_blkbits is never changed by ocfs2). > > Signed-off-by: Yangtao Li > --- > fs/ocfs2/file.c | 9 ++---

Re: [Cluster-devel] [PATCH] filelock: move file locking definitions to separate header file

2022-11-22 Thread Joseph Qi
On 11/22/22 8:20 PM, Jeff Layton wrote: > On Tue, 2022-11-22 at 09:51 +0800, Joseph Qi wrote: >> Hi, >> >> On 11/21/22 4:59 AM, Jeff Layton wrote: >>> The file locking definitions have lived in fs.h since the dawn of time, >>> but they are only used by

Re: [Cluster-devel] [PATCH] filelock: move file locking definitions to separate header file

2022-11-21 Thread Joseph Qi
Hi, On 11/21/22 4:59 AM, Jeff Layton wrote: > The file locking definitions have lived in fs.h since the dawn of time, > but they are only used by a small subset of the source files that > include it. > > Move the file locking definitions to a new header file, and add the > appropriate #include di

Re: [Cluster-devel] [Ocfs2-devel] [PATCH v2 08/14] ocfs2: replace ll_rw_block()

2022-09-05 Thread Joseph Qi
ers. So stop using ll_rw_block() in ocfs2. > > Signed-off-by: Zhang Yi Looks good to me. Reviewed-by: Joseph Qi > --- > fs/ocfs2/aops.c | 2 +- > fs/ocfs2/super.c | 4 +--- > 2 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/fs/ocfs2/aops.c b/

Re: [Cluster-devel] [Ocfs2-devel] [PATCH 2/3] ocfs2: allow writing back pages out of inode size

2021-04-29 Thread Joseph Qi
file easily. > > qemu-img convert -p -t none -T none -f qcow2 $qcow_image \ > -O qcow2 -o compat=1.1 $qcow_image.conv > > Cc: > Signed-off-by: Junxiao Bi Reviewed-by: Joseph Qi > --- > fs/ocfs2/aops.c | 19 ++- > 1 file changed, 1

Re: [Cluster-devel] [Ocfs2-devel] [PATCH 1/3] fs/buffer.c: add new api to allow eof writeback

2021-04-29 Thread Joseph Qi
xiao Bi Looks good. Reviewed-by: Joseph Qi > --- > fs/buffer.c | 14 +++--- > include/linux/buffer_head.h | 3 +++ > 2 files changed, 14 insertions(+), 3 deletions(-) > > diff --git a/fs/buffer.c b/fs/buffer.c > index 0cb7ffd4977c..802f0bacdbde 1006

Re: [Cluster-devel] [Ocfs2-devel] [PATCH v6 10/19] fs: Convert mpage_readpages to mpage_readahead

2020-02-18 Thread Joseph Qi
lock(inode, 0); > - return err; > - } > + if (down_read_trylock(&oi->ip_alloc_sem) == 0) > + goto out_unlock; > > /* >* Don't bother with inline-data. There isn't anything >* to read-ahead in that case a