Re: [Cluster-devel] [PATCH -v4] ext4: don't BUG if kernel subsystems dirty pages without asking ext4 first

2022-03-03 Thread Lee Jones
++- > 1 file changed, 26 insertions(+), 1 deletion(-) Thanks a bunch for sticking with this Ted. I've been following along with great interest. Sadly I am not in a position to provide a review. Just wanted to pop by and say thank you. -- Lee Jones [李琼斯] Principal Tec

[Cluster-devel] [REPORT] kernel BUG at fs/ext4/inode.c:2620 - page_buffers()

2022-02-16 Thread Lee Jones
0x20c22fa0 = 0x2080; *(uint64_t*)0x20c22fa8 = 0x2034afa5; syscall(__NR_process_vm_writev, r[4], 0x20c22000ul, 1ul, 0x20c22fa0ul, 1ul, 0ul); break; case 9: syscall(__NR_sendfile, r[0], r[1], 0ul, 0x8005ul); break; } } int main(void) { syscall(__NR_mmap, 0x1000ul, 0x1000ul, 0ul, 0x32ul, -1, 0ul); syscall(__NR_mmap, 0x2000ul, 0x100ul, 7ul, 0x32ul, -1, 0ul); syscall(__NR_mmap, 0x2100ul, 0x1000ul, 0ul, 0x32ul, -1, 0ul); use_temporary_dir(); do_sandbox_none(); return 0; } -- Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [Cluster-devel] [PATCH 1/1] Revert "iomap: fall back to buffered writes for invalidation failures"

2022-02-14 Thread Lee Jones
On Mon, 14 Feb 2022, Matthew Wilcox wrote: > On Mon, Feb 14, 2022 at 02:11:46PM +0000, Lee Jones wrote: > > On Mon, 14 Feb 2022, Christoph Hellwig wrote: > > > > > Let me repeat myself: Please send a proper bug report to the linux-ext4 > > > list. Than

Re: [Cluster-devel] [PATCH 1/1] Revert "iomap: fall back to buffered writes for invalidation failures"

2022-02-14 Thread Lee Jones
least require some guidance from you SMEs. Please bear with me while I clear my desk - lots on currently. Bug report to follow. -- Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [Cluster-devel] [PATCH 1/1] Revert "iomap: fall back to buffered writes for invalidation failures"

2022-02-14 Thread Lee Jones
Let's attempt to seek beyond the mud slinging, swearing and the whiny amateur dramatics for just a brief moment and concentrate solely on the technicals please. On Fri, 11 Feb 2022, Matthew Wilcox wrote: > On Thu, Feb 10, 2022 at 10:15:52AM +0000, Lee Jones wrote: > > On Wed, 09 Feb 2022

Re: [Cluster-devel] [PATCH 1/1] Revert "iomap: fall back to buffered writes for invalidation failures"

2022-02-10 Thread Lee Jones
On Wed, 09 Feb 2022, Darrick J. Wong wrote: > On Wed, Feb 09, 2022 at 08:52:43AM +0000, Lee Jones wrote: > > This reverts commit 60263d5889e6dc5987dc51b801be4955ff2e4aa7. > > > > Reverting since this commit opens a potential avenue for abuse. > > What kind of abuse

Re: [Cluster-devel] [PATCH 1/1] Revert "iomap: fall back to buffered writes for invalidation failures"

2022-02-09 Thread Lee Jones
On Wed, 09 Feb 2022, Matthew Wilcox wrote: > On Wed, Feb 09, 2022 at 03:59:48PM +0000, Lee Jones wrote: > > On Wed, 09 Feb 2022, Christoph Hellwig wrote: > > > > > On Wed, Feb 09, 2022 at 08:52:43AM +, Lee Jones wrote: > > > > This reverts commit 6026

Re: [Cluster-devel] [PATCH 1/1] Revert "iomap: fall back to buffered writes for invalidation failures"

2022-02-09 Thread Lee Jones
On Wed, 09 Feb 2022, Christoph Hellwig wrote: > On Wed, Feb 09, 2022 at 08:52:43AM +0000, Lee Jones wrote: > > This reverts commit 60263d5889e6dc5987dc51b801be4955ff2e4aa7. > > > > Reverting since this commit opens a potential avenue for abuse. > > > > The C-re

[Cluster-devel] [PATCH 1/1] Revert "iomap: fall back to buffered writes for invalidation failures"

2022-02-09 Thread Lee Jones
r invalidation failures") Reported-by: syzbot+0ed9f769264276638...@syzkaller.appspotmail.com Signed-off-by: Lee Jones --- fs/ext4/file.c | 2 -- fs/gfs2/file.c | 3 +-- fs/iomap/direct-io.c | 16 +--- fs/iomap/trace.h | 1 - fs/xfs/xfs_file.c| 4 ++-- fs/zon

Re: [Cluster-devel] [PATCH 02/15] fs: gfs2: glock: Fix some deficient kernel-doc headers and demote non-conformant ones

2021-05-21 Thread Lee Jones
On Fri, 21 May 2021, Lee Jones wrote: > On Fri, 21 May 2021, Andreas Gruenbacher wrote: > > > On Thu, May 20, 2021 at 2:00 PM Lee Jones wrote: > > > Fixes the following W=1 kernel build warning(s): > > > > > > fs/gfs2/glock.c:365: warning: Function parame

Re: [Cluster-devel] [PATCH 02/15] fs: gfs2: glock: Fix some deficient kernel-doc headers and demote non-conformant ones

2021-05-21 Thread Lee Jones
On Fri, 21 May 2021, Andreas Gruenbacher wrote: > On Thu, May 20, 2021 at 2:00 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > > > fs/gfs2/glock.c:365: warning: Function parameter or member 'gl' not > > described in 'do_error' > &

[Cluster-devel] [PATCH 00/15] Rid W=1 warnings from FS {GFS2, NTFS}

2021-05-20 Thread Lee Jones
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. Lee Jones (15): fs: gfs2: bmap: Demote half-complete kernel-doc headers fix others fs: gfs2: glock: Fix some deficient kernel-doc headers

[Cluster-devel] [PATCH 01/15] fs: gfs2: bmap: Demote half-complete kernel-doc headers fix others

2021-05-20 Thread Lee Jones
Cc: Andreas Gruenbacher Cc: cluster-devel@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/bmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/gfs2/bmap.c b/fs/gfs2/bmap.c index 0bcf11a9987ba..edf6004b643ac 100644 --- a/fs/gfs2/bmap.c +++ b/fs/gfs2/bmap.c @@ -1658,7

Re: [Cluster-devel] [PATCH 00/31] Rid W=1 warnings from GFS2 and EncryptFS

2021-04-19 Thread Lee Jones
On Mon, 19 Apr 2021, Tyler Hicks wrote: > On 2021-03-30 17:44:27, Lee Jones wrote: > > This set is part of a larger effort attempting to clean-up W=1 > > kernel builds, which are currently overwhelmingly riddled with > > niggly little warnings. > > > > T

Re: [Cluster-devel] [PATCH 00/18] Rid W=1 warnings from GFS2

2021-04-12 Thread Lee Jones
On Fri, 09 Apr 2021, Andreas Gruenbacher wrote: > Hi Lee, > > On Tue, Apr 6, 2021 at 1:54 PM Lee Jones wrote: > > > > These have been on the list for a couple of weeks now. > > thanks for your fixes, I've gone through them now. I've fixed up some > comments inst

Re: [Cluster-devel] [PATCH 00/18] Rid W=1 warnings from GFS2

2021-04-06 Thread Lee Jones
On Tue, 06 Apr 2021, Bob Peterson wrote: > - Original Message - > > On Fri, 26 Mar 2021, Lee Jones wrote: > > > > > This set is part of a larger effort attempting to clean-up W=1 > > > kernel builds, which are currently overwhelmingly riddled

Re: [Cluster-devel] [PATCH 00/18] Rid W=1 warnings from GFS2

2021-04-06 Thread Lee Jones
On Fri, 26 Mar 2021, Lee Jones wrote: > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. > > Lee Jones (18): > fs: gfs2: dir: Finish off mostly complete headers demote o

[Cluster-devel] [PATCH 08/31] fs: gfs2: aops: Fix a little potential doc-rot

2021-03-30 Thread Lee Jones
-devel@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/aops.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/fs/gfs2/aops.c b/fs/gfs2/aops.c index cc4f987687f3c..23b5be3db044c 100644 --- a/fs/gfs2/aops.c +++ b/fs/gfs2/aops.c @@ -540,10 +540,7 @@ int gfs2_internal_read

[Cluster-devel] [PATCH 11/31] fs: gfs2: file: Strip out superfluous param description and demote kernel-doc abuse

2021-03-30 Thread Lee Jones
Signed-off-by: Lee Jones --- fs/gfs2/file.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/gfs2/file.c b/fs/gfs2/file.c index 2d500f90cdacf..afab20e5954fd 100644 --- a/fs/gfs2/file.c +++ b/fs/gfs2/file.c @@ -118,7 +118,7 @@ static int gfs2_readdir(struct file *file

[Cluster-devel] [PATCH 12/31] fs: gfs2: ops_fstype: Fix a little doc-rot

2021-03-30 Thread Lee Jones
: warning: Excess function parameter 'args' description in 'gfs2_fill_super' fs/gfs2/ops_fstype.c:1102: warning: Excess function parameter 'silent' description in 'gfs2_fill_super' Cc: Bob Peterson Cc: Andreas Gruenbacher Cc: cluster-devel@redhat.com Signed-off-by: Lee Jones --- fs/gfs2

[Cluster-devel] [PATCH 05/31] fs: gfs2: log: Fix a couple of param descriptions and demote non-conformant headers

2021-03-30 Thread Lee Jones
: cluster-devel@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/log.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/fs/gfs2/log.c b/fs/gfs2/log.c index 6410281546f92..eef33cd251e4b 100644 --- a/fs/gfs2/log.c +++ b/fs/gfs2/log.c @@ -65,7 +65,6 @@ unsigned int

[Cluster-devel] [PATCH 00/31] Rid W=1 warnings from GFS2 and EncryptFS

2021-03-30 Thread Lee Jones
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. There is more to do in filesystems. Another set will follow. Lee Jones (31): fs: gfs2: dir: Finish off mostly complete headers demote others

[Cluster-devel] [PATCH 02/31] fs: gfs2: xattr: Help out some kernel-doc header demote non-conformant ones

2021-03-30 Thread Lee Jones
Peterson Cc: Andreas Gruenbacher Cc: cluster-devel@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/xattr.c | 25 +++-- 1 file changed, 7 insertions(+), 18 deletions(-) diff --git a/fs/gfs2/xattr.c b/fs/gfs2/xattr.c index 124b3d5a72665..fe2109789f75b 100644 --- a/fs/gfs2/xattr.c

[Cluster-devel] [PATCH 15/31] fs: gfs2: recovery: Provide missing param descriptions and remove one other

2021-03-30 Thread Lee Jones
parameter or member 'pass' not described in 'foreach_descriptor' Cc: Bob Peterson Cc: Andreas Gruenbacher Cc: cluster-devel@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/recovery.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/gfs2/recovery.c b/fs/gfs2/recovery.c

[Cluster-devel] [PATCH 16/31] fs: gfs2: super: Fix kernel-doc issues where feasible demote one other

2021-03-30 Thread Lee Jones
: Andreas Gruenbacher Cc: cluster-devel@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/super.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/fs/gfs2/super.c b/fs/gfs2/super.c index 669ce921d0096..841b430d532cd 100644 --- a/fs/gfs2/super.c +++ b/fs/gfs2/super.c

[Cluster-devel] [PATCH 01/31] fs: gfs2: dir: Finish off mostly complete headers demote others

2021-03-30 Thread Lee Jones
-off-by: Lee Jones --- fs/gfs2/dir.c | 35 +-- 1 file changed, 13 insertions(+), 22 deletions(-) diff --git a/fs/gfs2/dir.c b/fs/gfs2/dir.c index c0f2875c946c9..9c1caaef3f0cd 100644 --- a/fs/gfs2/dir.c +++ b/fs/gfs2/dir.c @@ -767,7 +767,7 @@ static int get_leaf

[Cluster-devel] [PATCH 07/31] fs: gfs2: glock: Fix some deficient kernel-doc headers and demote non-conformant ones

2021-03-30 Thread Lee Jones
parameter or member 'p' not described in 'nq_m_sync' fs/gfs2/glock.c:1993: warning: Excess function parameter 'wait' description in 'gfs2_gl_hash_clear' Cc: Bob Peterson Cc: Andreas Gruenbacher Cc: cluster-devel@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/glock.c | 9 - 1 file

[Cluster-devel] [PATCH 04/31] fs: gfs2: glops: Fix a couple of kernel-doc misdemeanours demote others

2021-03-30 Thread Lee Jones
: Andreas Gruenbacher Cc: cluster-devel@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/glops.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/fs/gfs2/glops.c b/fs/gfs2/glops.c index ef0b583c3417c..5711b2c8de9e2 100644 --- a/fs/gfs2/glops.c +++ b/fs/gfs2

[Cluster-devel] [PATCH 06/31] fs: gfs2: lops: Help out worthy kernel-doc headers and demote others

2021-03-30 Thread Lee Jones
parameter or member 'sdp' not described in 'databuf_lo_before_commit' fs/gfs2/lops.c:983: warning: Function parameter or member 'tr' not described in 'databuf_lo_before_commit' Cc: Bob Peterson Cc: Andreas Gruenbacher Cc: cluster-devel@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/lops.c

[Cluster-devel] [PATCH 18/31] fs: gfs2: lock_dlm: Demote incomplete kernel-doc header

2021-03-30 Thread Lee Jones
: Excess function parameter 'mv' description in 'gfs2_update_stats' Cc: Bob Peterson Cc: Andreas Gruenbacher Cc: cluster-devel@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/lock_dlm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/gfs2/lock_dlm.c b/fs/gfs2/lock_dlm.c

[Cluster-devel] [PATCH 17/31] fs: gfs2: util: Fix one conformant kernel-doc header and demote a bunch of abuses

2021-03-30 Thread Lee Jones
or member 'file' not described in 'gfs2_io_error_bh_i' fs/gfs2/util.c:546: warning: Function parameter or member 'line' not described in 'gfs2_io_error_bh_i' Cc: Bob Peterson Cc: Andreas Gruenbacher Cc: cluster-devel@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/util.c | 19

[Cluster-devel] [PATCH 13/31] fs: gfs2: quota: Fix incorrect param name in 'gfs2_quotad'

2021-03-30 Thread Lee Jones
: cluster-devel@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/quota.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/gfs2/quota.c b/fs/gfs2/quota.c index 6e173ae378c44..33520eed467c2 100644 --- a/fs/gfs2/quota.c +++ b/fs/gfs2/quota.c @@ -1534,7 +1534,7 @@ void gfs2_wake_up_statfs

[Cluster-devel] [PATCH 10/31] fs: gfs2: inode: Fix worthy function headers demote others

2021-03-30 Thread Lee Jones
in 'gfs2_setattr_simple' fs/gfs2/inode.c:1976: warning: Function parameter or member 'mnt_userns' not described in 'gfs2_setattr' Cc: Bob Peterson Cc: Andreas Gruenbacher Cc: cluster-devel@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/inode.c | 22 -- 1 file changed, 12

[Cluster-devel] [PATCH 14/31] fs: gfs2: rgrp: Fix a few kernel-doc misdemeanours

2021-03-30 Thread Lee Jones
: warning: Function parameter or member 'rgd' not described in 'fast_to_acquire' Cc: Bob Peterson Cc: Andreas Gruenbacher Cc: cluster-devel@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/rgrp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c

[Cluster-devel] [PATCH 03/31] fs: gfs2: bmap: Demote half-complete kernel-doc headers fix others

2021-03-30 Thread Lee Jones
Cc: Andreas Gruenbacher Cc: cluster-devel@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/bmap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/gfs2/bmap.c b/fs/gfs2/bmap.c index 7a358ae051851..7ff20db4999fb 100644 --- a/fs/gfs2/bmap.c +++ b/fs/gfs2/bmap.c @@ -1477,7

[Cluster-devel] [PATCH 09/31] fs: gfs2: meta_io: Add missing description for 'rahead' param

2021-03-30 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): fs/gfs2/meta_io.c:249: warning: Function parameter or member 'rahead' not described in 'gfs2_meta_read' Cc: Bob Peterson Cc: Andreas Gruenbacher Cc: cluster-devel@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/meta_io.c | 1 + 1 file

[Cluster-devel] [PATCH 11/18] fs: gfs2: file: Strip out superflouous param description and demote kernel-doc abuse

2021-03-26 Thread Lee Jones
Signed-off-by: Lee Jones --- fs/gfs2/file.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/gfs2/file.c b/fs/gfs2/file.c index 2d500f90cdacf..afab20e5954fd 100644 --- a/fs/gfs2/file.c +++ b/fs/gfs2/file.c @@ -118,7 +118,7 @@ static int gfs2_readdir(struct file *file

[Cluster-devel] [PATCH 13/18] fs: gfs2: quota: Fix incorrect param name in 'gfs2_quotad'

2021-03-26 Thread Lee Jones
: cluster-devel@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/quota.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/gfs2/quota.c b/fs/gfs2/quota.c index 6e173ae378c44..33520eed467c2 100644 --- a/fs/gfs2/quota.c +++ b/fs/gfs2/quota.c @@ -1534,7 +1534,7 @@ void gfs2_wake_up_statfs

[Cluster-devel] [PATCH 12/18] fs: gfs2: ops_fstype: Fix a little doc-rot

2021-03-26 Thread Lee Jones
: warning: Excess function parameter 'args' description in 'gfs2_fill_super' fs/gfs2/ops_fstype.c:1102: warning: Excess function parameter 'silent' description in 'gfs2_fill_super' Cc: Bob Peterson Cc: Andreas Gruenbacher Cc: cluster-devel@redhat.com Signed-off-by: Lee Jones --- fs/gfs2

[Cluster-devel] [PATCH 04/18] fs: gfs2: glops: Fix a couple of kernel-doc misdemeanours demote others

2021-03-26 Thread Lee Jones
: Andreas Gruenbacher Cc: cluster-devel@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/glops.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/fs/gfs2/glops.c b/fs/gfs2/glops.c index ef0b583c3417c..5711b2c8de9e2 100644 --- a/fs/gfs2/glops.c +++ b/fs/gfs2

[Cluster-devel] [PATCH 16/18] fs: gfs2: super: Fix kernel-doc issues where feasible demote one other

2021-03-26 Thread Lee Jones
: Andreas Gruenbacher Cc: cluster-devel@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/super.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/fs/gfs2/super.c b/fs/gfs2/super.c index 9e91c9d92bd65..aba117aa433dc 100644 --- a/fs/gfs2/super.c +++ b/fs/gfs2/super.c

[Cluster-devel] [PATCH 15/18] fs: gfs2: recovery: Provide missing param descriptions and remove one other

2021-03-26 Thread Lee Jones
parameter or member 'pass' not described in 'foreach_descriptor' Cc: Bob Peterson Cc: Andreas Gruenbacher Cc: cluster-devel@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/recovery.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/gfs2/recovery.c b/fs/gfs2/recovery.c

[Cluster-devel] [PATCH 18/18] fs: gfs2: lock_dlm: Demote incomplete kernel-doc header

2021-03-26 Thread Lee Jones
: Excess function parameter 'mv' description in 'gfs2_update_stats' Cc: Bob Peterson Cc: Andreas Gruenbacher Cc: cluster-devel@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/lock_dlm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/gfs2/lock_dlm.c b/fs/gfs2/lock_dlm.c

[Cluster-devel] [PATCH 08/18] fs: gfs2: aops: Fix a little potential doc-rot

2021-03-26 Thread Lee Jones
-devel@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/aops.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/fs/gfs2/aops.c b/fs/gfs2/aops.c index cc4f987687f3c..23b5be3db044c 100644 --- a/fs/gfs2/aops.c +++ b/fs/gfs2/aops.c @@ -540,10 +540,7 @@ int gfs2_internal_read

[Cluster-devel] [PATCH 06/18] fs: gfs2: lops: Help out worthy kernel-doc headers and demote others

2021-03-26 Thread Lee Jones
parameter or member 'sdp' not described in 'databuf_lo_before_commit' fs/gfs2/lops.c:983: warning: Function parameter or member 'tr' not described in 'databuf_lo_before_commit' Cc: Bob Peterson Cc: Andreas Gruenbacher Cc: cluster-devel@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/lops.c

[Cluster-devel] [PATCH 10/18] fs: gfs2: inode: Fix worthy function headers demote others

2021-03-26 Thread Lee Jones
in 'gfs2_setattr_simple' fs/gfs2/inode.c:1976: warning: Function parameter or member 'mnt_userns' not described in 'gfs2_setattr' Cc: Bob Peterson Cc: Andreas Gruenbacher Cc: cluster-devel@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/inode.c | 22 -- 1 file changed, 12

[Cluster-devel] [PATCH 14/18] fs: gfs2: rgrp: Fix a few kernel-doc misdemeanours

2021-03-26 Thread Lee Jones
: warning: Function parameter or member 'rgd' not described in 'fast_to_acquire' Cc: Bob Peterson Cc: Andreas Gruenbacher Cc: cluster-devel@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/rgrp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c

[Cluster-devel] [PATCH 17/18] fs: gfs2: util: Fix one conformant kernel-doc header and demote a bunch of abuses

2021-03-26 Thread Lee Jones
or member 'file' not described in 'gfs2_io_error_bh_i' fs/gfs2/util.c:546: warning: Function parameter or member 'line' not described in 'gfs2_io_error_bh_i' Cc: Bob Peterson Cc: Andreas Gruenbacher Cc: cluster-devel@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/util.c | 19

[Cluster-devel] [PATCH 05/18] fs: gfs2: log: Fix a couple of param descriptions and demote non-conformant headers

2021-03-26 Thread Lee Jones
: cluster-devel@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/log.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/fs/gfs2/log.c b/fs/gfs2/log.c index 6410281546f92..eef33cd251e4b 100644 --- a/fs/gfs2/log.c +++ b/fs/gfs2/log.c @@ -65,7 +65,6 @@ unsigned int

[Cluster-devel] [PATCH 09/18] fs: gfs2: meta_io: Add missing description for 'rahead' param

2021-03-26 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): fs/gfs2/meta_io.c:249: warning: Function parameter or member 'rahead' not described in 'gfs2_meta_read' Cc: Bob Peterson Cc: Andreas Gruenbacher Cc: cluster-devel@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/meta_io.c | 1 + 1 file

[Cluster-devel] [PATCH 03/18] fs: gfs2: bmap: Demote half-complete kernel-doc headers fix others

2021-03-26 Thread Lee Jones
Cc: Andreas Gruenbacher Cc: cluster-devel@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/bmap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/gfs2/bmap.c b/fs/gfs2/bmap.c index 7a358ae051851..7ff20db4999fb 100644 --- a/fs/gfs2/bmap.c +++ b/fs/gfs2/bmap.c @@ -1477,7

[Cluster-devel] [PATCH 02/18] fs: gfs2: xattr: Help out some kernel-doc header demote non-conformant ones

2021-03-26 Thread Lee Jones
Peterson Cc: Andreas Gruenbacher Cc: cluster-devel@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/xattr.c | 25 +++-- 1 file changed, 7 insertions(+), 18 deletions(-) diff --git a/fs/gfs2/xattr.c b/fs/gfs2/xattr.c index 124b3d5a72665..fe2109789f75b 100644 --- a/fs/gfs2/xattr.c

[Cluster-devel] [PATCH 01/18] fs: gfs2: dir: Finish off mostly complete headers demote others

2021-03-26 Thread Lee Jones
-off-by: Lee Jones --- fs/gfs2/dir.c | 35 +-- 1 file changed, 13 insertions(+), 22 deletions(-) diff --git a/fs/gfs2/dir.c b/fs/gfs2/dir.c index c0f2875c946c9..9c1caaef3f0cd 100644 --- a/fs/gfs2/dir.c +++ b/fs/gfs2/dir.c @@ -767,7 +767,7 @@ static int get_leaf

[Cluster-devel] [PATCH 07/18] fs: gfs2: glock: Fix some deficient kernel-doc headers and demote non-conformant ones

2021-03-26 Thread Lee Jones
parameter or member 'p' not described in 'nq_m_sync' fs/gfs2/glock.c:1993: warning: Excess function parameter 'wait' description in 'gfs2_gl_hash_clear' Cc: Bob Peterson Cc: Andreas Gruenbacher Cc: cluster-devel@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/glock.c | 9 - 1 file

[Cluster-devel] [PATCH 00/18] Rid W=1 warnings from GFS2

2021-03-26 Thread Lee Jones
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. Lee Jones (18): fs: gfs2: dir: Finish off mostly complete headers demote others fs: gfs2: xattr: Help out some kernel-doc header demote non