[Cluster-devel] [PATCH 00/12] Change readahead API

2020-01-24 Thread Matthew Wilcox
From: "Matthew Wilcox (Oracle)" This series adds a readahead address_space operation to eventually replace the readpages operation. The key difference is that pages are added to the page cache as they are allocated (and then looked up by the filesystem) instead of passing them

Re: [Cluster-devel] RFC: hold i_rwsem until aio completes

2020-01-18 Thread Matthew Wilcox
On Wed, Jan 15, 2020 at 03:33:47PM +0100, Peter Zijlstra wrote: > On Wed, Jan 15, 2020 at 09:24:28AM -0400, Jason Gunthorpe wrote: > > > I was interested because you are talking about allowing the read/write side > > of a rw sem to be held across a return to user space/etc, which is the > > same

Re: [Cluster-devel] RFC: hold i_rwsem until aio completes

2020-01-14 Thread Matthew Wilcox
On Tue, Jan 14, 2020 at 05:12:13PM +0100, Christoph Hellwig wrote: > Second I/O > completions often come from interrupt context, which means the re-acquire > is recorded as from irq context, leading to warnings about incorrect > contexts. I wonder if we could just have a bit in lockdep that says

Re: [Cluster-devel] [PATCH v2 1/2] iomap: Add a page_prepare callback

2019-04-25 Thread Matthew Wilcox
On Thu, Apr 25, 2019 at 05:26:30PM +0200, Andreas Gruenbacher wrote: This seems to be corrupted; there's no declaration of a page_ops in iomap_write_begin ... unless you're basing on a patch I don't have? > diff --git a/fs/iomap.c b/fs/iomap.c > index 97cb9d486a7d..967c985c5310 100644 > ---

Re: [Cluster-devel] [PATCH] vfs: Allow selection of fs root independent of sb

2019-03-21 Thread Matthew Wilcox
On Thu, Mar 21, 2019 at 05:26:44PM +, Andrew Price wrote: > Take a function pointer 'select_root' in vfs_get_block_super() to allow > callers to select the root dentry based on the context. Can't this be a fs_context_operations pointer?

Re: [Cluster-devel] [PATCH v2 2/4] mm: add file_fdatawait_range and file_write_and_wait

2017-07-26 Thread Matthew Wilcox
On Wed, Jul 26, 2017 at 01:55:36PM -0400, Jeff Layton wrote: > +int file_write_and_wait(struct file *file) > +{ > + int err = 0, err2; > + struct address_space *mapping = file->f_mapping; > + > + if ((!dax_mapping(mapping) && mapping->nrpages) || > + (dax_mapping(mapping) &&

Re: [Cluster-devel] [PATCH v2 4/4] gfs2: convert to errseq_t based writeback error reporting for fsync

2017-07-26 Thread Matthew Wilcox
On Wed, Jul 26, 2017 at 01:55:38PM -0400, Jeff Layton wrote: > @@ -668,12 +668,14 @@ static int gfs2_fsync(struct file *file, loff_t start, > loff_t end, > if (ret) > return ret; > if (gfs2_is_jdata(ip)) > -

Re: [Cluster-devel] [PATCH v4 13/27] lib: add errseq_t type and infrastructure for handling it

2017-05-10 Thread Matthew Wilcox
On Tue, May 09, 2017 at 11:49:16AM -0400, Jeff Layton wrote: > +++ b/lib/errseq.c > @@ -0,0 +1,199 @@ > +#include > +#include > +#include > +#include > + > +/* > + * An errseq_t is a way of recording errors in one place, and allowing any > + * number of "subscribers" to tell whether it has

Re: [Cluster-devel] [PATCH v4 06/27] fs: check for writeback errors after syncing out buffers in generic_file_fsync

2017-05-10 Thread Matthew Wilcox
t; > Reviewed-by: Christoph Hellwig <h...@lst.de> > Reviewed-by: Jan Kara <j...@suse.cz> Reviewed-by: Matthew Wilcox <mawil...@microsoft.com>

Re: [Cluster-devel] [PATCH 1/6] lockdep: allow to disable reclaim lockup detection

2017-02-06 Thread Matthew Wilcox
On Mon, Feb 06, 2017 at 03:34:50PM +0100, Michal Hocko wrote: > This part is not needed for the patch, strictly speaking but I wanted to > make the code more future proof. Understood. I took an extra bit myself for marking the radix tree as being used for an IDR (so the radix tree now uses 4

Re: [Cluster-devel] [PATCH 1/6] lockdep: allow to disable reclaim lockup detection

2017-02-06 Thread Matthew Wilcox
On Mon, Feb 06, 2017 at 03:07:13PM +0100, Michal Hocko wrote: > While we are at it also make sure that the radix tree doesn't > accidentaly override tags stored in the upper part of the gfp_mask. > diff --git a/lib/radix-tree.c b/lib/radix-tree.c > index 9dc093d5ef39..7550be09f9d6 100644 > ---

Re: [Cluster-devel] [PATCH] mm: Avoid returning VM_FAULT_RETRY from ->page_mkwrite handlers

2017-02-03 Thread Matthew Wilcox
On Fri, Feb 03, 2017 at 04:46:40PM +0100, Jan Kara wrote: > On Fri 03-02-17 07:13:59, Matthew Wilcox wrote: > > On Fri, Feb 03, 2017 at 04:07:29PM +0100, Jan Kara wrote: > > > Some ->page_mkwrite handlers may return VM_FAULT_RETRY as its return > > > code (GF

Re: [Cluster-devel] [PATCH] mm: Avoid returning VM_FAULT_RETRY from ->page_mkwrite handlers

2017-02-03 Thread Matthew Wilcox
On Fri, Feb 03, 2017 at 04:07:29PM +0100, Jan Kara wrote: > Some ->page_mkwrite handlers may return VM_FAULT_RETRY as its return > code (GFS2 or Lustre can definitely do this). However VM_FAULT_RETRY > from ->page_mkwrite is completely unhandled by the mm code and results > in locking and

Re: [Cluster-devel] [PATCH 3/4] fsfreeze: manage kill signal when sb_start_pagefault is called

2013-04-07 Thread Matthew Wilcox
, PAGE_CACHE_SIZE); Does the compiler not warn that you're assigning void to 'ret'? Or was there some other SNAFU sending these patches? -- Matthew Wilcox Intel Open Source Technology Centre Bill, look, we understand that you're interested in selling us this operating system

<    1   2   3   4   5