Re: [Cluster-devel] [PATCH v6 0/2] blktrace: Fix deadlock problem

2017-09-18 Thread Steven Rostedt
Acked-by: Steven Rostedt (VMware) for the series. Jens, feel free to take this in your tree. -- Steve On Mon, 18 Sep 2017 14:53:49 -0400 Waiman Long wrote: > v6: > - Add a second patch to rename the bd_fsfreeze_mutex to > bd_fsfreeze_blktrace_mutex. > > v5: >

Re: [Cluster-devel] [PATCH v6 1/2] blktrace: Fix potentail deadlock between delete & sysfs ops

2017-09-19 Thread Steven Rostedt
On Tue, 19 Sep 2017 13:41:35 -0700 Christoph Hellwig wrote: > Call it blk_trace mutex and move it right next to the blk_trace > structure: > > ifdef CONFIG_BLK_DEV_IO_TRACE > struct blk_trace*blk_trace; > struct mutexblk_trace_mutex; > #endif > > which makes it

Re: [Cluster-devel] [PATCH v7] blktrace: Fix potentail deadlock between delete & sysfs ops

2017-09-20 Thread Steven Rostedt
Christoph, Can you give an acked-by for this patch? Jens, You want to take this through your tree, or do you want me to? If you want it, here's my: Acked-by: Steven Rostedt (VMware) -- Steve On Wed, 20 Sep 2017 13:26:11 -0400 Waiman Long wrote: > The lockdep code had repo

Re: [Cluster-devel] [PATCH v7] blktrace: Fix potentail deadlock between delete & sysfs ops

2017-09-20 Thread Steven Rostedt
On Wed, 20 Sep 2017 13:09:31 -0600 Jens Axboe wrote: > > I'll take it through my tree, and I'll prune some of that comment > as well (which should be a commit message thing, not a code comment). > Agreed, and thanks. -- Steve

Re: [Cluster-devel] [PATCH 3/7] dlm: Use seq_is_full - remove seq_printf returns

2014-10-27 Thread Steven Rostedt
Note, I've started with Joe's patches and I'm massaging them for something I can work with. On Tue, 30 Sep 2014 12:34:35 +0200 Petr Mladek wrote: > > - rv = seq_printf(s, "\"\nInvalid master %d\n", > > - res->res_nodeid); > > - if (rv) > > + seq_p

Re: [Cluster-devel] [PATCH 0/7] seq_printf cleanups

2014-10-28 Thread Steven Rostedt
Joe, If you haven't already done so, can you update checkpatch.pl to complain if someone checks the return value of seq_printf(), seq_puts(), or seq_putc(). It should state that those functions will soon be returning void. Thanks! -- Steve

[Cluster-devel] [RFA][PATCH 6/8] dlm: Use seq_puts() instead of seq_printf() for constant strings

2014-10-29 Thread Steven Rostedt
-by: Joe Perches Signed-off-by: Steven Rostedt --- fs/dlm/debug_fs.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/fs/dlm/debug_fs.c b/fs/dlm/debug_fs.c index 3bf460894088..eea64912c9c0 100644 --- a/fs/dlm/debug_fs.c +++ b/fs/dlm/debug_fs.c @@ -279,7 +279,7

[Cluster-devel] [RFA][PATCH 5/8] dlm: Remove seq_printf() return checks and use seq_has_overflowed()

2014-10-29 Thread Steven Rostedt
/p/43590057bcb83846acbbcc1fe641f792b2fb7773.1412031505.git@perches.com Cc: Christine Caulfield Cc: David Teigland Cc: cluster-devel@redhat.com Signed-off-by: Joe Perches Signed-off-by: Steven Rostedt --- fs/dlm/debug_fs.c | 251 +- 1 file

Re: [Cluster-devel] [RFA][PATCH 5/8] dlm: Remove seq_printf() return checks and use seq_has_overflowed()

2014-11-04 Thread Steven Rostedt
On Wed, 29 Oct 2014 17:56:07 -0400 Steven Rostedt wrote: > From: Joe Perches > > [ REQUEST FOR ACKS ] Can any of the DLM maintainers give me an Acked-by for this? Thanks! -- Steve > > The seq_printf() return is going away soon and users of it should > check seq_has_over

Re: [Cluster-devel] [RFA][PATCH 6/8] dlm: Use seq_puts() instead of seq_printf() for constant strings

2014-11-04 Thread Steven Rostedt
On Wed, 29 Oct 2014 17:56:08 -0400 Steven Rostedt wrote: > From: Joe Perches > > [ REQUEST FOR ACKS ] Can any of the DLM maintainers give me an Acked-by for this? Thanks! -- Steve > > Convert the seq_printf output with constant strings to seq_puts. > > Link: >

[Cluster-devel] [PATCH 6/8] dlm: Use seq_puts() instead of seq_printf() for constant strings

2014-11-05 Thread Steven Rostedt
Signed-off-by: Steven Rostedt --- fs/dlm/debug_fs.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/fs/dlm/debug_fs.c b/fs/dlm/debug_fs.c index 3bf460894088..eea64912c9c0 100644 --- a/fs/dlm/debug_fs.c +++ b/fs/dlm/debug_fs.c @@ -279,7 +279,7 @@ static void

[Cluster-devel] [PATCH 5/8] dlm: Remove seq_printf() return checks and use seq_has_overflowed()

2014-11-05 Thread Steven Rostedt
/43590057bcb83846acbbcc1fe641f792b2fb7773.1412031505.git@perches.com Link: http://lkml.kernel.org/r/20141029220107.939492...@goodmis.org Acked-by: David Teigland Cc: Christine Caulfield Cc: cluster-devel@redhat.com Signed-off-by: Joe Perches Signed-off-by: Steven Rostedt --- fs/dlm/debug_fs.c | 251

Re: [Cluster-devel] [PATCH v2 1/2] fs: warn about impending deprecation of mandatory locks

2021-08-20 Thread Steven Rostedt
On Fri, 20 Aug 2021 17:52:19 +0200 David Hildenbrand wrote: > > +static bool warned_mand; > > static inline bool may_mandlock(void) > > { > > + if (!warned_mand) { > > + warned_mand = true; > > + > > pr_warn("==\n"); >

Re: [Cluster-devel] [PATCH/RFC] java: add initial bindings

2022-07-08 Thread Steven Rostedt
On Mon, 20 Jun 2022 16:45:39 -0400 Alexander Aring wrote: Hi Alexander! > This patch adds basic java bindings for libtracecmd. It currently > supports very basic handling of parsing trace-cmd recorded trace files. > There might of course additional improvements regarding swig bindings and > the

Re: [Cluster-devel] [PATCH 00/79] fs: new accessors for inode->i_ctime

2023-06-21 Thread Steven Rostedt
On Wed, 21 Jun 2023 10:45:05 -0400 Jeff Layton wrote: > Most of this conversion was done via coccinelle, with a few of the more > non-standard accesses done by hand. There should be no behavioral > changes with this set. That will come later, as we convert individual > filesystems to use multigra