Re: [Cluster-devel] [GFS2 PATCH] GFS2: Simplify iterative add loop in foreach_descriptor

2018-08-10 Thread Abhijith Das
- Original Message - > From: "Steven Whitehouse" > To: "Andreas Gruenbacher" > Cc: "Bob Peterson" , "cluster-devel" > , "Abhijith Das" > > Sent: Friday, August 10, 2018 7:21:28 AM > Subject: Re: [Cluster-devel]

Re: [Cluster-devel] [GFS2 PATCH] GFS2: Simplify iterative add loop in foreach_descriptor

2018-08-10 Thread Steven Whitehouse
Hi, On 10/08/18 13:13, Andreas Gruenbacher wrote: On 9 August 2018 at 11:35, Steven Whitehouse wrote: Hi, On 08/08/18 19:52, Bob Peterson wrote: Hi, Before this patch, function foreach_descriptor repeatedly called function gfs2_replay_incr_blk which just incremented the value while

Re: [Cluster-devel] [GFS2 PATCH] GFS2: Simplify iterative add loop in foreach_descriptor

2018-08-10 Thread Andreas Gruenbacher
On 9 August 2018 at 11:35, Steven Whitehouse wrote: > Hi, > > > > On 08/08/18 19:52, Bob Peterson wrote: >> >> Hi, >> >> Before this patch, function foreach_descriptor repeatedly called >> function gfs2_replay_incr_blk which just incremented the value while >> decrementing another, and checked

Re: [Cluster-devel] [GFS2 PATCH] GFS2: Simplify iterative add loop in foreach_descriptor

2018-08-09 Thread Bob Peterson
- Original Message - > Now you've hidden the increment of the replay block. Please don't open > code this, but just add an argument to gfs2_replay_incr_blk() such that > you can tell it how many blocks to increment, rather than just assuming > a single block as it does at the moment.

Re: [Cluster-devel] [GFS2 PATCH] GFS2: Simplify iterative add loop in foreach_descriptor

2018-08-09 Thread Steven Whitehouse
Hi, On 08/08/18 19:52, Bob Peterson wrote: Hi, Before this patch, function foreach_descriptor repeatedly called function gfs2_replay_incr_blk which just incremented the value while decrementing another, and checked for wrap. This is a waste of time. This patch just adds the value and adjusts

Re: [Cluster-devel] [GFS2 PATCH] GFS2: Simplify iterative add loop in foreach_descriptor

2018-08-08 Thread Abhijith Das
- Original Message - > From: "Bob Peterson" > To: "cluster-devel" > Sent: Wednesday, August 8, 2018 1:52:03 PM > Subject: [Cluster-devel] [GFS2 PATCH] GFS2: Simplify iterative add loop in > foreach_descriptor > > Hi, > > Before thi

Re: [Cluster-devel] [GFS2 PATCH] GFS2: Simplify iterative add loop in foreach_descriptor

2018-08-08 Thread Andreas Gruenbacher
On 8 August 2018 at 20:52, Bob Peterson wrote: > Hi, > > Before this patch, function foreach_descriptor repeatedly called > function gfs2_replay_incr_blk which just incremented the value while > decrementing another, and checked for wrap. This is a waste of time. > This patch just adds the value

[Cluster-devel] [GFS2 PATCH] GFS2: Simplify iterative add loop in foreach_descriptor

2018-08-08 Thread Bob Peterson
Hi, Before this patch, function foreach_descriptor repeatedly called function gfs2_replay_incr_blk which just incremented the value while decrementing another, and checked for wrap. This is a waste of time. This patch just adds the value and adjusts it if a wrap occurred. Signed-off-by: Bob