Re: [Cluster-devel] [GFS2 PATCH 10/10] gfs2: replace sd_aspace with sd_inode

2021-07-28 Thread Jan Kara
On Wed 28-07-21 09:57:01, Steven Whitehouse wrote: > On Wed, 2021-07-28 at 08:50 +0200, Andreas Gruenbacher wrote: > > On Tue, Jul 13, 2021 at 9:34 PM Bob Peterson > > wrote: > > > On 7/13/21 1:26 PM, Steven Whitehouse wrote: > > > > > > Hi, > > > > > > On Tue, 2021-07-13 at 13:09 -0500, Bob Pet

Re: [Cluster-devel] [GFS2 PATCH 10/10] gfs2: replace sd_aspace with sd_inode

2021-07-28 Thread Steven Whitehouse
Hi, On Wed, 2021-07-28 at 08:50 +0200, Andreas Gruenbacher wrote: > On Tue, Jul 13, 2021 at 9:34 PM Bob Peterson > wrote: > > On 7/13/21 1:26 PM, Steven Whitehouse wrote: > > > > Hi, > > > > On Tue, 2021-07-13 at 13:09 -0500, Bob Peterson wrote: > > > > Before this patch, gfs2 kept its own add

Re: [Cluster-devel] [GFS2 PATCH 10/10] gfs2: replace sd_aspace with sd_inode

2021-07-27 Thread Andreas Gruenbacher
On Tue, Jul 13, 2021 at 9:34 PM Bob Peterson wrote: > On 7/13/21 1:26 PM, Steven Whitehouse wrote: > > Hi, > > On Tue, 2021-07-13 at 13:09 -0500, Bob Peterson wrote: > > Before this patch, gfs2 kept its own address space for rgrps, but > this > caused a lockdep problem because vfs assumes a 1:1 re

Re: [Cluster-devel] [GFS2 PATCH 10/10] gfs2: replace sd_aspace with sd_inode

2021-07-13 Thread Bob Peterson
On 7/13/21 1:26 PM, Steven Whitehouse wrote: Hi, On Tue, 2021-07-13 at 13:09 -0500, Bob Peterson wrote: Before this patch, gfs2 kept its own address space for rgrps, but this caused a lockdep problem because vfs assumes a 1:1 relationship between address spaces and their inode. One problematic

Re: [Cluster-devel] [GFS2 PATCH 10/10] gfs2: replace sd_aspace with sd_inode

2021-07-13 Thread Steven Whitehouse
Hi, On Tue, 2021-07-13 at 13:09 -0500, Bob Peterson wrote: > Before this patch, gfs2 kept its own address space for rgrps, but > this > caused a lockdep problem because vfs assumes a 1:1 relationship > between > address spaces and their inode. One problematic area is this: > I don't think that is

[Cluster-devel] [GFS2 PATCH 10/10] gfs2: replace sd_aspace with sd_inode

2021-07-13 Thread Bob Peterson
Before this patch, gfs2 kept its own address space for rgrps, but this caused a lockdep problem because vfs assumes a 1:1 relationship between address spaces and their inode. One problematic area is this: gfs2_unpin mark_buffer_dirty(bh); mapping = page_mapping(page); __set_page_