Re: [Cluster-devel] [PATCH 1/2] gfs2: Convert gfs2 to fs_context

2019-03-19 Thread Andrew Price
On 18/03/2019 23:01, David Howells wrote: Andrew Price wrote: Umm... What about the fs_context struct? Why can't that be used to propagate the bdev pointer? That's kind of what it's for... It would be useful to have the block device pointer in the fs_context since so many of the filesyste

Re: [Cluster-devel] [PATCH 1/2] gfs2: Convert gfs2 to fs_context

2019-03-18 Thread David Howells
Andrew Price wrote: > > Umm... What about the fs_context struct? Why can't that be used to > > propagate the bdev pointer? That's kind of what it's for... > > It would be useful to have the block device pointer in the fs_context since so > many of the filesystems use them and it makes for an

Re: [Cluster-devel] [PATCH 1/2] gfs2: Convert gfs2 to fs_context

2019-03-18 Thread Andrew Price
On 18/03/2019 13:18, David Howells wrote: Andrew Price wrote: sget() is still used instead of sget_fc() as there doesn't seem to be an obvious replacement for the bdev pointer propagation to the test/set functions (yet?) Umm... What about the fs_context struct? Why can't that be used to pr

Re: [Cluster-devel] [PATCH 1/2] gfs2: Convert gfs2 to fs_context

2019-03-18 Thread David Howells
Andrew Price wrote: > sget() is still used instead of sget_fc() as there doesn't seem to be an > obvious replacement for the bdev pointer propagation to the test/set > functions (yet?) Umm... What about the fs_context struct? Why can't that be used to propagate the bdev pointer? That's kind o

[Cluster-devel] [PATCH 1/2] gfs2: Convert gfs2 to fs_context

2019-03-17 Thread Andrew Price
Switch to using fs_context ops for mount/remount. sget() is still used instead of sget_fc() as there doesn't seem to be an obvious replacement for the bdev pointer propagation to the test/set functions (yet?) Signed-off-by: Andrew Price --- fs/gfs2/incore.h | 8 +- fs/gfs2/ops_fstype.c |