Re: [Cluster-devel] [PATCH 11/34] iomap: move IOMAP_F_BOUNDARY to gfs2

2018-05-30 Thread Andreas Gruenbacher
On 30 May 2018 at 12:12, Steven Whitehouse wrote: > Hi, > > On 30/05/18 11:10, Christoph Hellwig wrote: >> >> On Wed, May 30, 2018 at 11:02:08AM +0100, Steven Whitehouse wrote: >>> >>> In that case, maybe it would be simpler to drop it for GFS2. Unless we >>> are getting a lot of benefit from it,

Re: [Cluster-devel] [PATCH 11/34] iomap: move IOMAP_F_BOUNDARY to gfs2

2018-05-30 Thread Steven Whitehouse
Hi, On 30/05/18 11:10, Christoph Hellwig wrote: On Wed, May 30, 2018 at 11:02:08AM +0100, Steven Whitehouse wrote: In that case,  maybe it would be simpler to drop it for GFS2. Unless we are getting a lot of benefit from it, then we should probably just follow the generic pattern here. Eventua

Re: [Cluster-devel] [PATCH 11/34] iomap: move IOMAP_F_BOUNDARY to gfs2

2018-05-30 Thread Christoph Hellwig
On Wed, May 30, 2018 at 11:02:08AM +0100, Steven Whitehouse wrote: > In that case,  maybe it would be simpler to drop it for GFS2. Unless we > are getting a lot of benefit from it, then we should probably just follow > the generic pattern here. Eventually we'll move everything to iomap, so > tha

Re: [Cluster-devel] [PATCH 11/34] iomap: move IOMAP_F_BOUNDARY to gfs2

2018-05-30 Thread Steven Whitehouse
Hi, On 30/05/18 10:59, Christoph Hellwig wrote: On Wed, May 30, 2018 at 10:30:32AM +0100, Steven Whitehouse wrote: I may have missed the context here, but I thought that the boundary was a generic thing meaning "there will have to be a metadata read before more blocks can be mapped" so I'm not

Re: [Cluster-devel] [PATCH 11/34] iomap: move IOMAP_F_BOUNDARY to gfs2

2018-05-30 Thread Christoph Hellwig
On Wed, May 30, 2018 at 10:30:32AM +0100, Steven Whitehouse wrote: > I may have missed the context here, but I thought that the boundary was a > generic thing meaning "there will have to be a metadata read before more > blocks can be mapped" so I'm not sure why that would now be GFS2 specific? I

Re: [Cluster-devel] [PATCH 11/34] iomap: move IOMAP_F_BOUNDARY to gfs2

2018-05-30 Thread Steven Whitehouse
Hi, On 30/05/18 06:50, Darrick J. Wong wrote: On Wed, May 23, 2018 at 04:43:34PM +0200, Christoph Hellwig wrote: Just define a range of fs specific flags and use that in gfs2 instead of exposing this internal flag flobally. Signed-off-by: Christoph Hellwig Looks ok to me, but better if the

Re: [Cluster-devel] [PATCH 11/34] iomap: move IOMAP_F_BOUNDARY to gfs2

2018-05-29 Thread Darrick J. Wong
On Wed, May 23, 2018 at 04:43:34PM +0200, Christoph Hellwig wrote: > Just define a range of fs specific flags and use that in gfs2 instead of > exposing this internal flag flobally. > > Signed-off-by: Christoph Hellwig Looks ok to me, but better if the gfs2 folks [cc'd now] ack this... Reviewed-