On Thu, Feb 17, 2022 at 01:36:44AM +0100, Andreas Gruenbacher wrote:
> On Wed, Feb 16, 2022 at 5:16 PM Alexander Aring wrote:
> > > > - spin_lock(&ops_lock);
> > > > - if (!list_empty(&op->list)) {
> > > > - log_error(ls, "dlm_posix_lock: op on list %llx",
> > > > -
On Thu, Feb 17, 2022 at 3:03 PM Alexander Aring wrote:
> On Wed, Feb 16, 2022 at 7:41 PM Andreas Gruenbacher
> wrote:
> >
> > There's also an unnecessary INIT_LIST_HEAD() in send_op().
> >
>
> please send a patch in a form which makes it easy to apply. Also
> please explain exactly why an "INIT_
Hi,
On Wed, Feb 16, 2022 at 7:41 PM Andreas Gruenbacher wrote:
>
> There's also an unnecessary INIT_LIST_HEAD() in send_op().
>
please send a patch in a form which makes it easy to apply. Also
please explain exactly why an "INIT_LIST_HEAD()" is not needed here
rather than just stating that the i
Hi,
On Wed, Feb 16, 2022 at 7:37 PM Andreas Gruenbacher wrote:
>
> On Wed, Feb 16, 2022 at 5:16 PM Alexander Aring wrote:
> >
> > Hi,
> >
> > On Wed, Feb 16, 2022 at 11:08 AM Andreas Gruenbacher
> > wrote:
> > >
> > > On Wed, Feb 16, 2022 at 4:53 PM Alexander Aring
> > > wrote:
> > > > There
There's also an unnecessary INIT_LIST_HEAD() in send_op().
Andreas
---
fs/dlm/plock.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/dlm/plock.c b/fs/dlm/plock.c
index ce1af7986e16..ff439d780cb1 100644
--- a/fs/dlm/plock.c
+++ b/fs/dlm/plock.c
@@ -67,7 +67,6 @@ static void dlm_release_plo
On Wed, Feb 16, 2022 at 5:16 PM Alexander Aring wrote:
>
> Hi,
>
> On Wed, Feb 16, 2022 at 11:08 AM Andreas Gruenbacher
> wrote:
> >
> > On Wed, Feb 16, 2022 at 4:53 PM Alexander Aring wrote:
> > > There are several sanity checks and recover handling if they occur in
> > > the dlm plock handling
Hi,
On Wed, Feb 16, 2022 at 11:25 AM Alexander Aring wrote:
>
> Hi,
>
> On Wed, Feb 16, 2022 at 11:16 AM Alexander Aring wrote:
> >
> > Hi,
> >
> > On Wed, Feb 16, 2022 at 11:08 AM Andreas Gruenbacher
> > wrote:
> > >
> > > On Wed, Feb 16, 2022 at 4:53 PM Alexander Aring
> > > wrote:
> > > >
Hi,
On Wed, Feb 16, 2022 at 11:16 AM Alexander Aring wrote:
>
> Hi,
>
> On Wed, Feb 16, 2022 at 11:08 AM Andreas Gruenbacher
> wrote:
> >
> > On Wed, Feb 16, 2022 at 4:53 PM Alexander Aring wrote:
> > > There are several sanity checks and recover handling if they occur in
> > > the dlm plock ha
Hi,
On Wed, Feb 16, 2022 at 11:08 AM Andreas Gruenbacher
wrote:
>
> On Wed, Feb 16, 2022 at 4:53 PM Alexander Aring wrote:
> > There are several sanity checks and recover handling if they occur in
> > the dlm plock handling. They should never occur otherwise we have a bug
> > in the code. To mak
On Wed, Feb 16, 2022 at 4:53 PM Alexander Aring wrote:
> There are several sanity checks and recover handling if they occur in
> the dlm plock handling. They should never occur otherwise we have a bug
> in the code. To make such bugs more visible we remove the recover
> handling and add a WARN_ON(
There are several sanity checks and recover handling if they occur in
the dlm plock handling. They should never occur otherwise we have a bug
in the code. To make such bugs more visible we remove the recover
handling and add a WARN_ON() on those sanity checks.
Signed-off-by: Alexander Aring
---
11 matches
Mail list logo