Re: [Cluster-devel] [PATCH v5 00/12] gfs2: Fix mmap + page fault deadlocks

2021-08-19 Thread Andreas Gruenbacher
On Thu, Aug 19, 2021 at 10:14 PM Linus Torvalds wrote: > On Thu, Aug 19, 2021 at 12:41 PM Andreas Gruenbacher > wrote: > > > > Hmm, what if GUP is made to skip VM_IO vmas without adding anything to > > the pages array? That would match fault_in_iov_iter_writeable, which > > is modeled after __mm_

Re: [Cluster-devel] [PATCH v5 00/12] gfs2: Fix mmap + page fault deadlocks

2021-08-19 Thread Linus Torvalds
On Thu, Aug 19, 2021 at 12:41 PM Andreas Gruenbacher wrote: > > Hmm, what if GUP is made to skip VM_IO vmas without adding anything to > the pages array? That would match fault_in_iov_iter_writeable, which > is modeled after __mm_populate and which skips VM_IO and VM_PFNMAP > vmas. I don't unders

Re: [Cluster-devel] [PATCH v5 00/12] gfs2: Fix mmap + page fault deadlocks

2021-08-19 Thread Andreas Gruenbacher
On Wed, Aug 18, 2021 at 11:49 PM Linus Torvalds wrote: > [ Sorry for the delay, I was on the road and this fell through the cracks ] No harm done, I was busy enough implementing your previous suggestions. > On Mon, Aug 16, 2021 at 12:14 PM Andreas Gruenbacher > wrote: > > > > On Tue, Aug 3, 202

Re: [Cluster-devel] [PATCH v5 00/12] gfs2: Fix mmap + page fault deadlocks

2021-08-18 Thread Linus Torvalds
[ Sorry for the delay, I was on the road and this fell through the cracks ] On Mon, Aug 16, 2021 at 12:14 PM Andreas Gruenbacher wrote: > > On Tue, Aug 3, 2021 at 9:45 PM Linus Torvalds > wrote: > > > > Hmm. Have you tried to figure out why that "still returns 0" happens? > > The call stack is:

Re: [Cluster-devel] [PATCH v5 00/12] gfs2: Fix mmap + page fault deadlocks

2021-08-16 Thread Andreas Gruenbacher
On Tue, Aug 3, 2021 at 9:45 PM Linus Torvalds wrote: > On Tue, Aug 3, 2021 at 12:18 PM Andreas Gruenbacher > wrote: > > With this patch queue, fstest generic/208 (aio-dio-invalidate-failure.c) > > endlessly spins in gfs2_file_direct_write. It looks as if there's a bug > > in get_user_pages_fast

Re: [Cluster-devel] [PATCH v5 00/12] gfs2: Fix mmap + page fault deadlocks

2021-08-03 Thread Linus Torvalds
On Tue, Aug 3, 2021 at 12:18 PM Andreas Gruenbacher wrote: > > > With this patch queue, fstest generic/208 (aio-dio-invalidate-failure.c) > endlessly spins in gfs2_file_direct_write. It looks as if there's a bug > in get_user_pages_fast when called with FOLL_FAST_ONLY: > > (1) The test case perf

[Cluster-devel] [PATCH v5 00/12] gfs2: Fix mmap + page fault deadlocks

2021-08-03 Thread Andreas Gruenbacher
Hi all, here's another update on top of v5.14-rc4. There seems to be a bug in get_user_pages_fast when called with FOLL_FAST_ONLY; please see below. Changes: * Change fault_in_pages_{readable,writeable} to return the number of bytes that should be accessible instead of failing outright when