Re: [Cluster-devel] [PATCH v6 04/16] mm: Tweak readahead loop slightly

2020-02-18 Thread John Hubbard
On 2/18/20 2:57 PM, John Hubbard wrote: > On 2/17/20 10:45 AM, Matthew Wilcox wrote: >> From: "Matthew Wilcox (Oracle)" >> >> Eliminate the page_offset variable which was just confusing; >> record the start of each consecutive run of pages in the > > Darn it, I incorrectly reviewed the N/16

Re: [Cluster-devel] [PATCH v6 04/16] mm: Tweak readahead loop slightly

2020-02-18 Thread John Hubbard
On 2/17/20 10:45 AM, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > > Eliminate the page_offset variable which was just confusing; > record the start of each consecutive run of pages in the OK...presumably for the benefit of a following patch, since it is not actually consumed in

[Cluster-devel] [PATCH v6 04/16] mm: Tweak readahead loop slightly

2020-02-17 Thread Matthew Wilcox
From: "Matthew Wilcox (Oracle)" Eliminate the page_offset variable which was just confusing; record the start of each consecutive run of pages in the readahead_control, and move the 'kick off a fresh batch' code to the end of the function for easier use in the next patch. Signed-off-by: Matthew