[Cluster-devel] [PATCH v7 11/24] mm: Move end_index check out of readahead loop

2020-02-19 Thread Matthew Wilcox
From: "Matthew Wilcox (Oracle)" By reducing nr_to_read, we can eliminate this check from inside the loop. Signed-off-by: Matthew Wilcox (Oracle) --- mm/readahead.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/mm/readahead.c b/mm/readahead.c index 07cdfbf0

Re: [Cluster-devel] [PATCH v7 11/24] mm: Move end_index check out of readahead loop

2020-02-20 Thread John Hubbard
On 2/19/20 1:00 PM, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > > By reducing nr_to_read, we can eliminate this check from inside the loop. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > mm/readahead.c | 15 +-- > 1 file changed, 9 insertions(+), 6 deletions(-) >

Re: [Cluster-devel] [PATCH v7 11/24] mm: Move end_index check out of readahead loop

2020-02-21 Thread Matthew Wilcox
On Thu, Feb 20, 2020 at 07:50:39PM -0800, John Hubbard wrote: > This tiny patch made me pause, because I wasn't sure at first of the exact > intent of the lines above. Once I worked it out, it seemed like it might > be helpful (or overkill??) to add a few hints for the reader, especially since > th

Re: [Cluster-devel] [PATCH v7 11/24] mm: Move end_index check out of readahead loop

2020-02-21 Thread John Hubbard
On 2/21/20 7:35 AM, Matthew Wilcox wrote: On Thu, Feb 20, 2020 at 07:50:39PM -0800, John Hubbard wrote: This tiny patch made me pause, because I wasn't sure at first of the exact intent of the lines above. Once I worked it out, it seemed like it might be helpful (or overkill??) to add a few hint