Re: [Cluster-devel] [PATCH v9 12/25] mm: Move end_index check out of readahead loop

2020-03-22 Thread Matthew Wilcox
On Fri, Mar 20, 2020 at 11:24:52AM -0700, Eric Biggers wrote: > On Fri, Mar 20, 2020 at 11:11:32AM -0700, Matthew Wilcox wrote: > > On Fri, Mar 20, 2020 at 11:00:17AM -0700, Eric Biggers wrote: > > > But then if someone passes index=0 and nr_to_read=0, this underflows and > > > the > > > entire

Re: [Cluster-devel] [PATCH v9 12/25] mm: Move end_index check out of readahead loop

2020-03-20 Thread Eric Biggers
On Fri, Mar 20, 2020 at 11:11:32AM -0700, Matthew Wilcox wrote: > On Fri, Mar 20, 2020 at 11:00:17AM -0700, Eric Biggers wrote: > > On Fri, Mar 20, 2020 at 10:30:40AM -0700, Matthew Wilcox wrote: > > > On Fri, Mar 20, 2020 at 09:58:28AM -0700, Eric Biggers wrote: > > > > On Fri, Mar 20, 2020 at

Re: [Cluster-devel] [PATCH v9 12/25] mm: Move end_index check out of readahead loop

2020-03-20 Thread Matthew Wilcox
On Fri, Mar 20, 2020 at 11:00:17AM -0700, Eric Biggers wrote: > On Fri, Mar 20, 2020 at 10:30:40AM -0700, Matthew Wilcox wrote: > > On Fri, Mar 20, 2020 at 09:58:28AM -0700, Eric Biggers wrote: > > > On Fri, Mar 20, 2020 at 07:22:18AM -0700, Matthew Wilcox wrote: > > > > + /* Avoid wrapping

Re: [Cluster-devel] [PATCH v9 12/25] mm: Move end_index check out of readahead loop

2020-03-20 Thread Eric Biggers
On Fri, Mar 20, 2020 at 10:30:40AM -0700, Matthew Wilcox wrote: > On Fri, Mar 20, 2020 at 09:58:28AM -0700, Eric Biggers wrote: > > On Fri, Mar 20, 2020 at 07:22:18AM -0700, Matthew Wilcox wrote: > > > + /* Avoid wrapping to the beginning of the file */ > > > + if (index + nr_to_read < index) > >

Re: [Cluster-devel] [PATCH v9 12/25] mm: Move end_index check out of readahead loop

2020-03-20 Thread Eric Biggers
On Fri, Mar 20, 2020 at 07:22:18AM -0700, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > > By reducing nr_to_read, we can eliminate this check from inside the loop. > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: John Hubbard > Reviewed-by: William Kucharski > --- >

[Cluster-devel] [PATCH v9 12/25] mm: Move end_index check out of readahead loop

2020-03-20 Thread Matthew Wilcox
From: "Matthew Wilcox (Oracle)" By reducing nr_to_read, we can eliminate this check from inside the loop. Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: John Hubbard Reviewed-by: William Kucharski --- mm/readahead.c | 17 +++-- 1 file changed, 11 insertions(+), 6