Re: [CMake] Good practice: using INTERFACE-libraries in FindABC.cmake?

2016-03-01 Thread Patrick Boettcher
On Mon, 29 Feb 2016 21:20:59 +0100 Stephen Kelly wrote: > Patrick Boettcher wrote: > > > I came across the INTERFACE-type of libraries when writing a > > FindModule.cmake-file for custom libraries installed by my > > project. > > You don't provide FindModules for your

[CMake] Visual Studio and ExternalProject_Add

2016-03-01 Thread Kevin Brightwell
I've been having great success with using ExternalProject over the terrible git submodules. However, when using Visual Studio, the following error happens: Performing download step (git clone) for 'catch-lib' 2> Cloning into 'catch-lib'... 2> Note: checking out 'tags/v1.3.4'. 2> 2> You are in

[cmake-developers] [CMake 0015998]: Add variable to cmake in order to decide whether building is for android

2016-03-01 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == https://cmake.org/Bug/view.php?id=15998 == Reported By:huiyiqun Assigned To:

[Cmake-commits] CMake branch, master, updated. v3.5.0-rc3-156-g8913ccc

2016-03-01 Thread Kitware Robot
_VERSION_MINOR 5) -set(CMake_VERSION_PATCH 20160301) +set(CMake_VERSION_PATCH 20160302) #set(CMake_VERSION_RC 1) --- Summary of changes: Source/CMakeVersion.cmake |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/

[cmake-developers] [CMake 0015997]: CMake 3.5 fails to build on OS X with GTK framework installed

2016-03-01 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == https://public.kitware.com/Bug/view.php?id=15997 == Reported By:Andrew.W Assigned To:

[CMake] best way of parsing test results from ctest + valgrind

2016-03-01 Thread Aaron Boxer
Hello, I am just getting started on using valgrind memory analysis for my tests. When I run ctest with nightly memory check, I get an XML document, but it is very hard to read the results. What is the best way of reading this doc? Thanks! Aaron -- Powered by www.kitware.com Please keep

[Cmake-commits] CMake branch, next, updated. v3.5.0-rc3-317-gc3f20a8

2016-03-01 Thread Clinton Stimpson
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "CMake". The branch, next has been updated via c3f20a8861467bdf85322b184cf060c822d3b2c8 (commit) via

Re: [cmake-developers] CMakeFindDependencyMacro limitations

2016-03-01 Thread Roger Leigh
On 24/02/2016 22:49, Roger Leigh wrote: I've attached a patch for a very simple modification to find_dependency. I'm not proposing that it be merged, it's just a suggestion for further discussion. I've tested it with my own packages with multiple find_dependency(Boost COMPONENTS ...) calls.

[cmake-developers] Proposed patch for 0014140: Ninja generator doesn't set version in dylib

2016-03-01 Thread Bruce Stephens
I just copied the relevant code from the Makefiles generator. (And now I find gmail doesn't let me change the properties of the attachment. Bother.) 0001-Copy-logic-for-OS-X-dylib-versioning-to-Ninja-genera.patch Description: Binary data -- Powered by www.kitware.com Please keep messages

Re: [cmake-developers] C# support ready for review

2016-03-01 Thread Robert Goulet
Adding test cases to the CMake source is most likely required. But that's probably much more involving than just writing a test case for one feature. As for testing C# support, we only have one C# solution in our entire code base, so that wouldn't represent a good validation of the possible

Re: [cmake-developers] FindBOOST 3.5 target

2016-03-01 Thread Nils Gladitz
On 01.03.2016 18:09, Henry Schreiner wrote: On FindBoost.cmake (and maybe others), the new (in 3.5) targets populate the INTERFACE_INCLUDE_DIRECTORIES directory. Shouldn’t this be the INTERFACE_SYSTEM_INCLUDE_DIRECTORIES field? Since that way CMake can help keep Xcode and other IDE’s from

[cmake-developers] FindBOOST 3.5 target

2016-03-01 Thread Henry Schreiner
On FindBoost.cmake (and maybe others), the new (in 3.5) targets populate the INTERFACE_INCLUDE_DIRECTORIES directory. Shouldn’t this be the INTERFACE_SYSTEM_INCLUDE_DIRECTORIES field? Since that way CMake can help keep Xcode and other IDE’s from claiming you have warnings in boost, etc. Henry

Re: [CMake] CMAKE_THREAD_LIBS_INIT

2016-03-01 Thread Aaron Boxer
OK, figured this one out too. Thank again, Caleb! On Tue, Mar 1, 2016 at 10:48 AM, Aaron Boxer wrote: > Hello, > I am getting link error "undefined reference to pthread_create" > > I have added ${CMAKE_THREAD_LIBS_INIT} in my cmake link line, > and I have added > >

[CMake] CMAKE_THREAD_LIBS_INIT

2016-03-01 Thread Aaron Boxer
Hello, I am getting link error "undefined reference to pthread_create" I have added ${CMAKE_THREAD_LIBS_INIT} in my cmake link line, and I have added FIND_PACKAGE(Threads REQUIRED). Here is a link to my cmake file:

Re: [CMake] CMAKE_DL_LIBS

2016-03-01 Thread Aaron Boxer
Thanks! I found the problem: I needed to add CMAKE_DL_LIBS to another static library that the main exe was linking to. Now this link error is gone. On Tue, Mar 1, 2016 at 9:55 AM, J. Caleb Wherry wrote: > That link looks fine to me. You might want to verify that the >

[cmake-developers] [CMake 0015996]: Unable to zip files with CMake command-line tool `tar` without path prefix in zip file

2016-03-01 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == https://cmake.org/Bug/view.php?id=15996 == Reported By:Marcel Metz Assigned To:

Re: [CMake] CMAKE_DL_LIBS

2016-03-01 Thread J. Caleb Wherry
That link looks fine to me. You might want to verify that the CMAKE_DL_LIBS variable actually contains what it should on your system (or a least contains what it should right before using it). You could explicitly add the "-dl" to that link statement and see if that works. That's what that

Re: [CMake] CMAKE_DL_LIBS

2016-03-01 Thread J. Caleb Wherry
Most likely solution: missing the "-ldl" link lib which should solve your missing symbol issues. The DSO error is most likely caused by the above. However, there could be a problem with your linking order. I'd have to see the CMake file to be sure. Caleb On Tuesday, March 1, 2016, Aaron Boxer

[CMake] CMAKE_DL_LIBS

2016-03-01 Thread Aaron Boxer
Hello! I have a CMAKE project that creates an executable that links with a static lib from a second CMAKE project. The static lib requires the dlopen and dlclose symbols. So, when I link the first project, I add ${CMAKE_DL_LIBS} to the CMake file. However, I still get an error about "undefined

Re: [CMake] CMAKE_DL_LIBS

2016-03-01 Thread Aaron Boxer
On Tue, Mar 1, 2016 at 9:06 AM, Aaron Boxer wrote: > Hello! > I have a CMAKE project that creates an executable that links with a static > lib > from a second CMAKE project. The static lib requires the dlopen and dlclose > symbols. > > So, when I link the first project, I add

[cmake-developers] [CMake 0015995]: GHS Multi Generator: add_custom_command / add_custom_target does not work

2016-03-01 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == https://cmake.org/Bug/view.php?id=15995 == Reported By:stw_sesa Assigned To:

[Cmake-commits] CMake branch, next, updated. v3.5.0-rc3-315-gcc20b98

2016-03-01 Thread Nils Gladitz
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "CMake". The branch, next has been updated via cc20b98859ecfaafe607d2bc2075ef71dde4a07d (commit) via

Re: [cmake-developers] C# support ready for review

2016-03-01 Thread Stuermer, Michael SP/HZA-ZSEP
Ok, this leads me to the question: what is needed/missing for acceptance to 'master'? More Documentation? More Tests? What features have to be provided by the module scripts? Probably some code formatting (I surely missed some indentation stuff and tabs instead of spaces)... I am currently

[cmake-developers] [PATCH] FindProtobuf: variable case matches module name

2016-03-01 Thread Antonio Perez Barrero
Use recommended case for variable names. i.e. matching name of the module as passed to `find_package`. For backwards compatibility, the upper case versions of both input and output variables are used and defined when appropriate. --- Modules/FindProtobuf.cmake| 179