Re: [CMake] CMake + Gradle for Android

2017-08-25 Thread Jom O'Fisher
Hi again Robert, Would you be able to give me an estimate of how many APK projects you have, roughly which open source projects you reference via CMake add_subdirectories, and whether you have any variants beyond the default Debug and Release? If possible I'd like to approximate your project layout

Re: [CMake] CMake + Gradle for Android

2017-08-25 Thread Jom O'Fisher
Targets are specified per-Variation so they need to go under the variation-specific section. Probably something like this: defaultConfig { externalNativeBuild { cmake { targets "library1", "

Re: [CMake] CMake + Gradle for Android

2017-08-25 Thread Robert Dailey
By the way when I try to use "targets", I get a failure. Basically Gradle doesn't recognize that keyword. I tried singular form as well ("target"), no luck. I'm running canary build of everything possible. What am I missing? On Wed, Aug 23, 2017 at 4:20 PM, Jom O'Fisher wrote: > By gradle module

Re: [CMake] Should configuration package files define module package variables?

2017-08-25 Thread Robert Dailey
Doh, forgot the links I intended to reference in my original email: [1]: https://cmake.org/cmake/help/v3.6/command/find_package.html [2]: https://cmake.org/cmake/help/v3.6/manual/cmake-packages.7.html#creating-packages [3]: https://cmake.org/cmake/help/v3.6/module/CMakePackageConfigHelpers.html

[CMake] Should configuration package files define module package variables?

2017-08-25 Thread Robert Dailey
So I've been studying the find_package[1] and "creating packages"[2] documentation, as well as the CMakePackageConfigHelpers[3] page. Based on the current offerings of configuration packages, I do not understand the need for the relocatable config.cmake file when all it really contains is: includ

Re: [CMake] Please update the documentation for execute_process

2017-08-25 Thread Andreas Naumann
Am 25.08.2017 um 16:12 schrieb Jeffrey Walton: Below is a typical case for us (https://github.com/weidai11/cryptopp/blob/master/CMakeLists.txt). If it looks pretty shitty, it probably is. That's the best we have been able to come up with based on the documentation. Below is the example code. We

Re: [CMake] Please update the documentation for execute_process

2017-08-25 Thread Jeffrey Walton
> Below is a typical case for us > (https://github.com/weidai11/cryptopp/blob/master/CMakeLists.txt). If > it looks pretty shitty, it probably is. That's the best we have been > able to come up with based on the documentation. Below is the example code. We don't know whether it should be: set(SHE

[CMake] Please update the documentation for execute_process

2017-08-25 Thread Jeffrey Walton
The documentation for execute_process has some room for improvement. We recently got burned by a problem that has existed since at least 2011: https://stackoverflow.com/q/6797395/608639 . Once we learned the problem we could research a bit. The problem cost us over 8 man hours when it should not h

Re: [CMake] 'cmake.exe -G Ninja' doesn't work for VS2017 with cmake ver 3.9.1

2017-08-25 Thread Masaru Tsuchiyama
Hello I confirmed this is fixed. I used 9538d22d955a0b101548019003f2d5c7ba833d77 for the check. Brad King wrote: On 08/23/2017 05:07 AM, masaru tsuchiyama wrote: It seems your coworker can reproduce it and you can use the PC tomorrow. So I don't need to debug it, right? Correct, thanks. See