Re: [CMake] CMake Coverage broken with Ninja

2017-09-05 Thread Brad King
On 09/05/2017 07:42 AM, Gerhard Gappmeier wrote: > Could you already verify if this problem is also the cause for the > coverage issue? I tried your example in a fully out-of-source build (where the build tree is not inside the source tree), and coverage works. -Brad -- Powered by www.kitware.c

Re: [CMake] CMake Coverage broken with Ninja

2017-09-05 Thread Gerhard Gappmeier
Hi Brad, thanks for that information. It is great to see that you are working on this. Could you already verify if this problem is also the cause for the coverage issue? On 09/05/2017 01:31 PM, Brad King wrote: > On 09/02/2017 03:14 AM, Gerhard Gappmeier wrote: >> This is quite annoying, inconsi

Re: [CMake] CMake Coverage broken with Ninja

2017-09-05 Thread Brad King
On 09/02/2017 03:14 AM, Gerhard Gappmeier wrote: > This is quite annoying, inconsistent with Makefiles and was already > reported once here: https://cmake.org/Bug/print_bug_page.php?bug_id=13894 > AFAIK this was never fixed. Discussion of that issue is now here: https://gitlab.kitware.com/cmake

Re: [CMake] CMake Coverage broken with Ninja

2017-09-02 Thread Gerhard Gappmeier
Hi Haocheng, thanks for helping. I guess this has to do with another issue. The Ninja generator generates different paths then the default Unix Makefile generator. This leads to the following behavior in normal build operations: I introduced a warning in the printf line to demonstrate this. With

Re: [CMake] CMake Coverage broken with Ninja

2017-09-01 Thread Haocheng Liu
On Fri, Sep 1, 2017 at 9:41 AM, Gerhard Gappmeier < gerhard.gappme...@ascolab.com> wrote: > Hi Haocheng, > > `chcp` seems to be a Windows command. > I'm talking about Linux, which is UTF-8 by default: > > $> locale > LANG=en_US.utf8 > LC_CTYPE="en_US.utf8" > LC_NUMERIC="en_US.utf8" > LC_TIME="en_U

Re: [CMake] CMake Coverage broken with Ninja

2017-09-01 Thread Gerhard Gappmeier
Hi Haocheng, `chcp` seems to be a Windows command. I'm talking about Linux, which is UTF-8 by default: $> locale LANG=en_US.utf8 LC_CTYPE="en_US.utf8" LC_NUMERIC="en_US.utf8" LC_TIME="en_US.utf8" LC_COLLATE="en_US.utf8" LC_MONETARY="en_US.utf8" LC_MESSAGES="en_US.utf8" LC_PAPER="en_US.utf8" LC_NA

Re: [CMake] CMake Coverage broken with Ninja

2017-09-01 Thread Haocheng Liu
Hi Gerhard, On Fri, Sep 1, 2017 at 7:26 AM, Gerhard Gappmeier < gerhard.gappme...@ascolab.com> wrote: > hi all, > > just recently I discovered that our coverage builds on CDash don't work > anymore. > By analyzing the problem I found out that this is related to Ninja > generator. > I don't know w

[CMake] CMake Coverage broken with Ninja

2017-09-01 Thread Gerhard Gappmeier
hi all, just recently I discovered that our coverage builds on CDash don't work anymore. By analyzing the problem I found out that this is related to Ninja generator. I don't know when the problem was introduced but it still exists with CMake 3.9.1. (GCC and gcov are version 4.9.4, but this is not