Re: [CMake] CMakeDetermineVSServicePack (was: CMake 3.0-rc3 now ready for testing)

2014-04-10 Thread Mourad Boufarguine
On 04/09/2014 07:39 AM, Mourad Boufarguine wrote: CMake Error at D:/Program Files (x86)/CMake/share/cmake-3.0/Modules/CMakeDetermineVSServicePack.cmake:140 (list): list index: 3 out of range (-3, 2) [snip] content of the _cl_version variable and it gave me 17.00.61030 so there is no 4th

Re: [CMake] CMakeDetermineVSServicePack

2014-04-10 Thread Brad King
On 04/10/2014 04:19 AM, Mourad Boufarguine wrote: I just tried with CMake 2.8.12.2 and I confirm I had the same issue. Okay, then it is not a regression in 3.0 but still needs to be fixed. Microsoft (R) C/C++ Optimizing *Compiler Version 17.00.61030* for x64 That is a higher third component

Re: [CMake] CMakeDetermineVSServicePack

2014-04-10 Thread Mourad Boufarguine
Microsoft (R) C/C++ Optimizing *Compiler Version 17.00.61030* for x64 That is a higher third component value than CMakeDetermineVSServicePack has for vc110sp3 (17.00.60610.1). What service pack level is it? Microsoft talks about Updates rather than Service Packs for Visual Studio 2012. I

Re: [CMake] CMakeDetermineVSServicePack

2014-04-10 Thread Brad King
On 04/10/2014 11:53 AM, Mourad Boufarguine wrote: I have Update 4 (which is as old as Nov 12, 2013) I installed that, thanks. I gave the patch a try, I had no more errors Great. I've applied the following changes to fix this: CMakeDetermineVSServicePack: Format documentation

Re: [CMake] CMakeDetermineVSServicePack (was: CMake 3.0-rc3 now ready for testing)

2014-04-09 Thread Brad King
On 04/09/2014 07:39 AM, Mourad Boufarguine wrote: CMake Error at D:/Program Files (x86)/CMake/share/cmake-3.0/Modules/CMakeDetermineVSServicePack.cmake:140 (list): list index: 3 out of range (-3, 2) [snip] content of the _cl_version variable and it gave me 17.00.61030 so there is no 4th