Re: [CMake] Contribute Find-module to CMake vs Config-file to upstream

2018-05-24 Thread Paul Fultz II via CMake
> On May 24, 2018, at 8:07 AM, Brad King wrote: > > On 05/22/2018 10:06 PM, Paul Fultz II wrote: >> Or pkg-config could be extended to fix the issues. > > The `.pc` file format is too flat to lend itself well to representing > all the information we need. What do you mean? What information c

Re: [CMake] Contribute Find-module to CMake vs Config-file to upstream

2018-05-24 Thread Brad King
On 05/22/2018 10:06 PM, Paul Fultz II wrote: > Or pkg-config could be extended to fix the issues. The `.pc` file format is too flat to lend itself well to representing all the information we need. A goal of `.cps` files is to teach pkg-config to parse them and respond to its standard queries with

Re: [CMake] Contribute Find-module to CMake vs Config-file to upstream

2018-05-24 Thread Mateusz Loskot
On 24 May 2018 at 08:45, Elvis Stansvik wrote: > Den ons 23 maj 2018 17:18Mateusz Loskot skrev: >> On 23 May 2018 at 16:37, David Demelier wrote: >> > On Mon, 2018-05-21 at 19:39 +0200, Mateusz Loskot wrote: >> >> >> >> >> >> IMHO, CMake should encourage contributions of new Find-modules. >> > >

Re: [CMake] Contribute Find-module to CMake vs Config-file to upstream

2018-05-23 Thread Elvis Stansvik
Den ons 23 maj 2018 17:18Mateusz Loskot skrev: > On 23 May 2018 at 16:37, David Demelier wrote: > > On Mon, 2018-05-21 at 19:39 +0200, Mateusz Loskot wrote: > >> > >> I've been recently trying to update/add Find-modules to CMake: > >> updated FindJPEG, proposed FindODBC and most recently FindLZ4

Re: [CMake] Contribute Find-module to CMake vs Config-file to upstream

2018-05-23 Thread Mateusz Loskot
On 23 May 2018 at 16:37, David Demelier wrote: > On Mon, 2018-05-21 at 19:39 +0200, Mateusz Loskot wrote: >> >> I've been recently trying to update/add Find-modules to CMake: >> updated FindJPEG, proposed FindODBC and most recently FindLZ4. >> >> Discussion during review of the FindLZ4 [1] ended w

Re: [CMake] Contribute Find-module to CMake vs Config-file to upstream

2018-05-23 Thread David Demelier
On Mon, 2018-05-21 at 19:39 +0200, Mateusz Loskot wrote: > Hi, > > I've been recently trying to update/add Find-modules to CMake: > updated FindJPEG, proposed FindODBC and most recently FindLZ4. > > Discussion during review of the FindLZ4 [1] ended with some > surprising > conclusions which I, as

Re: [CMake] Contribute Find-module to CMake vs Config-file to upstream

2018-05-23 Thread Johannes Zarl-Zierl
On Dienstag, 22. Mai 2018 11:13:18 CEST Brad King wrote: > > not be much more work for the maintainer as pkg-config files. > > There is a proposal here: > > https://mwoehlke.github.io/cps/ This looks quite promising! Do you know whether there's a shared interest on the pkg-config and autotools

Re: [CMake] Contribute Find-module to CMake vs Config-file to upstream

2018-05-22 Thread Paul Fultz II via CMake
> On May 22, 2018, at 10:13 AM, Brad King wrote: > > On 05/22/2018 06:27 AM, Johannes Zarl-Zierl wrote: >> There's more that we (as CMake community) could do to make it easier for non- >> cmake projects to add a config file... > [snip] >> not be much more work for the maintainer as pkg-config fi

Re: [CMake] Contribute Find-module to CMake vs Config-file to upstream

2018-05-22 Thread Paul Fultz II via CMake
> On May 22, 2018, at 6:36 AM, rle...@codelibre.net wrote: > > On 2018-05-21 18:39, Mateusz Loskot wrote: >> I've been recently trying to update/add Find-modules to CMake: >> updated FindJPEG, proposed FindODBC and most recently FindLZ4. > […] >> The FindLZ4 discussion basically ended with sugges

Re: [CMake] Contribute Find-module to CMake vs Config-file to upstream

2018-05-22 Thread Mateusz Loskot
On 22 May 2018 at 13:36, wrote: > On 2018-05-21 18:39, Mateusz Loskot wrote: >> >> I've been recently trying to update/add Find-modules to CMake: >> updated FindJPEG, proposed FindODBC and most recently FindLZ4. > […] >> >> The FindLZ4 discussion basically ended with suggestion from Brad that, >>

Re: [CMake] Contribute Find-module to CMake vs Config-file to upstream

2018-05-22 Thread Mateusz Loskot
On 22 May 2018 at 12:27, Johannes Zarl-Zierl wrote: > On Montag, 21. Mai 2018 19:39:16 CEST Mateusz Loskot wrote: >> The FindLZ4 discussion basically ended with suggestion from Brad that, >> instead of adding Find-module to CMake, I should approach LZ4 project >> and add Config-file to the library

Re: [CMake] Contribute Find-module to CMake vs Config-file to upstream

2018-05-22 Thread Brad King
On 05/22/2018 11:21 AM, Sergei Nikulov wrote: >>https://mwoehlke.github.io/cps/ > > When will CMake with cps support be available? The work is still in the design phase of the CPS format itself. I've added its author in Cc. -Brad -- Powered by www.kitware.com Please keep messages on-topic

Re: [CMake] Contribute Find-module to CMake vs Config-file to upstream

2018-05-22 Thread Sergei Nikulov
вт, 22 мая 2018 г. в 18:13, Brad King : > On 05/22/2018 06:27 AM, Johannes Zarl-Zierl wrote: > > There's more that we (as CMake community) could do to make it easier for non- > > cmake projects to add a config file... > [snip] > > not be much more work for the maintainer as pkg-config files. > Th

Re: [CMake] Contribute Find-module to CMake vs Config-file to upstream

2018-05-22 Thread Brad King
On 05/22/2018 06:27 AM, Johannes Zarl-Zierl wrote: > There's more that we (as CMake community) could do to make it easier for non- > cmake projects to add a config file... [snip] > not be much more work for the maintainer as pkg-config files. There is a proposal here: https://mwoehlke.github.io

Re: [CMake] Contribute Find-module to CMake vs Config-file to upstream

2018-05-22 Thread rleigh
On 2018-05-21 18:39, Mateusz Loskot wrote: I've been recently trying to update/add Find-modules to CMake: updated FindJPEG, proposed FindODBC and most recently FindLZ4. […] The FindLZ4 discussion basically ended with suggestion from Brad that, instead of adding Find-module to CMake, I should ap

Re: [CMake] Contribute Find-module to CMake vs Config-file to upstream

2018-05-22 Thread Johannes Zarl-Zierl
Hi Mateusz, On Montag, 21. Mai 2018 19:39:16 CEST Mateusz Loskot wrote: > The FindLZ4 discussion basically ended with suggestion from Brad that, > instead of adding Find-module to CMake, I should approach LZ4 project > and add Config-file to the library itself. > Then I argued taht Config-files ar

Re: [CMake] Contribute Find-module to CMake vs Config-file to upstream

2018-05-22 Thread Jorge Perez
+1 to the gitlab central repository On Mon, 21 May 2018 at 19:39, Mateusz Loskot wrote: > Hi, > > I've been recently trying to update/add Find-modules to CMake: > updated FindJPEG, proposed FindODBC and most recently FindLZ4. > > Discussion during review of the FindLZ4 [1] ended with some surpri

[CMake] Contribute Find-module to CMake vs Config-file to upstream

2018-05-21 Thread Mateusz Loskot
Hi, I've been recently trying to update/add Find-modules to CMake: updated FindJPEG, proposed FindODBC and most recently FindLZ4. Discussion during review of the FindLZ4 [1] ended with some surprising conclusions which I, as someone who relies on CMake and occacionally contributes to CMake, don't