Re: [CMake] Coverage support

2017-08-13 Thread Lectem
Tokarev Envoyé le :lundi 7 août 2017 19:52 À : Clément Gregoire; Rolf Eike Beer Cc : Cmake Mailing List Objet :Re: [CMake] Coverage support     07.08.2017, 20:50, "Clément Gregoire" : This is mainly why I started this thread, I want to know the best way to do this without using those

Re: [CMake] Coverage support

2017-08-07 Thread Konstantin Tokarev
  07.08.2017, 20:50, "Clément Gregoire" :This is mainly why I started this thread, I want to know the best way to do this without using those variables.CMAKE_lang_FLAGS is a pain as soon as someone wants to use add_subdirectory (be it to add an external project or your project being used in another

Re: [CMake] Coverage support

2017-08-07 Thread Clément Gregoire
This is mainly why I started this thread, I want to know the best way to do this without using those variables. CMAKE_lang_FLAGS is a pain as soon as someone wants to use add_subdirectory (be it to add an external project or your project being used in another) or a user wants to change the value. T

Re: [CMake] Coverage support

2017-08-07 Thread Konstantin Tokarev
07.08.2017, 17:24, "Clément Gregoire" : >> I usually stop reading Cmakelists.txt as soon as I see this >> >> set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -pedantic -pthread -g -O0 >> -fprofile-arcs -ftest-coverage") >> >> The pthread thing there is likely wrong anyway, and the -Wall is entirely

Re: [CMake] Coverage support

2017-08-07 Thread Clément Gregoire
> > I usually stop reading Cmakelists.txt as soon as I see this > > > > set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -pedantic -pthread -g -O0 > > > -fprofile-arcs -ftest-coverage") > > > > The pthread thing there is likely wrong anyway, and the -Wall is entirely > optional. The other things are n

Re: [CMake] Coverage support

2017-08-07 Thread Rolf Eike Beer
Am 2017-08-07 11:06, schrieb Clément Gregoire: I usually stop reading Cmakelists.txt as soon as I see this set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -pedantic -pthread -g -O0 -fprofile-arcs -ftest-coverage") The pthread thing there is likely wrong anyway, and the -Wall is entirely optiona

Re: [CMake] Coverage support

2017-08-07 Thread Clément Gregoire
I usually stop reading Cmakelists.txt as soon as I see this set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -pedantic -pthread -g -O0 -fprofile-arcs -ftest-coverage") Also you need to use the SETUP_TARGET_FOR_COVERAGE for every single test target, which seems to be a difficult to scale on big proje

Re: [CMake] Coverage support

2017-08-07 Thread Rolf Eike Beer
Am 2017-08-07 09:57, schrieb Clément Gregoire: Hi, I'm a bit stuck when trying to add coverage reports to Cmake (gcov + lcov) as I can't figure out what is the best (idiomatic) way to do it. So far here are the ways I know of : - setting the CMAKE_LANG_FLAGS based on a boolean + scan all files

[CMake] Coverage support

2017-08-07 Thread Clément Gregoire
Hi, I'm a bit stuck when trying to add coverage reports to Cmake (gcov + lcov) as I can't figure out what is the best (idiomatic) way to do it. So far here are the ways I know of : - setting the CMAKE_LANG_FLAGS based on a boolean + scan all files / run gcov on it : would like to avoid this - same