Re: [CMake] FindBoost: FIND_PACKAGE ( Boost COMPONENTS filesystem )

2009-11-04 Thread Michael Jackson
On Nov 4, 2009, at 1:57 PM, Mathieu Malaterre wrote: On Wed, Nov 4, 2009 at 7:50 PM, Philip Lowman wrote: Personally, I think FindBoost is complex enough without having to also keep track of boost's internal dependencies as well. Maybe things would be better if the boost people publishe

Re: [CMake] FindBoost: FIND_PACKAGE ( Boost COMPONENTS filesystem )

2009-11-04 Thread Mathieu Malaterre
On Wed, Nov 4, 2009 at 7:50 PM, Philip Lowman wrote: > Personally, I think FindBoost is complex enough without having to  also keep > track of boost's internal dependencies as well.  Maybe things would be > better if the boost people published this info with every release. I understand your point

Re: [CMake] FindBoost: FIND_PACKAGE ( Boost COMPONENTS filesystem )

2009-11-04 Thread Philip Lowman
Personally, I think FindBoost is complex enough without having to also keep track of boost's internal dependencies as well. Maybe things would be better if the boost people published this info with every release. If you'd like to check in support for the feature and volunteer to maintain it, how

Re: [CMake] FindBoost: FIND_PACKAGE ( Boost COMPONENTS filesystem )

2009-11-04 Thread Marcel Loose
Hi Philip, I've been following this thread with interest. Your solution puts the burden on the (ignorant) end-user's shoulders. How is that poor developer going to solve the pre/post version 1.34 issue, which is a Boost-internal issue? In an ideal world, Boost would provide the FindBoost.cmake fil

Re: [CMake] FindBoost: FIND_PACKAGE ( Boost COMPONENTS filesystem )

2009-11-04 Thread Philip Lowman
Mathieu, It's a nice idea, but given that Boost could make any one of its libraries dependent on "system" at any time they want in the future (and for all I know there are others already dependent on it, besides wave and filesystem), I'd rather the user be responsible for adding "system" manually.

Re: [CMake] FindBoost: FIND_PACKAGE ( Boost COMPONENTS filesystem )

2009-11-04 Thread Mathieu Malaterre
Philip, I guess I was not very clear in my previous email. But here is my proposed change: @@ -322,8 +322,14 @@ if(Boost_VERSION AND Boost_FIND_COMPONENTS) math(EXPR _boost_maj "${Boost_VERSION} / 10") math(EXPR _boost_min "${Boost_VERSION} / 100 % 1000") - if(${_boost_ma

Re: [CMake] FindBoost: FIND_PACKAGE ( Boost COMPONENTS filesystem )

2009-11-03 Thread Mathieu Malaterre
The way I see it to address is that 'system' is an internal details (AFAIK). It should be automatically pulled in for filesystem and wave (for boost > 1.34), instead of the contrary (removing system when using boost 1.34). So this means I will be breaking the interface... Comments anyone ? On Tue

Re: [CMake] FindBoost: FIND_PACKAGE ( Boost COMPONENTS filesystem )

2009-11-03 Thread Philip Lowman
This was addressed on the mailing list and I thought had been resolved based on user feedback. The code which is supposed to fix this is on line 326 of FindBoost as checked into CVS. A patch would be appreciated if the code doesn't work for you. See also bug 8734 On Nov 3, 2009 5:05 AM, "Mathie

Re: [CMake] FindBoost: FIND_PACKAGE ( Boost COMPONENTS filesystem )

2009-11-03 Thread Mathieu Malaterre
Hi Philip, That's where I stop understanding. I cannot state this: FIND_PACKAGE ( Boost COMPONENTS filesystem REQUIRED) # ideal If I follow your suggestion I need to express an internal dependencie at user level: FIND_PACKAGE ( Boost COMPONENTS filesystem system REQUIRED) which fails for

Re: [CMake] FindBoost: FIND_PACKAGE ( Boost COMPONENTS filesystem )

2009-11-02 Thread Philip Lowman
Add system to the list of components. FindBoost should silently omit it on older versions of boost w/o a system library. At least I think. Sorry for brief messages, typing on mobile :) On Nov 2, 2009 11:30 AM, "Mathieu Malaterre" wrote: I can reproduce with CMake / CVS. FIND_PACKAGE ( Boost

Re: [CMake] FindBoost: FIND_PACKAGE ( Boost COMPONENTS filesystem )

2009-11-02 Thread Mathieu Malaterre
I can reproduce with CMake / CVS. FIND_PACKAGE ( Boost COMPONENTS filesystem ) ADD_LIBRARY( bla SHARED bla_use_filesystem.cxx) TARGET_LINK_LIBRARIES( bla ${Boost_LIBRARIES} ) -> CMakeFiles/Csm.dir/Common/csmPathSet.cc.o: In function `__static_initialization_and_destruction_0': /usr/include/bo

Re: [CMake] FindBoost: FIND_PACKAGE ( Boost COMPONENTS filesystem )

2009-11-02 Thread Philip Lowman
Which FindBoost are you using? I'm pretty sure I fixed this issue a while ago. On Nov 2, 2009 9:46 AM, "Mathieu Malaterre" wrote: Hi there, I am wondering if I am missing something. I'd like to write: FIND_PACKAGE ( Boost COMPONENTS filesystem ) However using a recent boost (1.40), it give

[CMake] FindBoost: FIND_PACKAGE ( Boost COMPONENTS filesystem )

2009-11-02 Thread Mathieu Malaterre
Hi there, I am wondering if I am missing something. I'd like to write: FIND_PACKAGE ( Boost COMPONENTS filesystem ) However using a recent boost (1.40), it gives a linker error. So I need to write something like: FIND_PACKAGE ( Boost COMPONENTS filesystem system ) but then it breaks comp