Re: [CMake] Re: dangerous regex in CHECK_C_SOURCE_COMPILES

2007-11-13 Thread Brandon Van Every
On Nov 13, 2007 6:28 PM, Bill Hoffman <[EMAIL PROTECTED]> wrote: > > Brandon Van Every wrote: > > On Nov 13, 2007 3:35 PM, Bill Hoffman <[EMAIL PROTECTED]> wrote: > >> A variable name should not contain special characters anyway. > > > > That, however, is not error checking or safety. That's hope.

Re: [CMake] Re: dangerous regex in CHECK_C_SOURCE_COMPILES

2007-11-13 Thread Bill Hoffman
Brandon Van Every wrote: On Nov 13, 2007 3:35 PM, Bill Hoffman <[EMAIL PROTECTED]> wrote: A variable name should not contain special characters anyway. That, however, is not error checking or safety. That's hope. I haven't synthesized an example that will kill CMake in the real world. At so

Re: [CMake] Re: dangerous regex in CHECK_C_SOURCE_COMPILES

2007-11-13 Thread Brandon Van Every
On Nov 13, 2007 3:35 PM, Bill Hoffman <[EMAIL PROTECTED]> wrote: > > A variable name should not contain special characters anyway. That, however, is not error checking or safety. That's hope. I haven't synthesized an example that will kill CMake in the real world. At some point I will do so and

Re: [CMake] Re: dangerous regex in CHECK_C_SOURCE_COMPILES

2007-11-13 Thread Bill Hoffman
Brandon Van Every wrote: I see the same construct in CHECK_INCLUDE_FILES. What is the intent? This is not safe. Cheers, Brandon Van Every On Nov 7, 2007 11:38 AM, Brandon Van Every <[EMAIL PROTECTED]> wrote: It begins with: MACRO(CHECK_C_SOURCE_COMPILES SOURCE VAR) IF("${VAR}" MATCHES "^$

Re: [CMake] Re: dangerous regex in CHECK_C_SOURCE_COMPILES

2007-11-13 Thread David Cole
The intent is to use a construct that works even with older CMake versions such that the code enclosed in the construct only gets run on the first configure. I'm pretty sure it's only dangerous with variables that have dangerous names in the first place. Do you have a concrete example that is giv

[CMake] Re: dangerous regex in CHECK_C_SOURCE_COMPILES

2007-11-13 Thread Brandon Van Every
I see the same construct in CHECK_INCLUDE_FILES. What is the intent? This is not safe. Cheers, Brandon Van Every On Nov 7, 2007 11:38 AM, Brandon Van Every <[EMAIL PROTECTED]> wrote: > It begins with: > > MACRO(CHECK_C_SOURCE_COMPILES SOURCE VAR) > IF("${VAR}" MATCHES "^${VAR}$") > > What is