Re: [CMake] SCC bindings missing AUXPATH support?

2011-11-01 Thread Robert Dailey
On Mon, Oct 31, 2011 at 11:59 PM, Steven Velez sbv1...@gmail.com wrote: Hi Robert, I reviewed the patch, and I am not sure vsAuxPath should be a requirement. As I stated earlier, we've gotten the binding to work acceptably without it and I assume others have as well. Further, some users

Re: [CMake] SCC bindings missing AUXPATH support?

2011-11-01 Thread Steven Velez
Just to be clear, I am not advocating having to deal with the perforce SCC integration dialog for every project in the solution. In our set up, we need to deal with it once for the solution... without having access to AuxPath. However, I do imagine, that it probably has something to do with

[CMake] SCC bindings missing AUXPATH support?

2011-10-31 Thread Robert Dailey
There are actually 4 SCC related key/value pairs used in VS2003 VCPROJ files: SccProjectName=SAK SccAuxPath=SAK SccLocalPath=SAK SccProvider=SAK CMake supports these 3 via set_target_properties(): VS_SCC_LOCALPATH VS_SCC_PROJECTNAME VS_SCC_PROVIDER Apparently one more is needed to support

Re: [CMake] SCC bindings missing AUXPATH support?

2011-10-31 Thread Robert Dailey
I have added source code support for this myself. I updated the following files: cmLocalVisualStudio7Generator.cxx cmLocalVisualStudio10TargetGenerator.cxx The existing SCC support code was already in these files, I just added the SccAuxPath support to it. I'm not an expert at creating patch

Re: [CMake] SCC bindings missing AUXPATH support?

2011-10-31 Thread Robert Dailey
I fiddled around with TortoiseGit and managed to create the patch. It is attached. Please integrate this into your repository so it is included in version 2.8.7 :) - Robert Dailey On Mon, Oct 31, 2011 at 5:41 PM, Robert Dailey rcdai...@gmail.com wrote: I have added source code

Re: [CMake] SCC bindings missing AUXPATH support?

2011-10-31 Thread Robert Dailey
I forgot to explain why I made the change to begin with. Basically this all comes down to Perforce binding support. SccAuxPath is used to specify the Perforce connection string. Without this, each project opened will prompt the user for the information via modal dialog. This gets very annoying...

Re: [CMake] SCC bindings missing AUXPATH support?

2011-10-31 Thread Steven Velez
Hi Robert, I reviewed the patch, and I am not sure vsAuxPath should be a requirement. As I stated earlier, we've gotten the binding to work acceptably without it and I assume others have as well. Further, some users may prefer to enter their connection information in to the perforce dialog on