Re: [CMake] Subversion_WC_INFO macro should not do SEND_ERROR

2010-01-27 Thread Erik Johansson
On Wed, Jan 27, 2010 at 09:03, Marcel Loose wrote: > On Tue, 2010-01-26 at 10:53 -0600, Ryan Pavlik wrote: >> An alternative, of course, is to implement a function or macro in a >> module distributed with CMake, that hides the process of detecting >> whether a directory is a svn working copy and c

Re: [CMake] Subversion_WC_INFO macro should not do SEND_ERROR

2010-01-27 Thread Marcel Loose
On Tue, 2010-01-26 at 10:53 -0600, Ryan Pavlik wrote: > On 1/26/10 10:33 AM, Tyler Roscoe wrote: > > On Tue, Jan 26, 2010 at 10:23:03AM +0100, Marcel Loose wrote: > > > >> Is that portable? I don't do development on Windows, but I vaguely > >> remember that on Windows the ".svn" directories had

Re: [CMake] Subversion_WC_INFO macro should not do SEND_ERROR

2010-01-26 Thread Ryan Pavlik
On 1/26/10 10:33 AM, Tyler Roscoe wrote: On Tue, Jan 26, 2010 at 10:23:03AM +0100, Marcel Loose wrote: Is that portable? I don't do development on Windows, but I vaguely remember that on Windows the ".svn" directories had a different name, because Windows doesn't really like file- and direct

Re: [CMake] Subversion_WC_INFO macro should not do SEND_ERROR

2010-01-26 Thread Tyler Roscoe
On Tue, Jan 26, 2010 at 10:23:03AM +0100, Marcel Loose wrote: > Is that portable? I don't do development on Windows, but I vaguely > remember that on Windows the ".svn" directories had a different name, > because Windows doesn't really like file- and directory names that start > with a dot. Window

Re: [CMake] Subversion_WC_INFO macro should not do SEND_ERROR

2010-01-26 Thread Marcel Loose
On Mon, 2010-01-25 at 10:06 -0500, David Cole wrote: > On Mon, Jan 25, 2010 at 7:37 AM, Marcel Loose wrote: > Hi all, > > IMHO the macro Subversion_WC_INFO in FindSubversion.cmake > should not do > a SEND_ERROR, when the 'svn info' command fails. This makes

Re: [CMake] Subversion_WC_INFO macro should not do SEND_ERROR

2010-01-25 Thread David Cole
On Mon, Jan 25, 2010 at 7:37 AM, Marcel Loose wrote: > Hi all, > > IMHO the macro Subversion_WC_INFO in FindSubversion.cmake should not do > a SEND_ERROR, when the 'svn info' command fails. This makes the macro > useless if you want to be able to use it both on SVN working copies and > SVN export

[CMake] Subversion_WC_INFO macro should not do SEND_ERROR

2010-01-25 Thread Marcel Loose
Hi all, IMHO the macro Subversion_WC_INFO in FindSubversion.cmake should not do a SEND_ERROR, when the 'svn info' command fails. This makes the macro useless if you want to be able to use it both on SVN working copies and SVN exported trees. Either make this behaviour configurable, or change it to