Re: [CMake] TCL modules

2011-11-18 Thread Michael Hertling
On 11/17/2011 05:53 PM, Joe Brandt wrote: I totally agree with your #2. I was thinking that it would be easier to try and update the existing ones, rather than create new ones, at least from the perspective of getting something done more quickly. The main issue with that is that a new

Re: [CMake] TCL modules

2011-11-18 Thread Joe Brandt
I posted a patch showing what I did, but it is waiting on the moderators due to it just barely being over the size limit. In a nutshell though. Once a version is specified I would build a variable for the NAME part of the find_* functions that would force the filename with version first in the

Re: [CMake] TCL modules

2011-11-17 Thread Michael Hertling
On 11/17/2011 12:28 AM, Joe Brandt wrote: I have a couple issues, that I'd like to help fix, with the current FindTCL.cmake, FindTclsh.cmake, FindWish.cmake, and FindTclStub.cmake that make them unusable for me. The first is they do not always find the various components from the same Tcl

Re: [CMake] TCL modules

2011-11-17 Thread Joe Brandt
I totally agree with your #2. I was thinking that it would be easier to try and update the existing ones, rather than create new ones, at least from the perspective of getting something done more quickly. The main issue with that is that a new FindTclTk doesn't need to deal with backwards

[CMake] TCL modules

2011-11-16 Thread Joe Brandt
I have a couple issues, that I'd like to help fix, with the current FindTCL.cmake, FindTclsh.cmake, FindWish.cmake, and FindTclStub.cmake that make them unusable for me. The first is they do not always find the various components from the same Tcl installation on the system. The second being

Re: [CMake] TCL modules

2011-11-16 Thread Clifford Yapp
FWIW, BRL-CAD has its own FindTCL.cmake module which is quite different from the current one, in case that is helpful/of interest: http://brlcad.svn.sf.net/viewvc/brlcad/brlcad/trunk/misc/CMake/FindTCL.cmake?revision=45989view=markup We'd eventually like to fold all of our updates to various