Re: [CMake] add_definitions verus set_source_files_properties

2011-06-01 Thread Michael Wild
On 06/01/2011 09:27 PM, Benjamin Peterson wrote: > Michael Wild writes: > >> Yes, it is considered to be bad practice. If you want the same behavior, >> though, use set_directory_properties(). > > But there's no COMPILE_FLAGS property on directories, is there? > Ooops, sorry. Just append to th

Re: [CMake] add_definitions verus set_source_files_properties

2011-06-01 Thread Benjamin Peterson
Michael Wild writes: > Yes, it is considered to be bad practice. If you want the same behavior, > though, use set_directory_properties(). But there's no COMPILE_FLAGS property on directories, is there? ___ Powered by www.kitware.com Visit other Kit

Re: [CMake] add_definitions verus set_source_files_properties

2011-06-01 Thread Michael Wild
On 06/01/2011 05:51 PM, Benjamin Peterson wrote: > Is it improper to use add_definitions to set compile flags instead of > set_source_files_properties and the COMPILE_FLAGS property? The reason I ask > is > that I prefer the recursive behavior of add_definitions, but > set_source_files_properties

[CMake] add_definitions verus set_source_files_properties

2011-06-01 Thread Benjamin Peterson
Is it improper to use add_definitions to set compile flags instead of set_source_files_properties and the COMPILE_FLAGS property? The reason I ask is that I prefer the recursive behavior of add_definitions, but set_source_files_properties appears to be more modern.