Re: [CMake] test property COST not working in cmake 2.8.3?

2010-12-09 Thread Tyler Roscoe
Ok I've added a link to this thread and the patch below to the bug: http://www.vtk.org/Bug/view.php?id=11561 Without feedback from anyone, I will assume that I have done an awesome, production-ready job and will await the call for patches to add to CMake 2.8.4. Thanks, tyler On Tue, Dec 07,

Re: [CMake] test property COST not working in cmake 2.8.3?

2010-12-09 Thread Zach Mullen
On Thu, Dec 9, 2010 at 12:04 PM, Tyler Roscoe ty...@cryptio.net wrote: Ok I've added a link to this thread and the patch below to the bug: http://www.vtk.org/Bug/view.php?id=11561 Without feedback from anyone, I will assume that I have done an awesome, production-ready job and will await the

Re: [CMake] test property COST not working in cmake 2.8.3?

2010-12-07 Thread Tyler Roscoe
In the process of attempting to fix this, I learned a lot of stuff about how COST is handled that I've never encountered in the docs. Am I missing something? Here are some notes I made about the behavior of COST in CTest. If others find them useful, I'd be happy to put them in the Wiki if someone

Re: [CMake] test property COST not working in cmake 2.8.3?

2010-12-02 Thread Tyler Roscoe
I've taken the liberty of adding this bug to the tracker: http://www.cmake.org/Bug/view.php?id=11561 Can someone give me an idea of how involved this fix is? If it cannot be fixed in short order, I'll be forced to hack around the change in COST's behavior in my own scripts. Fixing the problem at

Re: [CMake] test property COST not working in cmake 2.8.3?

2010-11-30 Thread Tyler Roscoe
On Fri, Nov 26, 2010 at 10:38:44AM -0500, Zach Mullen wrote: I just realized why this isn't working -- it's actually not a regression. Maybe we have different definitions of regression. I see a feature that used to do one thing but which now does something else. Here is what the docs say about

Re: [CMake] test property COST not working in cmake 2.8.3?

2010-11-30 Thread Zach Mullen
Hm, yours was a use case we didn't really consider when we were making changes to cost behavior. The middle ground here would be to respect costs in the non-parallel case when they are expressed explicitly, but not to cost-order them automatically based on their previous run times. -Zach On

Re: [CMake] test property COST not working in cmake 2.8.3?

2010-11-30 Thread Tyler Roscoe
On Tue, Nov 30, 2010 at 01:29:37PM -0500, Zach Mullen wrote: Hm, yours was a use case we didn't really consider when we were making changes to cost behavior. Clearly. :) The middle ground here would be to respect costs in the non-parallel case when they are expressed explicitly This

Re: [CMake] test property COST not working in cmake 2.8.3?

2010-11-26 Thread Zach Mullen
On Tue, Nov 23, 2010 at 6:02 PM, David Cole david.c...@kitware.com wrote: It might be due to this commit: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=142edf8ad4baccd991a6a8a3e5283d0b575acca2 (first released in 2.8.3) Or this one:

Re: [CMake] test property COST not working in cmake 2.8.3?

2010-11-26 Thread Zach Mullen
I just realized why this isn't working -- it's actually not a regression. In this release we decided that the costs should only be taken into account in a parallel case (ctest -j N). Many users have implicit dependencies based on the order of their add_test calls, so we didn't want to break

[CMake] test property COST not working in cmake 2.8.3?

2010-11-23 Thread Tyler Roscoe
I use set_tests_properties (... COST -500) to force my code coverage checks to run after all the unit tests have run. This has stopped working and I'm reasonably confident that the only thing that changed was an upgrade from cmake 2.8.0 or 2.8.1 to 2.8.3. I couldn't find anything in the bug

Re: [CMake] test property COST not working in cmake 2.8.3?

2010-11-23 Thread David Cole
It might be due to this commit: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=142edf8ad4baccd991a6a8a3e5283d0b575acca2 (first released in 2.8.3) Or this one: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=b4d27dc041c9164d6f3ad39e192f4b7d116ca3b3 (first released in 2.8.2) Either way,