[cmake-developers] install bug on windows

2010-09-20 Thread Bill Hoffman
Eric, This commit is breaking windows installs: commit 6a521f8604ee4e6a757109e731a36fdc5575f6c8 Author: Eric NOULARD eric.noul...@gmail.com Date: Mon Aug 23 17:38:33 2010 +0200 CPack Enable better handling of absolute installed files The idea of the patch is to let the install

Re: [cmake-developers] install bug on windows

2010-09-20 Thread Bill Hoffman
On 9/20/2010 1:39 PM, Eric Noulard wrote: 2010/9/20 Eric Noularderic.noul...@gmail.com: 2010/9/20 Bill Hoffmanbill.hoff...@kitware.com: Eric, This commit is breaking windows installs: commit 6a521f8604ee4e6a757109e731a36fdc5575f6c8 Author: Eric NOULARDeric.noul...@gmail.com Date: Mon Aug

Re: [cmake-developers] install bug on windows

2010-09-20 Thread Eric Noulard
2010/9/20 Bill Hoffman bill.hoff...@kitware.com:  What do you think? Seems to be covered: (but I am guessing the install is not actually being called in that case...) Ok then may be I can try to make install called, after I found the test which is triggering this coverage.

Re: [cmake-developers] install bug on windows

2010-09-20 Thread Eric Noulard
2010/9/20 Eric Noulard eric.noul...@gmail.com: 2010/9/20 Bill Hoffman bill.hoff...@kitware.com:  What do you think? Seems to be covered: (but I am guessing the install is not actually being called in that case...) Ok then may be I can try to make install called, after I found the test

[cmake-developers] CMake code style

2010-09-20 Thread Alan W. Irwin
On 2010-09-20 16:20-0400 Bill Hoffman wrote: BTW, this type of code is not allowed in CMake: if (fi!=files.begin()) os ;; Needs to be: if((fi!=files.begin()) { os ;; } If you want a consistent coding style in CMake, I suggest you give uncrustify a look. It is extremely powerful and