Re: [cmake-developers] Ninja generator on Windows

2012-01-30 Thread Bill Hoffman
On 1/30/2012 6:15 PM, Peter Kümmel wrote: I played a bit with the Ninja generator on Windows, and added some hacks to make it a bit running: https://github.com/syntheticpp/CMake/commit/0a55b61271106eb7c3319340f2c54f6bab3c0f8b Here are the problems I found so far: - Paths like 'c:\' - Ninja no

[cmake-developers] Ninja generator on Windows

2012-01-30 Thread Peter Kümmel
I played a bit with the Ninja generator on Windows, and added some hacks to make it a bit running: https://github.com/syntheticpp/CMake/commit/0a55b61271106eb7c3319340f2c54f6bab3c0f8b Here are the problems I found so far: - Paths like 'c:\' - Ninja now supports colon escaping "c:" -> "c$:" Is

[cmake-developers] [CMake 0012920]: FindPythonInterp.cmake fails to find python version

2012-01-30 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://public.kitware.com/Bug/view.php?id=12920 == Reported By:Chip Christian Assigned To:

Re: [cmake-developers] target_include_directories branch in stage

2012-01-30 Thread Stephen Kelly
David Cole wrote: > On Sun, Jan 29, 2012 at 11:44 AM, Stephen Kelly > wrote: >> David Cole wrote: >>> OK... nearly complete now. Please review, then reply and tell me if >>> you object to any of the 7 commits in this topic branch. >> >> No objections. They all seem fine. >> > > Great, thanks. >

Re: [cmake-developers] Support for imported targets in CMAKE_REQUIRED_LIBRARIES

2012-01-30 Thread Brad King
On 1/29/2012 11:37 AM, Alexander Neundorf wrote: I got there because you recommended: "Then the implementation of the command can evaluate the "libs..." arguments in a context where imported targets are known. Loop over each library. For those that this->Makefile->FindTargetToUse() returns a tar

[cmake-developers] Review of upcoming change

2012-01-30 Thread David Cole
Alex, Is this change in the code that expands PACKAGE_INCLUDE_DIRS reasonable? https://github.com/dlrdave/CMake/commit/0a45e23987e4afdc40859b54b0905c3d7c5b91eb#diff-14 Using them directly in the --find-package case rather than going through the local generator (which conditionally adds source

Re: [cmake-developers] target_include_directories branch in stage

2012-01-30 Thread David Cole
On Sun, Jan 29, 2012 at 11:44 AM, Stephen Kelly wrote: > David Cole wrote: >> OK... nearly complete now. Please review, then reply and tell me if >> you object to any of the 7 commits in this topic branch. > > No objections. They all seem fine. > Great, thanks. >> Steve, I've >> preserved your

Re: [cmake-developers] FindImageMagick.cmake backwards compatibility

2012-01-30 Thread David Cole
On Sun, Jan 29, 2012 at 5:39 PM, Miguel A. Figueroa-Villanueva wrote: > On Sun, Jan 29, 2012 at 5:58 PM, Rolf Eike Beer wrote: >> While hacking on various Find*.cmake modules I also made some changes to the >> ImageMagick module, and one of them is not really backwards compatible. I >> would consi

[cmake-developers] [CMake 0012919]: Wrong include path passed to nasm

2012-01-30 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://cmake.org/Bug/view.php?id=12919 == Reported By:Cédric OCHS Assigned To: