Re: [cmake-developers] find_package module-only policy

2012-02-22 Thread Brad King
On 2/21/2012 5:09 PM, Alexander Neundorf wrote: This is now in the FindPackage_CONFIG_MODULEKeywordsFirst branch on stage, [snip] There is the potential issue with CONFIG and MODULE being in use as module names already somewhere. Yes. I hadn't actually intended for you to go straight to

Re: [cmake-developers] find_package module-only policy

2012-02-22 Thread Brad King
On 2/21/2012 4:22 PM, Alexander Neundorf wrote: Problem ? Somebody has a FindConfig.cmake here: http://lists.gforge.inria.fr/pipermail/blobseer-commits/2009- January/000101.html There may be also a FindCONFIG.cmake or a FindMODULE.cmake somewhere... Ignore and just hope it will be ok ?

Re: [cmake-developers] target_include_directories branch in stage

2012-02-22 Thread David Cole
On Thu, Feb 16, 2012 at 4:11 PM, Stephen Kelly steve...@gmail.com wrote: David Cole wrote: Pushed down the queue again... I'll get to it soon. There are a handful of minor changes that I still need to make first. Ok. Let me know if it's anything I can do. Thanks, Steve. -- Powered

Re: [cmake-developers] target_include_directories branch in stage

2012-02-22 Thread Brad King
On 2/22/2012 8:05 AM, David Cole wrote: So the most recent commit in the topic branch, which adds documentation for the target level property, appears useless... Should we eliminate the directory level documentation as well? Or emit both? Emit both and explain their interaction. The

Re: [cmake-developers] Knowing if a C project is being built

2012-02-22 Thread Rolf Eike Beer
Brad King wrote: On Wed, Feb 22, 2012 at 11:32 AM, Rolf Eike Beer e...@sf-mail.de wrote: Use CMAKE_LANG_COMPILER_LOADED to determine which languages are enabled. In the last modification in FindOpenMP I used the ENABLED_LANGUAGES property. Which of both ways is the preferred one? I

Re: [cmake-developers] find_package module-only policy

2012-02-22 Thread Alexander Neundorf
On Wednesday 22 February 2012, Brad King wrote: On 2/21/2012 5:09 PM, Alexander Neundorf wrote: This is now in the FindPackage_CONFIG_MODULEKeywordsFirst branch on stage, [snip] There is the potential issue with CONFIG and MODULE being in use as module names already somewhere.

Re: [cmake-developers] target_include_directories branch in stage

2012-02-22 Thread David Cole
On Wed, Feb 22, 2012 at 8:05 AM, David Cole david.c...@kitware.com wrote: On Thu, Feb 16, 2012 at 4:11 PM, Stephen Kelly steve...@gmail.com wrote: David Cole wrote: Pushed down the queue again... I'll get to it soon. There are a handful of minor changes that I still need to make first. Ok.

Re: [cmake-developers] target_include_directories branch in stage

2012-02-22 Thread David Cole
On Wed, Feb 22, 2012 at 3:04 PM, David Cole david.c...@kitware.com wrote: On Wed, Feb 22, 2012 at 8:05 AM, David Cole david.c...@kitware.com wrote: On Thu, Feb 16, 2012 at 4:11 PM, Stephen Kelly steve...@gmail.com wrote: David Cole wrote: Pushed down the queue again... I'll get to it soon.

Re: [cmake-developers] find_package module-only policy

2012-02-22 Thread Alexander Neundorf
On Wednesday 22 February 2012, Brad King wrote: On 2/22/2012 12:47 PM, Alexander Neundorf wrote: From my side I had no need to discuss, I really like this idea. I mean, I really like this suggestion. Only problem is the FindCONFIG.cmake and FindMODULE.cmake case... If we can find a

Re: [cmake-developers] find_package module-only policy

2012-02-22 Thread Brad King
On 2/22/2012 4:30 PM, Alexander Neundorf wrote: On Wednesday 22 February 2012, Brad King wrote: I think that's too complicated for now. It is much simpler to just put the keywords at the same place as NO_MODULE currently goes. Yes, probably. I will think a bit more about it... Actually

[cmake-developers] Attention ninja-generator developers

2012-02-22 Thread David Cole
Hi there, When I merged the 'target-include-directories' branch to 'next' today, I got build errors on the Continuous dashboards related to the new ninja generator. (Some method signatures changed and had to be updated.) To resolve the errors, I had to get the 'ninja-generator' branch from the

Re: [cmake-developers] target_include_directories branch in stage

2012-02-22 Thread Stephen Kelly
David Cole wrote: All set. One more force-push after cleaning up a commit on Brad's recommendation and it is now finally merged to 'next'. Whew. Great! Thanks for all yor work on getting this through the last mile (or was it more? :)). Thanks, Steve. -- Powered by