On Sat, Mar 10, 2012 at 7:35 AM, Alexander Neundorf neund...@kde.org wrote:
There is now a branch find_package_set_FOUND_VariableInConfigFile on stage.
It behaves almost as you suggested: the _FOUND variable is only removed before
the Config file is loaded, if the variable exists and is false.
On Tuesday 13 March 2012, Brad King wrote:
On 3/10/2012 1:15 PM, Alexander Neundorf wrote:
I pushed a branch ImprovedCOMPONENTSSupportInFindPackage to stage.
It is not finished (documentation and an updated fphsa() are missing at
least), but you may want to have a look at it.
It
On 3/13/2012 1:10 PM, Alexander Neundorf wrote:
One option for cmake 2.8.8 would be, instead of erroring out to consider the
package not found.
That's a nice use case for the new pkg_FOUND behavior we've discussed.
The package configuration file would have to cooperate with the cmake-
Brad King wrote:
My proposal only requires the small change to CMake already under
discussion and makes it possible for projects to provide package
configuration files that handle components in a nice way. It also
does not preclude the possibility of a future convention.
I've been
On Tuesday 13 March 2012, Brad King wrote:
On 3/13/2012 3:25 PM, Alexander Neundorf wrote:
How about this:
* no policy
* new argument find_package( OPTIONAL_COMPONENTS), so we get two sets of
components
* the components are still ignored by find_package() for setting
Foo_FOUND * I add
On Tue, Mar 13, 2012 at 4:43 PM, Alexander Neundorf neund...@kde.org wrote:
We could also not set pkg_FIND_REQUIRED_component, or set it to 0 (which
would mean it is not required).
Even better. One can loop over the_FIND_COMPONENTS list and then test
the variable to see if it is really
I am close to completing the patch file, but have run into one issue that I am
having trouble locating a where I am going wrong.
The condition is when you have installs that fall under 'Unspecified' but the
CPACK_COMPONENT_NONAME_FOR is defined as an existing component.
The current issue is
On Tuesday 13 March 2012, Brad King wrote:
On 3/13/2012 4:23 PM, Alexander Neundorf wrote:
Then force-push back to the stage for another review.
Done.
Thanks. I rewrote and force-pushed the topic to make a few changes:
(1) Tweaked the commit message of the main commit
(2) Tweaked
On Tuesday 13 March 2012, Brad King wrote:
...
The argument parsing in cmFindPackage still has to decide what to do if a
component appears multiple times.
Error out ?
REQUIRED always has priority over OPTIONAL ?
Last one wins ?
I think error is best. It's better to be explicit so
On 3/13/2012 5:10 PM, Alexander Neundorf wrote:
Regarding the error: I think (didn't check) right now cmake doesn't complain
if I list a component multiple times:
find_package(Foo COMPONENTS bar blub bar)
I don't think it does.
If it doesn't, then I'd say
find_package(Foo COMPONENTS bar
On 3/13/2012 5:58 PM, Peter Kümmel wrote:
Not perfect because you tested it on an old build ;)
OK, I did a clean build tree, and it works now, thanks.
I just checked in a fix for
LinkDirectory
The remaining failing tests on windows are:
BuildDepends, ModuleDefinition, Plugin, and
It seems that if the CMakeCache.txt changes, and cmake re-runs, ninja
rebuilds almost ever single .obj file. For example, if I turn on and
off CMAKE_ENABLE_NINJA, Then it rebuilds all the .obj files instead of
relinking just a few executables since the .obj files are there all
ready. I had
The compile and link commands executed by ninja contains the same
option: /FdTARGET_PDB (TARGET_PDB here is literal text, not a
placeholder.) This is a simplified excerpt from a .ninja.log file:
596911219 0 driver\CMakeFiles\foo.dir\foo.cpp.obj C:/Archivos de
programa/Microsoft
On Wed, Mar 14, 2012 at 02:45:44AM +0100, Óscar Fuentes wrote:
The compile and link commands executed by ninja contains the same
option: /FdTARGET_PDB (TARGET_PDB here is literal text, not a
placeholder.) This is a simplified excerpt from a .ninja.log file:
5969 11219 0
On Tue, Mar 13, 2012 at 07:08:31PM -0400, Bill Hoffman wrote:
PrecompiledHeader - This one seems to be a dependency problem.
The first time you run it you get this:
122: Run Build Command:C:/cygwin/bin/ninja.exe
[3/4] Building C object CMakeFiles\foo.dir\foo1.c.obj
122: FAILED:
15 matches
Mail list logo
