[cmake-developers] Deprecating qt4_use_modules and qt4_automoc?

2013-02-06 Thread Stephen Kelly
Hi there, The qt4_use_modules is now mostly obsoleted by tll in CMake 2.8.11. The main difference is that qt4_use_modules does not require the use of imported targets. I think we should deprecate it in favor of using tll() with imported targets (using the imported targets is independent of

Re: [cmake-developers] Deprecating qt4_use_modules and qt4_automoc?

2013-02-06 Thread Marcus D. Hanwell
On Wed, Feb 6, 2013 at 5:46 AM, Stephen Kelly steve...@gmail.com wrote: Hi there, The qt4_use_modules is now mostly obsoleted by tll in CMake 2.8.11. The main difference is that qt4_use_modules does not require the use of imported targets. I think we should deprecate it in favor of using

Re: [cmake-developers] Deprecating qt4_use_modules and qt4_automoc?

2013-02-06 Thread David Cole
-Original Message- From: Marcus D. Hanwell marcus.hanw...@kitware.com To: Stephen Kelly steve...@gmail.com Cc: cmake-developers cmake-developers@cmake.org Sent: Wed, Feb 6, 2013 7:55 am Subject: Re: [cmake-developers] Deprecating qt4_use_modules and qt4_automoc? On Wed, Feb 6,

Re: [cmake-developers] Deprecating qt4_use_modules and qt4_automoc?

2013-02-06 Thread Stephen Kelly
David Cole wrote: I agree with Marcus. There's no reason to deprecate these (other than deprecating Qt4 entirely, but not yet) unless there's a significant code clarity advantage. I think in the case of the qt4_automoc macro at least, there's some technical issue with changes in

Re: [cmake-developers] Deprecating qt4_use_modules and qt4_automoc?

2013-02-06 Thread David Cole
-Original Message- From: Stephen Kelly steve...@gmail.com To: cmake-developers cmake-developers@cmake.org Sent: Wed, Feb 6, 2013 8:17 am Subject: Re: [cmake-developers] Deprecating qt4_use_modules and qt4_automoc? David Cole wrote: I agree with Marcus. There's no reason to deprecate

[cmake-developers] Depends information in buildsystem files

2013-02-06 Thread Stephen Kelly
Hi there, I've pushed a branch with some addtional fixes for various issues in generator expressions. One of the issues relates to depends information in the build dir. I fixed the situation in the makefile generator by expanding the COMPILE_DEFINITIONS before writing out the