Re: [cmake-developers] [PATCH 0/2] Fix some minor annoyances in Xcode generator.

2013-02-17 Thread Brad King
On 2/16/2013 8:23 AM, Mad Fish wrote: Mad Fish (2): Fixed nested source group handling in Xcode generator. Sort source files in Xcode generator. Thanks. Please revise the commit messages to explain in more detail the before and after behaviors and how the patches achieve them. For

Re: [cmake-developers] Setting target properties before the target is defined ?

2013-02-17 Thread Brad King
On 2/15/2013 5:54 PM, Alexander Neundorf wrote: The thing is, if I generate an error at configure time if at the end of a directory a target has been used but has not been defined, i.e. a target Foo has been imported which links against a missing imported target, it would still be possible

Re: [cmake-developers] Adding automatic checks for required targets in target-export files ?

2013-02-17 Thread Brad King
On 2/16/2013 12:32 PM, Alexander Neundorf wrote: There's another try now in ConfigFileTargetChecks5. The export-file now warns if a target does not exist, but does not error out. I think in light of the discussion in the other thread, Setting target properties before the target is defined,

Re: [cmake-developers] Setting target properties before the target is defined ?

2013-02-17 Thread Alexander Neundorf
On Sunday 17 February 2013, Brad King wrote: On 2/15/2013 5:54 PM, Alexander Neundorf wrote: The thing is, if I generate an error at configure time if at the end of a directory a target has been used but has not been defined, i.e. a target Foo has been imported which links against a missing

Re: [cmake-developers] Setting target properties before the target is defined ?

2013-02-17 Thread Alexander Neundorf
On Sunday 17 February 2013, Alexander Neundorf wrote: On Sunday 17 February 2013, Brad King wrote: On 2/15/2013 5:54 PM, Alexander Neundorf wrote: The thing is, if I generate an error at configure time if at the end of a directory a target has been used but has not been defined, i.e. a

Re: [cmake-developers] [PATCH 0/2] Fix some minor annoyances in Xcode generator.

2013-02-17 Thread Alexander Chehovsky
Here is illustration: For the first patch, Fixed nested source group handling in Xcode generator.: * before: http://i.imgur.com/s3Lz7ji.png * after: http://i.imgur.com/11Is2wP.png I'm not sure how to best describe it in a commit message, but the fix is to make code path for nested case build the

Re: [cmake-developers] [PATCH 0/2] Fix some minor annoyances in Xcode generator.

2013-02-17 Thread Alexander Chehovsky
Also, forgot to note that patch Fixed nested source group handling in Xcode generator. resolves this bug: http://public.kitware.com/Bug/view.php?id=12943 I've actually posted a patch there some time ago, but it was not noticed, apparently. On Sun, Feb 17, 2013 at 4:54 PM, Alexander Chehovsky

Re: [cmake-developers] Adding automatic checks for required targets in target-export files ?

2013-02-17 Thread Alexander Neundorf
On Sunday 17 February 2013, Brad King wrote: On 2/16/2013 12:32 PM, Alexander Neundorf wrote: There's another try now in ConfigFileTargetChecks5. The export-file now warns if a target does not exist, but does not error out. I think in light of the discussion in the other thread, Setting

[cmake-developers] [CMake 0013929]: __cpack_system_name incorrectly set when compiling with Mingw-w64

2013-02-17 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://public.kitware.com/Bug/view.php?id=13929 == Reported By:Nathan Osman Assigned To:

Re: [cmake-developers] Adding automatic checks for required targets in target-export files ?

2013-02-17 Thread Stephen Kelly
Alexander Neundorf wrote: On Sunday 17 February 2013, Brad King wrote: On 2/16/2013 12:32 PM, Alexander Neundorf wrote: There's another try now in ConfigFileTargetChecks5. The export-file now warns if a target does not exist, but does not error out. I think in light of the discussion