Re: [cmake-developers] [CMake] please review: fix UseJava.cmake to support dependent jars

2013-03-17 Thread Nicolas Desprès
On Sun, Mar 17, 2013 at 10:49 AM, Nicolas Desprès wrote: > On Thu, Mar 14, 2013 at 3:57 PM, Brad King wrote: > >> On 03/14/2013 10:47 AM, Matthew Woehlke wrote: >> > This is now pushed to stage/fix-java-jar-depends. If someone >> > knowledgeable could have a look, that would be much appreciated.

Re: [cmake-developers] CMAKE_AUTOMOC, system include dirs and target include directories

2013-03-17 Thread Stephen Kelly
Stephen Kelly wrote: > The bug can be reproduced with this cpp file: > > > #include > > // Make CMAKE_AUTOMOC run on this file. > class MyObject : public QObject > { > Q_OBJECT > explicit MyObject(QObject *parent = 0) > { > QSKIP("The QSKIP macro has two args in Qt4 and one in Qt5."); > } > };

Re: [cmake-developers] CMAKE_AUTOMOC, system include dirs and target include directories

2013-03-17 Thread Stephen Kelly
Stephen Kelly wrote: > find_package(Qt5Test) > Something like this is also needed to reproduce without patching Qt: # Temporary until upstream does this: foreach(_component Core Test) if (TARGET Qt5::${_component}) set_property(TARGET Qt5::${_component} APPEND PROPERTY

[cmake-developers] CMAKE_AUTOMOC, system include dirs and target include directories

2013-03-17 Thread Stephen Kelly
Hi there, I applied my patch to kdelibs to use the INTERFACE_INCLUDE_DIRECTORIES of targets and remove include_directories() calls. This resulted in a failure when moc'ing for dfaure: http://thread.gmane.org/gmane.comp.kde.devel.buildsystem/7778/focus=7779 In his system, he has Qt 4 headers

Re: [cmake-developers] [CMake] please review: fix UseJava.cmake to support dependent jars

2013-03-17 Thread Nicolas Desprès
On Thu, Mar 14, 2013 at 3:57 PM, Brad King wrote: > On 03/14/2013 10:47 AM, Matthew Woehlke wrote: > > This is now pushed to stage/fix-java-jar-depends. If someone > > knowledgeable could have a look, that would be much appreciated. > > Andreas, Nicholas? > > Sorry for the delayed response, but I