Re: [cmake-developers] Please review CXXFeatures.cmake

2013-09-20 Thread Brad King
On 09/20/2013 04:32 PM, Rolf Eike Beer wrote: > It solves an entirely different problem. My topic makes CMake detect which > C++ > features the compiler supports. Your topic is about how to get this to the > targets and propagate it to the targets that use them. See the thread that split off fr

Re: [cmake-developers] Please review CXXFeatures.cmake

2013-09-20 Thread Rolf Eike Beer
Am Donnerstag, 15. August 2013, 14:37:42 schrieb Stephen Kelly: > Stephen Kelly wrote: > > Stephen Kelly wrote: > >> I still think you should revisit my review mail on point 2 too. > > > > Something that becomes possible when thinking about the above and target > > properties is interface requirem

Re: [cmake-developers] Please review CXXFeatures.cmake

2013-09-20 Thread Brad King
On 09/20/2013 03:42 PM, Rolf Eike Beer wrote: > Having the interface in a full-featured C++11 way is step 2 or 3 on the way. > I would like to solve the first step first. The problem is that the solution to the later steps cannot be built directly on top of your proposal for the first step. Steve

[cmake-developers] [CMake 0014429]: SET_TARGET_PROPERTIES() Broken for COMPILE_DEFINITIONS?

2013-09-20 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://www.cmake.org/Bug/view.php?id=14429 == Reported By:Rob Stewart Assigned To:

Re: [cmake-developers] Please review CXXFeatures.cmake

2013-09-20 Thread Rolf Eike Beer
Am Dienstag, 13. August 2013, 00:13:19 schrieb Stephen Kelly: > Rolf Eike Beer wrote: > >> 5) > >> > >> This is not nice API: > >>#if defined (CXXFEATURES_NULLPTR_FOUND) > >>void *nix = nullptr; > >>#else /* CXXFEATURES_NULLPTR_FOUND */ > >>void *nix = 0; > >>#endif /* CXXFEATURES_NULLPTR_FOUND */

Re: [cmake-developers] AUTOUIC and AUTORCC for Qt

2013-09-20 Thread Rolf Eike Beer
Am Montag, 16. September 2013, 10:12:41 schrieb Stephen Kelly: > Hi there, > > I've pushed the Qt-auto-generators topic to my clone. > > https://gitorious.org/cmake/steveires-cmake/commits/Qt-auto-generators > > It is a proof of concept for features similar to AUTOMOC, but for invoking > the ui

[cmake-developers] [CMake 0014428]: Enabling Verbose NMAKE Builds

2013-09-20 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://www.cmake.org/Bug/view.php?id=14428 == Reported By:Rob Stewart Assigned To:

Re: [cmake-developers] A type for static plugins?

2013-09-20 Thread Brad King
On 09/20/2013 01:40 PM, Stephen Kelly wrote: > macro(qt_add_plugin name type) > if (${type} STREQUAL STATIC OR ${type} STREQUAL MODULE) > set(_type ${type}) > set(args ${ARGN}) > else() > set(_type MODULE) > set(args ${type} ${ARGN}) > endif() > add_library(${name} ${_type}

Re: [cmake-developers] A type for static plugins?

2013-09-20 Thread Brad King
On 09/20/2013 12:03 PM, Stephen Kelly wrote: > if (my_lib_type STREQUAL SHARED) >add_library(some_plugin MODULE main.cpp) > else() >add_library(some_plugin STATIC > SOURCES main.cpp > PROPERTIES >STATICPLUGIN 1 > # If we need this anyway, we might as well move i

Re: [cmake-developers] A type for static plugins?

2013-09-20 Thread Stephen Kelly
Brad King wrote: > On 09/20/2013 12:03 PM, Stephen Kelly wrote: >> if (my_lib_type STREQUAL SHARED) >>add_library(some_plugin MODULE main.cpp) >> else() >>add_library(some_plugin STATIC >> SOURCES main.cpp >> PROPERTIES >>STATICPLUGIN 1 >> # If we need this anyw

Re: [cmake-developers] CPack BAR package generator

2013-09-20 Thread Stephen Kelly
Eric Noulard wrote: > 2013/9/20 Stephen Kelly > : >> Stephen Kelly writes: >>> https://gitorious.org/~steveire/cmake/steveires-cmake >>> >>> It is the start of a CPack generator for BlackBerry BAR packages, >>> required for deployment to those devices. I haven't worked much with >>> CPack before

Re: [cmake-developers] A type for static plugins?

2013-09-20 Thread Stephen Kelly
Brad King wrote: > IMO that's too special-purpose. However, since it is so common to > add a library and then set properties on it, perhaps there should be > a syntax in add_library and add_executable to inline property settings. > > For example, we could add a keyword signature to declare SOURCE

Re: [cmake-developers] CPack BAR package generator

2013-09-20 Thread Eric Noulard
2013/9/20 Stephen Kelly : > Stephen Kelly writes: >> https://gitorious.org/~steveire/cmake/steveires-cmake >> >> It is the start of a CPack generator for BlackBerry BAR packages, required >> for deployment to those devices. I haven't worked much with CPack before, so >> I'd appreciate some feedba

Re: [cmake-developers] CPack BAR package generator

2013-09-20 Thread Stephen Kelly
Stephen Kelly writes: > https://gitorious.org/~steveire/cmake/steveires-cmake > > It is the start of a CPack generator for BlackBerry BAR packages, required > for deployment to those devices. I haven't worked much with CPack before, so > I'd appreciate some feedback even at this early point.

Re: [cmake-developers] AUTOUIC and AUTORCC for Qt

2013-09-20 Thread Stephen Kelly
Stephen Kelly wrote: > Any comments? > Clinton, Brad, Alex, any comments on this? Thanks, Steve. -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://w

Re: [cmake-developers] A type for static plugins?

2013-09-20 Thread Brad King
On 09/20/2013 09:59 AM, Stephen Kelly wrote: > Another alternative would be for > > add_library(myplugin STATIC_MODULE foo.cpp) > > be exactly equivalent to > > add_library(myplugin STATIC foo.cpp) > set_property(TARGET myplugin PROPERTY STATICPLUGIN 1) IMO that's too special-purpose. How

Re: [cmake-developers] A type for static plugins?

2013-09-20 Thread Stephen Kelly
Brad King wrote: >> So the answer is, 'probably nothing'. > > In that case I do not think we can justify a special CMake > target type for it. All the special cases for STATIC_LIBRARY > targets will have to be updated to also account for the new > type with no difference in logic. Another alter

Re: [cmake-developers] A type for static plugins?

2013-09-20 Thread Brad King
On 09/20/2013 09:10 AM, Stephen Kelly wrote: > Brad King wrote: >> add_library(mystatic_library STATIC foo.cpp) >> set_property(TARGET mystatic_library PROPERTY QT_STATICPLUGIN 1) >> target_link_libraries(mystatic_library Qt5::Core) > > Yes, but I don't think that's better than > > add_library(m

Re: [cmake-developers] Targets for FindGTK2.cmake

2013-09-20 Thread Brad King
On 09/19/2013 04:46 AM, Daniele E. Domenichelli wrote: > Looks like that all the tests are fixed on all the builds now :) I see failures such as: http://open.cdash.org/testDetails.php?test=209170401&build=3034240 /usr/include/ft2build.h:56:38: fatal error: freetype/config/ftheader.h: No such f

Re: [cmake-developers] A type for static plugins?

2013-09-20 Thread David Cole
I was going to recommend the same thing Brad did... But it's even better that you can do it just as succinctly with existing mechanisms. D -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-t

Re: [cmake-developers] A type for static plugins?

2013-09-20 Thread Stephen Kelly
Brad King wrote: > On 09/20/2013 08:54 AM, Stephen Kelly wrote: >> Brad King wrote: >>> Other than the TYPE being a different name, how would CMake >>> treat this target type differently? >> >> So the answer is, 'probably nothing'. > > In that case I do not think we can justify a special CMake >

Re: [cmake-developers] A type for static plugins?

2013-09-20 Thread Brad King
On 09/20/2013 08:54 AM, Stephen Kelly wrote: > Brad King wrote: >> Other than the TYPE being a different name, how would CMake >> treat this target type differently? > > So the answer is, 'probably nothing'. In that case I do not think we can justify a special CMake target type for it. All the s

Re: [cmake-developers] A type for static plugins?

2013-09-20 Thread Stephen Kelly
Brad King wrote: > On 09/20/2013 08:14 AM, Stephen Kelly wrote: >> Any comments on adding a new STATIC_MODULE type to CMake? > > Other than the TYPE being a different name, how would CMake > treat this target type differently? In the case of Qt, I don't see much else relevantly different between

Re: [cmake-developers] A type for static plugins?

2013-09-20 Thread Brad King
On 09/20/2013 08:14 AM, Stephen Kelly wrote: > Any comments on adding a new STATIC_MODULE type to CMake? Other than the TYPE being a different name, how would CMake treat this target type differently? -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.ki

[cmake-developers] A type for static plugins?

2013-09-20 Thread Stephen Kelly
Hello, In CMake, the MODULE_LIBRARY type is quite like a shared library which is not linked to. In Qt, there is a concept of a static plugin. This is essentially just a static library, but there is buildsystem awareness of the difference. When building a static library using Qt, the QT_STATI