> On 03/01/2014 07:40 AM, Jiri Malak wrote:
>> I enclosed patch with update to CMake documentation, correct HOST/TARGET
>> system related variables description.
>
> Thanks. Please revise the changes to add reStructuredText markup
> for inline-literals and cross-references as explained in the
> cma
>> Exists some rules for tempary variables names used in scripts?
>
> There is no official rule but the convention has tended to be
> a leading "_" for internal variables. For those that have fully
> local scope (i.e. not across files or functions) use all lower
> case names.
>
> In this case I th
On 03/03/2014 11:59 AM, Jiri Malak wrote:
> Exists some rules for tempary variables names used in scripts?
There is no official rule but the convention has tended to be
a leading "_" for internal variables. For those that have fully
local scope (i.e. not across files or functions) use all lower
c
On 03/03/2014 11:46 AM, Jiri Malak wrote:
> It is hard for me to find some CMake concept document
CMake 3.0 introduced new manuals that may help, such as
cmake-buildsystem(7) and cmake-toolchains(7):
http://www.cmake.org/cmake/help/v3.0/manual/cmake-buildsystem.7.html
http://www.cmake.org/cmake
On 03/03/14 17:21, Brad King wrote:
> Please add a Tests/RunCMake/FeatureSummary test to cover at least the
> new error messages.
Done, added unit tests for all the "WHAT" argument cases.
Cheers,
Daniele
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.k
> On 02/28/2014 10:08 PM, J Decker wrote:
>> and a fix for 'option implib[=...]' as part of the wlink since it's a
>> one step anyway and not a dependant step
>
> Your previous patch for this:
>
> Watcom: Fix creation of DLLs without any exported symbols
> http://cmake.org/gitweb?p=cmake.git;a=co
> On 02/28/2014 09:47 PM, Jiri Malak wrote:
>> remove hardcoded version number for RTDLL.
>> It is derived from compiler version now
>
> Good, thanks. Just a couple comments:
>
> The patch seems to make some unrelated whitespace changes. Please
> factor those out into a separate commit.
>
> The W
> On 03/01/2014 08:53 AM, Jiri Malak wrote:
>> I am working on full cross-compilation stuff for Open Watcom toolchain in
>> CMake.
>> I study CMake internals, but I am not sure what is prefered method for
>> cross-compilation by
>> CMake.
>> I see two concept one for Microsoft compilers where eac
On 02/28/2014 12:17 PM, Daniele E. Domenichelli wrote:
> Please review the topic FeatureSummary_combine_WHAT_values.
>
> This patch allows to combine and reorder values for the "WHAT" option in
> FeatureSummary.
In principle the change looks good to me but I'm not familiar with this
module as a d
On 03/01/2014 07:40 AM, Jiri Malak wrote:
> I enclosed patch with update to CMake documentation, correct HOST/TARGET
> system related variables description.
Thanks. Please revise the changes to add reStructuredText markup
for inline-literals and cross-references as explained in the
cmake-develope
On 02/28/2014 10:08 PM, J Decker wrote:
> and a fix for 'option implib[=...]' as part of the wlink since it's a
> one step anyway and not a dependant step
Your previous patch for this:
Watcom: Fix creation of DLLs without any exported symbols
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=0
On 02/28/2014 09:47 PM, Jiri Malak wrote:
> remove hardcoded version number for RTDLL.
> It is derived from compiler version now
Good, thanks. Just a couple comments:
The patch seems to make some unrelated whitespace changes. Please
factor those out into a separate commit.
The WATCOM variables
On 03/01/2014 08:53 AM, Jiri Malak wrote:
> I am working on full cross-compilation stuff for Open Watcom toolchain in
> CMake.
> I study CMake internals, but I am not sure what is prefered method for
> cross-compilation by CMake.
> I see two concept one for Microsoft compilers where each target p
The following issue has been SUBMITTED.
==
http://www.cmake.org/Bug/view.php?id=14783
==
Reported By:philrosenberg
Assigned To:
14 matches
Mail list logo
